@samitouri / QOS-React / commits / 4e8121a75e

Remove @providesModule remnants (#28720)

Remove @providesModule remnants Removes `@providesModule` from the generated RN modules and CI validation that no `@providesModule` is added which should no longer be needed as this has been the case for years now.

Jan Kassens committed Apr 3, 2024 at 09:10 UTC 4e8121a75ec7fa838fc781cbab418d40218678a9
3 files changed -21
.circleci/config.yml
-1
@@ -84,7 +84,6 @@ jobs:
84 - run: node ./scripts/prettier/index
85 - run: node ./scripts/tasks/eslint
86 - run: ./scripts/circleci/check_license.sh
87 - - run: ./scripts/circleci/check_modules.sh
87 - run: ./scripts/circleci/test_print_warnings.sh
88
89 yarn_flow:
scripts/circleci/check_modules.sh deleted
-17
@@ -1,17 +0,0 @@
1 -#!/bin/bash
2 -
3 -set -e
4 -
5 -# Make sure we don't introduce accidental @providesModule annotations.
6 -EXPECTED='scripts/rollup/wrappers.js'
7 -ACTUAL=$(git grep -l @providesModule -- './*.js' ':!scripts/rollup/shims/*.js')
8 -
9 -# Colors
10 -red=$'\e[1;31m'
11 -end=$'\e[0m'
12 -
13 -if [ "$EXPECTED" != "$ACTUAL" ]; then
14 - printf "%s\n" "${red}ERROR: @providesModule crept into some new files?${end}"
15 - diff -u <(echo "$EXPECTED") <(echo "$ACTUAL") || true
16 - exit 1
17 -fi
scripts/rollup/wrappers.js
-3
@@ -406,7 +406,6 @@ ${license}
406 *
407 * @noflow
408 * @nolint
409 - * @providesModule ${globalName}-dev
409 * @preventMunge
410 * ${getSigningToken()}
411 */
@@ -421,7 +420,6 @@ ${license}
420 *
421 * @noflow
422 * @nolint
424 - * @providesModule ${globalName}-prod
423 * @preventMunge
424 * ${getSigningToken()}
425 */
@@ -436,7 +434,6 @@ ${license}
434 *
435 * @noflow
436 * @nolint
439 - * @providesModule ${globalName}-profiling
437 * @preventMunge
438 * ${getSigningToken()}
439 */