Removed Fabric-specific feature flag files and updated Rollup to use the (non-Fabric) React Native flag files. (#14437)
Brian Vaughn committed
Dec 14, 2018 at 07:54 UTC
535804f5c822e12bd6d89ad0081d45355e01cea3
5 files changed
+4
-80
packages/react-native-renderer/src/__tests__/ReactFabric-test.internal.js
+1
-1
@@ -18,7 +18,7 @@ let FabricUIManager;
18
let StrictMode;
19
20
jest.mock('shared/ReactFeatureFlags', () =>
21
- require('shared/forks/ReactFeatureFlags.native-fabric-oss'),
21
+ require('shared/forks/ReactFeatureFlags.native-oss'),
22
);
23
24
describe('ReactFabric', () => {
packages/react-native-renderer/src/__tests__/ReactFabricAndNative-test.internal.js
+1
-1
@@ -21,7 +21,7 @@ describe('ReactFabric', () => {
21
ReactNative = require('react-native-renderer');
22
jest.resetModules();
23
jest.mock('shared/ReactFeatureFlags', () =>
24
- require('shared/forks/ReactFeatureFlags.native-fabric-oss'),
24
+ require('shared/forks/ReactFeatureFlags.native-oss'),
25
);
26
27
React = require('react');
packages/shared/forks/ReactFeatureFlags.native-fabric-fb.js
deleted
-38
@@ -1,38 +0,0 @@
1
-/**
2
- * Copyright (c) Facebook, Inc. and its affiliates.
3
- *
4
- * This source code is licensed under the MIT license found in the
5
- * LICENSE file in the root directory of this source tree.
6
- *
7
- * @flow
8
- */
9
-
10
-import invariant from 'shared/invariant';
11
-
12
-import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
13
-import typeof * as FabricFeatureFlagsType from './ReactFeatureFlags.native-fabric-fb';
14
-
15
-export const debugRenderPhaseSideEffects = false;
16
-export const debugRenderPhaseSideEffectsForStrictMode = false;
17
-export const enableUserTimingAPI = __DEV__;
18
-export const enableHooks = true;
19
-export const warnAboutDeprecatedLifecycles = false;
20
-export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
21
-export const enableProfilerTimer = __PROFILE__;
22
-export const enableSchedulerTracing = __PROFILE__;
23
-export const enableSuspenseServerRenderer = false;
24
-export const disableInputAttributeSyncing = false;
25
-export const enableStableConcurrentModeAPIs = false;
26
-export const warnAboutShorthandPropertyCollision = false;
27
-export const enableSchedulerDebugging = false;
28
-
29
-// Only used in www builds.
30
-export function addUserTimingListener() {
31
- invariant(false, 'Not implemented.');
32
-}
33
-
34
-// Flow magic to verify the exports of this file match the original version.
35
-// eslint-disable-next-line no-unused-vars
36
-type Check<_X, Y: _X, X: Y = _X> = null;
37
-// eslint-disable-next-line no-unused-expressions
38
-(null: Check<FabricFeatureFlagsType, FeatureFlagsType>);
packages/shared/forks/ReactFeatureFlags.native-fabric-oss.js
deleted
-38
@@ -1,38 +0,0 @@
1
-/**
2
- * Copyright (c) Facebook, Inc. and its affiliates.
3
- *
4
- * This source code is licensed under the MIT license found in the
5
- * LICENSE file in the root directory of this source tree.
6
- *
7
- * @flow
8
- */
9
-
10
-import invariant from 'shared/invariant';
11
-
12
-import typeof * as FeatureFlagsType from 'shared/ReactFeatureFlags';
13
-import typeof * as FabricFeatureFlagsType from './ReactFeatureFlags.native-fabric-oss';
14
-
15
-export const debugRenderPhaseSideEffects = false;
16
-export const debugRenderPhaseSideEffectsForStrictMode = false;
17
-export const enableUserTimingAPI = __DEV__;
18
-export const enableHooks = false;
19
-export const warnAboutDeprecatedLifecycles = false;
20
-export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
21
-export const enableProfilerTimer = __PROFILE__;
22
-export const enableSchedulerTracing = __PROFILE__;
23
-export const enableSuspenseServerRenderer = false;
24
-export const disableInputAttributeSyncing = false;
25
-export const enableStableConcurrentModeAPIs = false;
26
-export const warnAboutShorthandPropertyCollision = false;
27
-export const enableSchedulerDebugging = false;
28
-
29
-// Only used in www builds.
30
-export function addUserTimingListener() {
31
- invariant(false, 'Not implemented.');
32
-}
33
-
34
-// Flow magic to verify the exports of this file match the original version.
35
-// eslint-disable-next-line no-unused-vars
36
-type Check<_X, Y: _X, X: Y = _X> = null;
37
-// eslint-disable-next-line no-unused-expressions
38
-(null: Check<FabricFeatureFlagsType, FeatureFlagsType>);
scripts/rollup/forks.js
+2
-2
@@ -88,11 +88,11 @@ const forks = Object.freeze({
88
case RN_FB_DEV:
89
case RN_FB_PROD:
90
case RN_FB_PROFILING:
91
- return 'shared/forks/ReactFeatureFlags.native-fabric-fb.js';
91
+ return 'shared/forks/ReactFeatureFlags.native-fb.js';
92
case RN_OSS_DEV:
93
case RN_OSS_PROD:
94
case RN_OSS_PROFILING:
95
- return 'shared/forks/ReactFeatureFlags.native-fabric-oss.js';
95
+ return 'shared/forks/ReactFeatureFlags.native-oss.js';
96
default:
97
throw Error(
98
`Unexpected entry (${entry}) and bundleType (${bundleType})`