Remove conditional __DEV__ wrapper from RN bundles (#10171)
This causes an error with the older version of JSC packaged for Android.
Brian Vaughn committed
Jul 13, 2017 at 09:26 UTC
5495e495de0bd15cd96a76ee0d7ca823cc09cc71
2 files changed
+67
-66
scripts/rollup/build.js
+5
-4
@@ -85,8 +85,10 @@ function getBanner(bundleType, hasteName, filename) {
85
return `'use strict';\n\n\nif (process.env.NODE_ENV !== "production") {\n`;
86
case NODE_PROD:
87
return '';
88
- // FB and RN DEV bundles are also guarded.
89
- // Additionally, all FB and RN bundles need Haste headers.
88
+ // All FB and RN bundles need Haste headers.
89
+ // FB DEV bundles are also guarded;
90
+ // RN bundles are not b'c of an older JSC packaged for Android.
91
+ // See github.com/facebook/react-native/issues/14995
92
case FB_DEV:
93
case FB_PROD:
94
case RN_DEV:
@@ -95,7 +97,7 @@ function getBanner(bundleType, hasteName, filename) {
97
const hasteFinalName = hasteName + (isDev ? '-dev' : '-prod');
98
return (
99
Header.getProvidesHeader(hasteFinalName) +
98
- (isDev ? `\n\n'use strict';\n\n\nif (__DEV__) {\n` : '')
100
+ (bundleType === FB_DEV ? `\n\n'use strict';\n\n\nif (__DEV__) {\n` : '')
101
);
102
default:
103
throw new Error('Unknown type.');
@@ -108,7 +110,6 @@ function getFooter(bundleType) {
110
// Non-UMD DEV bundles need conditions to help weak dead code elimination.
111
case NODE_DEV:
112
case FB_DEV:
111
- case RN_DEV:
113
return '\n}\n';
114
default:
115
return '';
scripts/rollup/results.json
+62
-62
@@ -25,36 +25,36 @@
25
"gzip": 7214
26
},
27
"react-dom.development.js (UMD_DEV)": {
28
- "size": 623004,
29
- "gzip": 142505
28
+ "size": 623332,
29
+ "gzip": 142653
30
},
31
"react-dom.production.min.js (UMD_PROD)": {
32
- "size": 126045,
33
- "gzip": 39908
32
+ "size": 126056,
33
+ "gzip": 39910
34
},
35
"react-dom.development.js (NODE_DEV)": {
36
- "size": 581665,
37
- "gzip": 132841
36
+ "size": 581993,
37
+ "gzip": 132990
38
},
39
"react-dom.production.min.js (NODE_PROD)": {
40
- "size": 122410,
41
- "gzip": 38579
40
+ "size": 122421,
41
+ "gzip": 38581
42
},
43
"ReactDOMFiber-dev.js (FB_DEV)": {
44
- "size": 580949,
45
- "gzip": 132865
44
+ "size": 581277,
45
+ "gzip": 133016
46
},
47
"ReactDOMFiber-prod.js (FB_PROD)": {
48
- "size": 426819,
49
- "gzip": 96885
48
+ "size": 427011,
49
+ "gzip": 96971
50
},
51
"react-dom-test-utils.development.js (NODE_DEV)": {
52
- "size": 52996,
53
- "gzip": 13677
52
+ "size": 53430,
53
+ "gzip": 13782
54
},
55
"ReactTestUtils-dev.js (FB_DEV)": {
56
- "size": 52875,
57
- "gzip": 13637
56
+ "size": 53309,
57
+ "gzip": 13741
58
},
59
"ReactDOMServerStack-dev.js (FB_DEV)": {
60
"size": 460810,
@@ -65,20 +65,20 @@
65
"gzip": 81957
66
},
67
"react-dom-server.development.js (UMD_DEV)": {
68
- "size": 308414,
69
- "gzip": 77283
68
+ "size": 308607,
69
+ "gzip": 77369
70
},
71
"react-dom-server.production.min.js (UMD_PROD)": {
72
- "size": 65498,
73
- "gzip": 22267
72
+ "size": 65509,
73
+ "gzip": 22270
74
},
75
"react-dom-server.development.js (NODE_DEV)": {
76
- "size": 267260,
77
- "gzip": 67829
76
+ "size": 267453,
77
+ "gzip": 67912
78
},
79
"react-dom-server.production.min.js (NODE_PROD)": {
80
- "size": 61836,
81
- "gzip": 20968
80
+ "size": 61847,
81
+ "gzip": 20971
82
},
83
"ReactDOMServerStream-dev.js (FB_DEV)": {
84
"size": 264750,
@@ -89,64 +89,64 @@
89
"gzip": 51047
90
},
91
"react-art.development.js (UMD_DEV)": {
92
- "size": 359303,
93
- "gzip": 79940
92
+ "size": 359438,
93
+ "gzip": 80006
94
},
95
"react-art.production.min.js (UMD_PROD)": {
96
"size": 97521,
97
"gzip": 29904
98
},
99
"react-art.development.js (NODE_DEV)": {
100
- "size": 280721,
101
- "gzip": 59867
100
+ "size": 280856,
101
+ "gzip": 59940
102
},
103
"react-art.production.min.js (NODE_PROD)": {
104
"size": 58905,
105
"gzip": 17961
106
},
107
"ReactARTFiber-dev.js (FB_DEV)": {
108
- "size": 280154,
109
- "gzip": 59786
108
+ "size": 280289,
109
+ "gzip": 59860
110
},
111
"ReactARTFiber-prod.js (FB_PROD)": {
112
"size": 215532,
113
"gzip": 44949
114
},
115
"ReactNativeStack-dev.js (RN_DEV)": {
116
- "size": 197039,
117
- "gzip": 36193
116
+ "size": 185421,
117
+ "gzip": 35755
118
},
119
"ReactNativeStack-prod.js (RN_PROD)": {
120
- "size": 136606,
121
- "gzip": 25990
120
+ "size": 136551,
121
+ "gzip": 25968
122
},
123
"ReactNativeFiber-dev.js (RN_DEV)": {
124
- "size": 298654,
125
- "gzip": 51338
124
+ "size": 281528,
125
+ "gzip": 50908
126
},
127
"ReactNativeFiber-prod.js (RN_PROD)": {
128
"size": 218380,
129
"gzip": 37833
130
},
131
"react-test-renderer.development.js (NODE_DEV)": {
132
- "size": 277864,
133
- "gzip": 58787
132
+ "size": 277999,
133
+ "gzip": 58861
134
},
135
"ReactTestRendererFiber-dev.js (FB_DEV)": {
136
- "size": 277288,
137
- "gzip": 58707
136
+ "size": 277423,
137
+ "gzip": 58778
138
},
139
"react-test-renderer-shallow.development.js (NODE_DEV)": {
140
- "size": 8179,
141
- "gzip": 2288
140
+ "size": 8437,
141
+ "gzip": 2308
142
},
143
"ReactShallowRenderer-dev.js (FB_DEV)": {
144
- "size": 8080,
145
- "gzip": 2237
144
+ "size": 8338,
145
+ "gzip": 2255
146
},
147
"react-noop-renderer.development.js (NODE_DEV)": {
148
- "size": 272012,
149
- "gzip": 57213
148
+ "size": 272147,
149
+ "gzip": 57284
150
},
151
"ReactHTMLString-dev.js (FB_DEV)": {
152
"size": 265654,
@@ -181,20 +181,20 @@
181
"gzip": 50920
182
},
183
"ReactDOMServer-dev.js (FB_DEV)": {
184
- "size": 266711,
185
- "gzip": 67754
184
+ "size": 266904,
185
+ "gzip": 67836
186
},
187
"ReactDOMServer-prod.js (FB_PROD)": {
188
- "size": 196897,
189
- "gzip": 50775
188
+ "size": 197089,
189
+ "gzip": 50856
190
},
191
"react-dom-node-stream.development.js (NODE_DEV)": {
192
- "size": 268954,
193
- "gzip": 68326
192
+ "size": 269147,
193
+ "gzip": 68409
194
},
195
"react-dom-node-stream.production.min.js (NODE_PROD)": {
196
- "size": 62773,
197
- "gzip": 21284
196
+ "size": 62784,
197
+ "gzip": 21287
198
},
199
"ReactDOMNodeStream-dev.js (FB_DEV)": {
200
"size": 264918,
@@ -205,28 +205,28 @@
205
"gzip": 50956
206
},
207
"react-dom-unstable-native-dependencies.development.js (UMD_DEV)": {
208
- "size": 83733,
209
- "gzip": 20936
208
+ "size": 83909,
209
+ "gzip": 21018
210
},
211
"react-dom-unstable-native-dependencies.production.min.js (UMD_PROD)": {
212
"size": 18318,
213
"gzip": 5971
214
},
215
"react-dom-unstable-native-dependencies.development.js (NODE_DEV)": {
216
- "size": 77146,
217
- "gzip": 18982
216
+ "size": 77322,
217
+ "gzip": 19063
218
},
219
"react-dom-unstable-native-dependencies.production.min.js (NODE_PROD)": {
220
"size": 16620,
221
"gzip": 5340
222
},
223
"ReactDOMUnstableNativeDependencies-dev.js (FB_DEV)": {
224
- "size": 76860,
225
- "gzip": 18942
224
+ "size": 77036,
225
+ "gzip": 19026
226
},
227
"ReactDOMUnstableNativeDependencies-prod.js (FB_PROD)": {
228
- "size": 65759,
229
- "gzip": 15615
228
+ "size": 65934,
229
+ "gzip": 15705
230
}
231
}
232
}
\ No newline at end of file