@samitouri / QOS-React / commits / 6405efc368

Enabled Profiling feature flags for OSS release (#21565)

* Enabled Profiling feature flags for OSS release `enableProfilerCommitHooks` and `enableProfilerNestedUpdatePhase`

Brian Vaughn committed May 25, 2021 at 14:32 UTC 6405efc368a75b2b2f5eb80cdf0fda03ba644748
8 files changed +40 -40
packages/react-devtools-shared/src/__tests__/__snapshots__/profilingCache-test.js.snap
+26 -26
@@ -113,7 +113,7 @@ Object {
113 },
114 },
115 "duration": 3,
116 - "effectDuration": null,
116 + "effectDuration": 0,
117 "fiberActualDurations": Map {
118 7 => 3,
119 3 => 3,
@@ -122,7 +122,7 @@ Object {
122 7 => 3,
123 3 => 0,
124 },
125 - "passiveEffectDuration": null,
125 + "passiveEffectDuration": 0,
126 "priorityLevel": "Immediate",
127 "timestamp": 18,
128 "updaters": Array [
@@ -286,7 +286,7 @@ Object {
286 },
287 },
288 "duration": 10,
289 - "effectDuration": null,
289 + "effectDuration": 0,
290 "fiberActualDurations": Map {
291 4 => 0,
292 2 => 10,
@@ -297,7 +297,7 @@ Object {
297 2 => 10,
298 1 => 0,
299 },
300 - "passiveEffectDuration": null,
300 + "passiveEffectDuration": 0,
301 "priorityLevel": "Immediate",
302 "timestamp": 35,
303 "updaters": Array [
@@ -326,7 +326,7 @@ Object {
326 },
327 },
328 "duration": 10,
329 - "effectDuration": null,
329 + "effectDuration": 0,
330 "fiberActualDurations": Map {
331 2 => 10,
332 1 => 10,
@@ -335,7 +335,7 @@ Object {
335 2 => 10,
336 1 => 0,
337 },
338 - "passiveEffectDuration": null,
338 + "passiveEffectDuration": 0,
339 "priorityLevel": "Immediate",
340 "timestamp": 45,
341 "updaters": Array [
@@ -587,7 +587,7 @@ Object {
587 ],
588 ],
589 "duration": 10,
590 - "effectDuration": null,
590 + "effectDuration": 0,
591 "fiberActualDurations": Array [
592 Array [
593 4,
@@ -616,7 +616,7 @@ Object {
616 0,
617 ],
618 ],
619 - "passiveEffectDuration": null,
619 + "passiveEffectDuration": 0,
620 "priorityLevel": "Immediate",
621 "timestamp": 35,
622 "updaters": Array [
@@ -645,7 +645,7 @@ Object {
645 ],
646 ],
647 "duration": 10,
648 - "effectDuration": null,
648 + "effectDuration": 0,
649 "fiberActualDurations": Array [
650 Array [
651 2,
@@ -666,7 +666,7 @@ Object {
666 0,
667 ],
668 ],
669 - "passiveEffectDuration": null,
669 + "passiveEffectDuration": 0,
670 "priorityLevel": "Immediate",
671 "timestamp": 45,
672 "updaters": Array [
@@ -1367,7 +1367,7 @@ Object {
1367 },
1368 },
1369 "duration": 10,
1370 - "effectDuration": null,
1370 + "effectDuration": 0,
1371 "fiberActualDurations": Map {
1372 4 => 0,
1373 2 => 10,
@@ -1378,7 +1378,7 @@ Object {
1378 2 => 10,
1379 1 => 0,
1380 },
1381 - "passiveEffectDuration": null,
1381 + "passiveEffectDuration": 0,
1382 "priorityLevel": "Immediate",
1383 "timestamp": 34,
1384 "updaters": Array [
@@ -1404,7 +1404,7 @@ Object {
1404 },
1405 },
1406 "duration": 10,
1407 - "effectDuration": null,
1407 + "effectDuration": 0,
1408 "fiberActualDurations": Map {
1409 2 => 10,
1410 1 => 10,
@@ -1413,7 +1413,7 @@ Object {
1413 2 => 10,
1414 1 => 0,
1415 },
1416 - "passiveEffectDuration": null,
1416 + "passiveEffectDuration": 0,
1417 "priorityLevel": "Immediate",
1418 "timestamp": 44,
1419 "updaters": Array [
@@ -1683,10 +1683,10 @@ Object {
1683 Object {
1684 "changeDescriptions": Map {},
1685 "duration": 0,
1686 - "effectDuration": null,
1686 + "effectDuration": 0,
1687 "fiberActualDurations": Map {},
1688 "fiberSelfDurations": Map {},
1689 - "passiveEffectDuration": null,
1689 + "passiveEffectDuration": 0,
1690 "priorityLevel": "Normal",
1691 "timestamp": 34,
1692 "updaters": Array [
@@ -1900,7 +1900,7 @@ Object {
1900 ],
1901 ],
1902 "duration": 10,
1903 - "effectDuration": null,
1903 + "effectDuration": 0,
1904 "fiberActualDurations": Array [
1905 Array [
1906 4,
@@ -1929,7 +1929,7 @@ Object {
1929 0,
1930 ],
1931 ],
1932 - "passiveEffectDuration": null,
1932 + "passiveEffectDuration": 0,
1933 "priorityLevel": "Immediate",
1934 "timestamp": 34,
1935 "updaters": Array [
@@ -1958,7 +1958,7 @@ Object {
1958 ],
1959 ],
1960 "duration": 10,
1961 - "effectDuration": null,
1961 + "effectDuration": 0,
1962 "fiberActualDurations": Array [
1963 Array [
1964 2,
@@ -1979,7 +1979,7 @@ Object {
1979 0,
1980 ],
1981 ],
1982 - "passiveEffectDuration": null,
1982 + "passiveEffectDuration": 0,
1983 "priorityLevel": "Immediate",
1984 "timestamp": 44,
1985 "updaters": Array [
@@ -2306,10 +2306,10 @@ Object {
2306 Object {
2307 "changeDescriptions": Array [],
2308 "duration": 0,
2309 - "effectDuration": null,
2309 + "effectDuration": 0,
2310 "fiberActualDurations": Array [],
2311 "fiberSelfDurations": Array [],
2312 - "passiveEffectDuration": null,
2312 + "passiveEffectDuration": 0,
2313 "priorityLevel": "Normal",
2314 "timestamp": 34,
2315 "updaters": Array [
@@ -2494,7 +2494,7 @@ Object {
2494 },
2495 },
2496 "duration": 0,
2497 - "effectDuration": null,
2497 + "effectDuration": 0,
2498 "fiberActualDurations": Map {
2499 1 => 0,
2500 2 => 0,
@@ -2505,7 +2505,7 @@ Object {
2505 2 => 0,
2506 3 => 0,
2507 },
2508 - "passiveEffectDuration": null,
2508 + "passiveEffectDuration": 0,
2509 "priorityLevel": "Normal",
2510 "timestamp": 0,
2511 "updaters": Array [
@@ -2685,7 +2685,7 @@ Object {
2685 ],
2686 ],
2687 "duration": 0,
2688 - "effectDuration": null,
2688 + "effectDuration": 0,
2689 "fiberActualDurations": Array [
2690 Array [
2691 1,
@@ -2714,7 +2714,7 @@ Object {
2714 0,
2715 ],
2716 ],
2717 - "passiveEffectDuration": null,
2717 + "passiveEffectDuration": 0,
2718 "priorityLevel": "Normal",
2719 "timestamp": 0,
2720 "updaters": Array [
packages/shared/ReactFeatureFlags.js
+2 -2
@@ -42,10 +42,10 @@ export const warnAboutDeprecatedLifecycles = true;
42 export const enableProfilerTimer = __PROFILE__;
43
44 // Record durations for commit and passive effects phases.
45 -export const enableProfilerCommitHooks = false;
45 +export const enableProfilerCommitHooks = __PROFILE__;
46
47 // Phase param passed to onRender callback differentiates between an "update" and a "cascading-update".
48 -export const enableProfilerNestedUpdatePhase = false;
48 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
49
50 // Profiler API accepts a function to be called when a nested update is scheduled.
51 // This callback accepts the component type (class instance or function) the update is scheduled for.
packages/shared/forks/ReactFeatureFlags.native-fb.js
+2 -2
@@ -14,8 +14,8 @@ import typeof * as ExportsType from './ReactFeatureFlags.native-fb';
14 export const enableDebugTracing = false;
15 export const enableSchedulingProfiler = false;
16 export const enableProfilerTimer = __PROFILE__;
17 -export const enableProfilerCommitHooks = false;
18 -export const enableProfilerNestedUpdatePhase = false;
17 +export const enableProfilerCommitHooks = __PROFILE__;
18 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
19 export const enableProfilerNestedUpdateScheduledHook = false;
20 export const enableUpdaterTracking = false;
21 export const enableSuspenseServerRenderer = false;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+2 -2
@@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
16 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = __DEV__;
17 export const warnAboutDeprecatedLifecycles = true;
18 export const enableProfilerTimer = __PROFILE__;
19 -export const enableProfilerCommitHooks = false;
20 -export const enableProfilerNestedUpdatePhase = false;
19 +export const enableProfilerCommitHooks = __PROFILE__;
20 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
21 export const enableProfilerNestedUpdateScheduledHook = false;
22 export const enableUpdaterTracking = false;
23 export const enableSuspenseServerRenderer = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+2 -2
@@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
16 export const warnAboutDeprecatedLifecycles = true;
17 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
18 export const enableProfilerTimer = __PROFILE__;
19 -export const enableProfilerCommitHooks = false;
20 -export const enableProfilerNestedUpdatePhase = false;
19 +export const enableProfilerCommitHooks = __PROFILE__;
20 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
21 export const enableProfilerNestedUpdateScheduledHook = false;
22 export const enableUpdaterTracking = false;
23 export const enableSuspenseServerRenderer = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.native.js
+2 -2
@@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
16 export const warnAboutDeprecatedLifecycles = true;
17 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
18 export const enableProfilerTimer = __PROFILE__;
19 -export const enableProfilerCommitHooks = false;
20 -export const enableProfilerNestedUpdatePhase = false;
19 +export const enableProfilerCommitHooks = __PROFILE__;
20 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
21 export const enableProfilerNestedUpdateScheduledHook = false;
22 export const enableUpdaterTracking = false;
23 export const enableSuspenseServerRenderer = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+2 -2
@@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
16 export const warnAboutDeprecatedLifecycles = true;
17 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
18 export const enableProfilerTimer = __PROFILE__;
19 -export const enableProfilerCommitHooks = false;
20 -export const enableProfilerNestedUpdatePhase = false;
19 +export const enableProfilerCommitHooks = __PROFILE__;
20 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
21 export const enableProfilerNestedUpdateScheduledHook = false;
22 export const enableUpdaterTracking = false;
23 export const enableSuspenseServerRenderer = false;
packages/shared/forks/ReactFeatureFlags.testing.js
+2 -2
@@ -16,8 +16,8 @@ export const enableSchedulingProfiler = false;
16 export const warnAboutDeprecatedLifecycles = true;
17 export const replayFailedUnitOfWorkWithInvokeGuardedCallback = false;
18 export const enableProfilerTimer = __PROFILE__;
19 -export const enableProfilerCommitHooks = false;
20 -export const enableProfilerNestedUpdatePhase = false;
19 +export const enableProfilerCommitHooks = __PROFILE__;
20 +export const enableProfilerNestedUpdatePhase = __PROFILE__;
21 export const enableProfilerNestedUpdateScheduledHook = false;
22 export const enableUpdaterTracking = false;
23 export const enableSuspenseServerRenderer = false;