@samitouri / QOS-React / commits / 6559b10b11

Use more widely supported emoji (#9139)

Dan Abramov committed Mar 9, 2017 at 00:55 UTC 6559b10b11e5d35f730778b8c87386fa982a1c6e
2 files changed +15 -15
src/renderers/shared/fiber/ReactDebugFiberPerf.js
+1 -1
@@ -40,7 +40,7 @@ if (__DEV__) {
40 // Prefix measurements so that it's possible to filter them.
41 // Longer prefixes are hard to read in DevTools.
42 const reactEmoji = '\u269B';
43 - const warningEmoji = '\uD83D\uDED1';
43 + const warningEmoji = '\u26D4';
44 const supportsUserTiming =
45 typeof performance !== 'undefined' &&
46 typeof performance.mark === 'function' &&
src/renderers/shared/fiber/__tests__/__snapshots__/ReactIncrementalPerf-test.js.snap
+14 -14
@@ -48,19 +48,19 @@ exports[`ReactDebugFiberPerf deduplicates lifecycle names during commit to reduc
48
49 // Because of deduplication, we don't know B was cascading,
50 // but we should still see the warning for the commit phase.
51 -🛑 (React Tree Reconciliation) Warning: There were cascading updates
51 +⛔ (React Tree Reconciliation) Warning: There were cascading updates
52 ⚛ Parent [update]
53 ⚛ A [update]
54 ⚛ B [update]
55 ⚛ A [update]
56 ⚛ B [update]
57 - 🛑 (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
57 + ⛔ (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
58 ⚛ (Committing Host Effects: 9 Total)
59 ⚛ (Calling Lifecycle Methods: 9 Total)
60 ⚛ A.componentDidUpdate
61 ⚛ B.componentDidUpdate
62 ⚛ B [update]
63 - 🛑 (Committing Changes) Warning: Caused by a cascading update in earlier commit
63 + ⛔ (Committing Changes) Warning: Caused by a cascading update in earlier commit
64 ⚛ (Committing Host Effects: 3 Total)
65 ⚛ (Calling Lifecycle Methods: 3 Total)
66 ⚛ B.componentDidUpdate
@@ -155,17 +155,17 @@ exports[`ReactDebugFiberPerf measures deprioritized work 1`] = `
155
156 exports[`ReactDebugFiberPerf recovers from caught errors 1`] = `
157 "// Stop on Baddie and restart from Boundary
158 -🛑 (React Tree Reconciliation) Warning: There were cascading updates
158 +⛔ (React Tree Reconciliation) Warning: There were cascading updates
159 ⚛ Parent [mount]
160 ⚛ Boundary [mount]
161 ⚛ Parent [mount]
162 ⚛ Baddie [mount]
163 - 🛑 (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
163 + ⛔ (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
164 ⚛ (Committing Host Effects: 2 Total)
165 ⚛ (Calling Lifecycle Methods: 1 Total)
166 ⚛ Boundary [update]
167 ⚛ ErrorReport [mount]
168 - 🛑 (Committing Changes) Warning: Caused by a cascading update in earlier commit
168 + ⛔ (Committing Changes) Warning: Caused by a cascading update in earlier commit
169 ⚛ (Committing Host Effects: 2 Total)
170 ⚛ (Calling Lifecycle Methods: 1 Total)
171 "
@@ -229,15 +229,15 @@ exports[`ReactDebugFiberPerf supports portals 1`] = `
229
230 exports[`ReactDebugFiberPerf warns on cascading renders from setState 1`] = `
231 "// Should print a warning
232 -🛑 (React Tree Reconciliation) Warning: There were cascading updates
232 +⛔ (React Tree Reconciliation) Warning: There were cascading updates
233 ⚛ Parent [mount]
234 ⚛ Cascading [mount]
235 - 🛑 (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
235 + ⛔ (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
236 ⚛ (Committing Host Effects: 2 Total)
237 ⚛ (Calling Lifecycle Methods: 1 Total)
238 - 🛑 Cascading.componentDidMount Warning: Scheduled a cascading update
238 + ⛔ Cascading.componentDidMount Warning: Scheduled a cascading update
239 ⚛ Cascading [update]
240 - 🛑 (Committing Changes) Warning: Caused by a cascading update in earlier commit
240 + ⛔ (Committing Changes) Warning: Caused by a cascading update in earlier commit
241 ⚛ (Committing Host Effects: 2 Total)
242 ⚛ (Calling Lifecycle Methods: 2 Total)
243 "
@@ -245,15 +245,15 @@ exports[`ReactDebugFiberPerf warns on cascading renders from setState 1`] = `
245
246 exports[`ReactDebugFiberPerf warns on cascading renders from top-level render 1`] = `
247 "// Rendering the first root
248 -🛑 (React Tree Reconciliation) Warning: There were cascading updates
248 +⛔ (React Tree Reconciliation) Warning: There were cascading updates
249 ⚛ Cascading [mount]
250 - 🛑 (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
250 + ⛔ (Committing Changes) Warning: Lifecycle hook scheduled a cascading update
251 ⚛ (Committing Host Effects: 1 Total)
252 ⚛ (Calling Lifecycle Methods: 1 Total)
253 - 🛑 Cascading.componentDidMount Warning: Scheduled a cascading update
253 + ⛔ Cascading.componentDidMount Warning: Scheduled a cascading update
254 // Scheduling another root from componentDidMount
255 ⚛ Child [mount]
256 - 🛑 (Committing Changes) Warning: Caused by a cascading update in earlier commit
256 + ⛔ (Committing Changes) Warning: Caused by a cascading update in earlier commit
257 ⚛ (Committing Host Effects: 1 Total)
258 ⚛ (Calling Lifecycle Methods: 0 Total)
259 "