Fixtures nits (#13375)
* fix: PropTypes failing in textarea fixtures * fix: Iframe title attribute in fixtures * Make description a optional prop in FixtureSet
Rauno Freiberg committed
Aug 13, 2018 at 17:08 UTC
714c78d5a16747d0f7f8179b66aacbd10ec9d3dd
10 files changed
+10
-9
fixtures/dom/src/components/FixtureSet.js
+1
-1
@@ -3,7 +3,7 @@ const React = window.React;
3
4
const propTypes = {
5
title: PropTypes.node.isRequired,
6
- description: PropTypes.node.isRequired,
6
+ description: PropTypes.node,
7
};
8
9
class FixtureSet extends React.Component {
fixtures/dom/src/components/Iframe.js
+1
@@ -32,6 +32,7 @@ class IframePortal extends React.Component {
32
return (
33
<div>
34
<iframe
35
+ title="Iframe portal"
36
style={{border: 'none', height: this.props.height}}
37
ref={this.handleRef}
38
/>
fixtures/dom/src/components/fixtures/buttons/index.js
+1
-1
@@ -10,7 +10,7 @@ function onButtonClick() {
10
export default class ButtonTestCases extends React.Component {
11
render() {
12
return (
13
- <FixtureSet title="Buttons" description="">
13
+ <FixtureSet title="Buttons">
14
<TestCase
15
title="onClick with disabled buttons"
16
description="The onClick event handler should not be invoked when clicking on a disabled buyaton">
fixtures/dom/src/components/fixtures/date-inputs/index.js
+1
-1
@@ -8,7 +8,7 @@ const React = window.React;
8
class DateInputFixtures extends React.Component {
9
render() {
10
return (
11
- <FixtureSet title="Dates" description="">
11
+ <FixtureSet title="Dates">
12
<TestCase title="Switching between date and datetime-local">
13
<TestCase.Steps>
14
<li>Type a date into the date picker</li>
fixtures/dom/src/components/fixtures/error-handling/index.js
+1
-1
@@ -87,7 +87,7 @@ class TriggerErrorAndCatch extends React.Component {
87
export default class ErrorHandlingTestCases extends React.Component {
88
render() {
89
return (
90
- <FixtureSet title="Error handling" description="">
90
+ <FixtureSet title="Error handling">
91
<TestCase
92
title="Break on uncaught exceptions"
93
description="In DEV, errors should be treated as uncaught, even though React catches them internally">
fixtures/dom/src/components/fixtures/event-pooling/index.js
+1
-1
@@ -7,7 +7,7 @@ const React = window.React;
7
class EventPooling extends React.Component {
8
render() {
9
return (
10
- <FixtureSet title="Event Pooling" description="">
10
+ <FixtureSet title="Event Pooling">
11
<MouseMove />
12
<Persistence />
13
</FixtureSet>
fixtures/dom/src/components/fixtures/media-events/index.js
+1
-1
@@ -60,7 +60,7 @@ export default class MediaEvents extends React.Component {
60
}, {});
61
62
return (
63
- <FixtureSet title="Media Events" description="">
63
+ <FixtureSet title="Media Events">
64
<TestCase
65
title="Event bubbling"
66
description="Media events should synthetically bubble">
fixtures/dom/src/components/fixtures/mouse-events/index.js
+1
-1
@@ -6,7 +6,7 @@ const React = window.React;
6
class MouseEvents extends React.Component {
7
render() {
8
return (
9
- <FixtureSet title="Mouse Events" description="">
9
+ <FixtureSet title="Mouse Events">
10
<MouseMovement />
11
</FixtureSet>
12
);
fixtures/dom/src/components/fixtures/password-inputs/index.js
+1
-1
@@ -6,7 +6,7 @@ const React = window.React;
6
7
function NumberInputs() {
8
return (
9
- <FixtureSet title="Password inputs" description="">
9
+ <FixtureSet title="Password inputs">
10
<TestCase
11
title="The show password icon"
12
description={`
fixtures/dom/src/components/fixtures/selects/index.js
+1
-1
@@ -46,7 +46,7 @@ class SelectFixture extends React.Component {
46
47
render() {
48
return (
49
- <FixtureSet title="Selects" description="">
49
+ <FixtureSet title="Selects">
50
<form className="field-group">
51
<fieldset>
52
<legend>Controlled</legend>