[flags] Remove enableModernStrictMode (#31838)
This is enabled everywhere.
Ricky committed
Dec 18, 2024 at 14:45 UTC
74dd2da9ac4bf82ff1232694e971879bb07f37dc
11 files changed
+22
-45
packages/react-reconciler/src/ReactFiberWorkLoop.js
+1
-2
@@ -32,7 +32,6 @@ import {
32
enableSchedulingProfiler,
33
enableUpdaterTracking,
34
enableTransitionTracing,
35
- useModernStrictMode,
35
disableLegacyContext,
36
alwaysThrottleRetries,
37
enableInfiniteRenderLoopDetection,
@@ -4205,7 +4204,7 @@ function commitDoubleInvokeEffectsInDEV(
4204
hasPassiveEffects: boolean,
4205
) {
4206
if (__DEV__) {
4208
- if (useModernStrictMode && (disableLegacyMode || root.tag !== LegacyRoot)) {
4207
+ if (disableLegacyMode || root.tag !== LegacyRoot) {
4208
let doubleInvokeEffects = true;
4209
4210
if (
packages/react-reconciler/src/__tests__/ActivityStrictMode-test.js
+1
-1
@@ -77,7 +77,7 @@ describe('Activity StrictMode', () => {
77
]);
78
});
79
80
- // @gate __DEV__ && enableActivity && useModernStrictMode
80
+ // @gate __DEV__ && enableActivity
81
it('should not trigger strict effects when offscreen is hidden', async () => {
82
await act(() => {
83
ReactNoop.render(
packages/react-reconciler/src/__tests__/StrictEffectsMode-test.js
+20
-29
@@ -945,34 +945,25 @@ describe('StrictEffectsMode', () => {
945
shouldSuspend = false;
946
});
947
948
- if (gate(flags => flags.useModernStrictMode)) {
949
- expect(log).toEqual([
950
- 'Child rendered',
951
- 'Child rendered',
952
- // !!! Committed, destroy and create effect.
953
- // !!! The other effect is not destroyed and created
954
- // !!! because the dep didn't change
955
- 'Child dep destroy',
956
- 'Child dep create',
957
-
958
- // Double invoke both effects
959
- 'Child destroy',
960
- 'Child dep destroy',
961
- 'Child create',
962
- 'Child dep create',
963
- // Fires setState
964
- '-----------------------after setState',
965
- 'Child rendered',
966
- 'Child rendered',
967
- 'Child dep create',
968
- ]);
969
- } else {
970
- expect(log).toEqual([
971
- 'Child rendered',
972
- 'Child rendered',
973
- 'Child dep destroy',
974
- 'Child dep create',
975
- ]);
976
- }
948
+ expect(log).toEqual([
949
+ 'Child rendered',
950
+ 'Child rendered',
951
+ // !!! Committed, destroy and create effect.
952
+ // !!! The other effect is not destroyed and created
953
+ // !!! because the dep didn't change
954
+ 'Child dep destroy',
955
+ 'Child dep create',
956
+
957
+ // Double invoke both effects
958
+ 'Child destroy',
959
+ 'Child dep destroy',
960
+ 'Child create',
961
+ 'Child dep create',
962
+ // Fires setState
963
+ '-----------------------after setState',
964
+ 'Child rendered',
965
+ 'Child rendered',
966
+ 'Child dep create',
967
+ ]);
968
});
969
});
packages/react-reconciler/src/__tests__/StrictEffectsModeDefaults-test.internal.js
-1
@@ -461,7 +461,6 @@ describe('StrictEffectsMode defaults', () => {
461
expect(log).toEqual([]);
462
});
463
464
- //@gate useModernStrictMode
464
it('disconnects refs during double invoking', async () => {
465
const onRefMock = jest.fn();
466
function App({text}) {
packages/shared/ReactFeatureFlags.js
-6
@@ -186,12 +186,6 @@ export const disableLegacyContext = true;
186
*/
187
export const disableLegacyContextForFunctionComponents = true;
188
189
-// Not ready to break experimental yet.
190
-// Modern <StrictMode /> behaviour aligns more with what components
191
-// components will encounter in production, especially when used With <Offscreen />.
192
-// TODO: clean up legacy <StrictMode /> once tests pass WWW.
193
-export const useModernStrictMode = true;
194
-
189
// Enable the moveBefore() alternative to insertBefore(). This preserves states of moves.
190
export const enableMoveBefore = false;
191
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -80,7 +80,6 @@ export const renameElementSymbol = false;
80
export const retryLaneExpirationMs = 5000;
81
export const syncLaneExpirationMs = 250;
82
export const transitionLaneExpirationMs = 5000;
83
-export const useModernStrictMode = true;
83
export const enableHydrationLaneScheduling = true;
84
export const enableYieldingBeforePassive = false;
85
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -70,7 +70,6 @@ export const renameElementSymbol = true;
70
export const retryLaneExpirationMs = 5000;
71
export const syncLaneExpirationMs = 250;
72
export const transitionLaneExpirationMs = 5000;
73
-export const useModernStrictMode = true;
73
export const enableSiblingPrerendering = true;
74
export const enableUseResourceEffectHook = false;
75
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -52,7 +52,6 @@ export const enableLegacyHidden = false;
52
53
export const enableTransitionTracing = false;
54
55
-export const useModernStrictMode = true;
55
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
56
export const enableFizzExternalRuntime = true;
57
export const enableDeferRootSchedulingToMicrotask = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -65,7 +65,6 @@ export const renameElementSymbol = false;
65
export const retryLaneExpirationMs = 5000;
66
export const syncLaneExpirationMs = 250;
67
export const transitionLaneExpirationMs = 5000;
68
-export const useModernStrictMode = true;
68
export const enableFabricCompleteRootInCommitPhase = false;
69
export const enableSiblingPrerendering = true;
70
export const enableUseResourceEffectHook = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -54,7 +54,6 @@ export const enableLegacyHidden = false;
54
55
export const enableTransitionTracing = false;
56
57
-export const useModernStrictMode = true;
57
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
58
export const enableFizzExternalRuntime = false;
59
export const enableDeferRootSchedulingToMicrotask = true;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -106,7 +106,6 @@ export const disableClientCache = true;
106
export const enableServerComponentLogs = true;
107
108
export const enableReactTestRendererWarning = false;
109
-export const useModernStrictMode = true;
109
110
export const disableLegacyMode = true;
111