@samitouri / QOS-React / commits / 75dd053b5e

[string-refs] make disableStringRefs a dynamic www flag (#31175)

Jan Kassens committed Oct 14, 2024 at 10:13 UTC 75dd053b5e83e8ae20e9f771bca7b95dba4ff881
2 files changed +2 -4
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
+1
@@ -18,6 +18,7 @@ export const disableDefaultPropsExceptForClasses = __VARIANT__;
18 export const disableLegacyContextForFunctionComponents = __VARIANT__;
19 export const disableLegacyMode = __VARIANT__;
20 export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
21 +export const disableStringRefs = __VARIANT__;
22 export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
23 export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
24 export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
+1 -4
@@ -19,6 +19,7 @@ export const {
19 disableDefaultPropsExceptForClasses,
20 disableLegacyContextForFunctionComponents,
21 disableSchedulerTimeoutInWorkLoop,
22 + disableStringRefs,
23 enableDebugTracing,
24 enableDeferRootSchedulingToMicrotask,
25 enableDO_NOT_USE_disableStrictPassiveEffect,
@@ -120,10 +121,6 @@ export const enableServerComponentLogs = true;
121 export const enableReactTestRendererWarning = false;
122 export const useModernStrictMode = true;
123
123 -// TODO: Roll out with GK. Don't keep as dynamic flag for too long, though,
124 -// because JSX is an extremely hot path.
125 -export const disableStringRefs = false;
126 -
124 export const disableLegacyMode: boolean =
125 __EXPERIMENTAL__ || dynamicFeatureFlags.disableLegacyMode;
126