Test for specific SSR warning (#10340)
* Test for specific SSR warning * Same in another place
Dan Abramov committed
Aug 1, 2017 at 14:38 UTC
78165276c7d9c7ef9a348d8ac279f6dd46509356
2 files changed
+26
-3
src/renderers/dom/shared/__tests__/ReactMount-test.js
+14
-3
@@ -153,13 +153,24 @@ describe('ReactMount', () => {
153
spyOn(console, 'error');
154
ReactDOM.render(<div />, container);
155
expectDev(console.error.calls.count()).toBe(1);
156
+ if (ReactDOMFeatureFlags.useFiber) {
157
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
158
+ 'Did not expect server HTML to contain the text node " " in <container>.',
159
+ );
160
+ } else {
161
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
162
+ 'Target node has markup rendered by React, but there are unrelated nodes as well.',
163
+ );
164
+ }
165
166
+ console.error.calls.reset();
167
ReactDOM.unmountComponentAtNode(container);
158
-
168
container.innerHTML = ' ' + ReactDOMServer.renderToString(<div />);
160
-
169
ReactDOM.render(<div />, container);
162
- expectDev(console.error.calls.count()).toBe(2);
170
+ expectDev(console.error.calls.count()).toBe(1);
171
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
172
+ 'Target node has markup rendered by React, but there are unrelated nodes as well.',
173
+ );
174
});
175
176
it('should not warn if mounting into non-empty node', () => {
src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
+12
@@ -312,6 +312,18 @@ describe('ReactDOMServer', () => {
312
instance = ReactDOM.render(<TestComponent name="y" />, element);
313
expect(mountCount).toEqual(4);
314
expectDev(console.error.calls.count()).toBe(1);
315
+ if (ReactDOMFeatureFlags.useFiber) {
316
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
317
+ 'Text content did not match. Server: "x" Client: "y"',
318
+ );
319
+ } else {
320
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
321
+ '(client) -- react-text: 3 -->y<!-- /react-text --',
322
+ );
323
+ expectDev(console.error.calls.argsFor(0)[0]).toContain(
324
+ '(server) -- react-text: 3 -->x<!-- /react-text --',
325
+ );
326
+ }
327
expect(element.innerHTML.length > 0).toBe(true);
328
expect(element.innerHTML).not.toEqual(lastMarkup);
329