@samitouri / QOS-React / commits / 79bcf6eb23

Fix missing trailing / in commit artifacts workflow

The trailing / was being omitted, so instead of moving the cjs directory itself, it would move only its contents instead. This broke some internal path assumptions. Additionally, updates the step to create the react-dom directory prior to moving. ghstack-source-id: b6eedb0c88cd3aa3a786a3d3d280ede5ee81a063 Pull Request resolved: https://github.com/facebook/react/pull/31026

Lauren Tan committed Sep 23, 2024 at 14:58 UTC 79bcf6eb23cd781bedbfccfe8d1507d18fd2c623
1 file changed +2 -2
.github/workflows/runtime_commit_artifacts.yml
+2 -2
@@ -118,14 +118,14 @@ jobs:
118 run: |
119 BASE_FOLDER='compiled-rn/facebook-fbsource/xplat/js'
120 mkdir -p ${BASE_FOLDER}/react-native-github/Libraries/Renderer/
121 - mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-is,react-test-renderer}/
121 + mkdir -p ${BASE_FOLDER}/RKJSModules/vendor/react/{scheduler,react,react-dom,react-is,react-test-renderer}/
122
123 # Move React Native renderer
124 mv build/react-native/implementations/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
125 mv build/react-native/shims/ $BASE_FOLDER/react-native-github/Libraries/Renderer/
126 mv build/facebook-react-native/scheduler/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/scheduler/
127 mv build/facebook-react-native/react/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react/
128 - mv build/facebook-react-native/react-dom/cjs $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
128 + mv build/facebook-react-native/react-dom/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-dom/
129 mv build/facebook-react-native/react-is/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-is/
130 mv build/facebook-react-native/react-test-renderer/cjs/ $BASE_FOLDER/RKJSModules/vendor/react/react-test-renderer/
131