@samitouri / QOS-React / commits / 7ac5e9a602

Small flowconfig fixes (#26784)

- The whole project root is included by default anyway, the include section should be redundant and just misleading. - The generated ignore paths ignore more than intended as they didn't escape the `.` for regex. Test Plan: - wait for CI - tested the ignore pattern change with renaming files and seeing the expected files ignored for flow

Jan Kassens committed May 8, 2023 at 12:07 UTC 7ac5e9a602347f3b7d26c60a549c483d3bc88bbf
2 files changed +1 -6
scripts/flow/config/flowconfig
-5
@@ -18,11 +18,6 @@
18
19 %REACT_RENDERER_FLOW_IGNORES%
20
21 -[include]
22 -./node_modules/
23 -./packages/
24 -./scripts/
25 -
21 [libs]
22 ./node_modules/fbjs/flow/lib/dev.js
23 ./scripts/flow/environment.js
scripts/flow/createFlowConfigs.js
+1 -1
@@ -37,7 +37,7 @@ function writeConfig(renderer, rendererInfo, isServerSupported) {
37
38 if (otherRenderer.shortName !== serverRenderer) {
39 ignoredPaths.push(
40 - `.*/packages/.*/forks/.*.${otherRenderer.shortName}.js`,
40 + `.*/packages/.*/forks/.*\\.${otherRenderer.shortName}.js`,
41 );
42 }
43 });