Call getDerivedStateFromProps even for setState of ShallowRenderer (#12676)
Toru Kobayashi committed
May 1, 2018 at 01:04 UTC
7dd4ca2911d742f9b5c457ce2d010432fa2d6578
2 files changed
+2
-3
packages/react-test-renderer/src/ReactShallowRenderer.js
+1
-2
@@ -186,9 +186,8 @@ class ReactShallowRenderer {
186
this._instance.UNSAFE_componentWillReceiveProps(props, context);
187
}
188
}
189
-
190
- this._updateStateFromStaticLifecycle(props);
189
}
190
+ this._updateStateFromStaticLifecycle(props);
191
192
// Read state after cWRP in case it calls setState
193
const state = this._newState || oldState;
packages/react-test-renderer/src/__tests__/ReactShallowRenderer-test.js
+1
-1
@@ -94,7 +94,7 @@ describe('ReactShallowRenderer', () => {
94
const instance = shallowRenderer.getMountedInstance();
95
instance.setState({});
96
97
- expect(logs).toEqual(['shouldComponentUpdate']);
97
+ expect(logs).toEqual(['getDerivedStateFromProps', 'shouldComponentUpdate']);
98
99
logs.splice(0);
100