Add missing traverseValue()
I don't think this one matters but just in case, we should always call traverseValue() when overriding visitValue().
Joe Savona committed
May 2, 2023 at 11:07 UTC
8292c65d8456fa75ab425c2e2754417780581cea
1 file changed
+2
-1
compiler/forget/src/ReactiveScopes/PromoteUsedTemporaries.ts
+2
-1
@@ -53,10 +53,11 @@ class Visitor extends ReactiveFunctionVisitor<VisitorState> {
53
type JsxExpressionTags = Set<IdentifierId>;
54
class CollectJsxTagsVisitor extends ReactiveFunctionVisitor<JsxExpressionTags> {
55
override visitValue(
56
- _id: InstructionId,
56
+ id: InstructionId,
57
value: ReactiveValue,
58
state: JsxExpressionTags
59
): void {
60
+ this.traverseValue(id, value, state);
61
if (value.kind === "JsxExpression" && value.tag.kind === "Identifier") {
62
state.add(value.tag.identifier.id);
63
}