Ship enableFabricCompleteRootInCommitPhase (#32318)
Jack Pope committed
Feb 7, 2025 at 11:12 UTC
8759c5c8d6aef34df576827215ff7ebaeafc79ea
9 files changed
+3
-23
packages/react-native-renderer/src/ReactFiberConfigFabric.js
+3
-11
@@ -57,10 +57,7 @@ import {
57
getInspectorDataForInstance,
58
} from './ReactNativeFiberInspector';
59
60
-import {
61
- enableFabricCompleteRootInCommitPhase,
62
- passChildrenWhenCloningPersistedNodes,
63
-} from 'shared/ReactFeatureFlags';
60
+import {passChildrenWhenCloningPersistedNodes} from 'shared/ReactFeatureFlags';
61
import {REACT_CONTEXT_TYPE} from 'shared/ReactSymbols';
62
import type {ReactContext} from 'shared/ReactTypes';
63
@@ -505,19 +502,14 @@ export function finalizeContainerChildren(
502
container: Container,
503
newChildren: ChildSet,
504
): void {
508
- if (!enableFabricCompleteRootInCommitPhase) {
509
- completeRoot(container.containerTag, newChildren);
510
- }
505
+ // Noop - children will be finalized in replaceContainerChildren
506
}
507
508
export function replaceContainerChildren(
509
container: Container,
510
newChildren: ChildSet,
511
): void {
517
- // Noop - children will be replaced in finalizeContainerChildren
518
- if (enableFabricCompleteRootInCommitPhase) {
519
- completeRoot(container.containerTag, newChildren);
520
- }
512
+ completeRoot(container.containerTag, newChildren);
513
}
514
515
export {getClosestInstanceFromNode as getInstanceFromNode};
packages/shared/ReactFeatureFlags.js
-5
@@ -92,11 +92,6 @@ export const enableHalt = __EXPERIMENTAL__;
92
93
export const enableViewTransition = __EXPERIMENTAL__;
94
95
-/**
96
- * Switches the Fabric API from doing layout in commit work instead of complete work.
97
- */
98
-export const enableFabricCompleteRootInCommitPhase = false;
99
-
95
/**
96
* Switches Fiber creation to a simple object instead of a constructor.
97
*/
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -23,7 +23,6 @@ export const enableHiddenSubtreeInsertionEffectCleanup = __VARIANT__;
23
export const enablePersistedModeClonedFlag = __VARIANT__;
24
export const enableShallowPropDiffing = __VARIANT__;
25
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
26
-export const enableFabricCompleteRootInCommitPhase = __VARIANT__;
26
export const enableSiblingPrerendering = __VARIANT__;
27
export const enableUseResourceEffectHook = __VARIANT__;
28
export const enableOwnerStacks = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -20,7 +20,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
20
// the exports object every time a flag is read.
21
export const {
22
alwaysThrottleRetries,
23
- enableFabricCompleteRootInCommitPhase,
23
enableHiddenSubtreeInsertionEffectCleanup,
24
enableObjectFiber,
25
enablePersistedModeClonedFlag,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -30,7 +30,6 @@ export const enableAsyncIterableChildren = false;
30
export const enableCPUSuspense = false;
31
export const enableCreateEventHandleAPI = false;
32
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
33
-export const enableFabricCompleteRootInCommitPhase = false;
33
export const enableMoveBefore = true;
34
export const enableFizzExternalRuntime = true;
35
export const enableHalt = false;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -36,7 +36,6 @@ export const enableUseEffectEventHook = false;
36
export const favorSafetyOverHydrationPerf = true;
37
export const enableLegacyFBSupport = false;
38
export const enableMoveBefore = false;
39
-export const enableFabricCompleteRootInCommitPhase = false;
39
export const enableHiddenSubtreeInsertionEffectCleanup = false;
40
export const enableHydrationLaneScheduling = true;
41
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -61,7 +61,6 @@ export const renameElementSymbol = false;
61
export const retryLaneExpirationMs = 5000;
62
export const syncLaneExpirationMs = 250;
63
export const transitionLaneExpirationMs = 5000;
64
-export const enableFabricCompleteRootInCommitPhase = false;
64
export const enableSiblingPrerendering = true;
65
export const enableUseResourceEffectHook = true;
66
export const enableHydrationLaneScheduling = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -39,7 +39,6 @@ export const favorSafetyOverHydrationPerf = true;
39
export const enableLegacyFBSupport = false;
40
export const enableMoveBefore = false;
41
export const enableRenderableContext = false;
42
-export const enableFabricCompleteRootInCommitPhase = false;
42
export const enableHiddenSubtreeInsertionEffectCleanup = true;
43
44
export const enableRetryLaneExpiration = false;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -48,7 +48,6 @@ export const enableProfilerTimer = __PROFILE__;
48
export const enableProfilerCommitHooks = __PROFILE__;
49
export const enableProfilerNestedUpdatePhase = __PROFILE__;
50
export const enableUpdaterTracking = __PROFILE__;
51
-export const enableFabricCompleteRootInCommitPhase = false;
51
52
export const enableSuspenseAvoidThisFallback = true;
53