@samitouri / QOS-React / commits / 89580f209c

Set renameElementSymbol to dynamic value (#30066)

Prepare to roll this out with dynamic flag `yarn flags --diff www canary` <img width="514" alt="Screenshot 2024-06-24 at 11 33 55 AM" src="https://github.com/facebook/react/assets/8965173/31508fdc-4cb1-4ce0-8e22-c02a034377b0">

Jack Pope committed Jun 24, 2024 at 12:28 UTC 89580f209ce68ae9e266e309dfeb1625b434fb58
3 files changed +3 -3
packages/react-dom/src/__tests__/ReactDOMOption-test.js
+1 -1
@@ -134,7 +134,7 @@ describe('ReactDOMOption', () => {
134 }).rejects.toThrow('Objects are not valid as a React child');
135 });
136
137 - // @gate www
137 + // @gate www && !renameElementSymbol
138 it('should support element-ish child', async () => {
139 // This is similar to <fbt>.
140 // We don't toString it because you must instead provide a value prop.
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
+1
@@ -32,6 +32,7 @@ export const syncLaneExpirationMs = 250;
32 export const transitionLaneExpirationMs = 5000;
33 export const enableAddPropertiesFastPath = __VARIANT__;
34 export const disableLegacyMode = __VARIANT__;
35 +export const renameElementSymbol = __VARIANT__;
36
37 // Enable this flag to help with concurrent mode debugging.
38 // It logs information to the console about React scheduling, rendering, and commit phases.
packages/shared/forks/ReactFeatureFlags.www.js
+1 -2
@@ -35,6 +35,7 @@ export const {
35 enableNoCloningMemoCache,
36 enableAddPropertiesFastPath,
37 enableFastJSX,
38 + renameElementSymbol,
39 } = dynamicFeatureFlags;
40
41 // On WWW, __EXPERIMENTAL__ is used for a new modern build.
@@ -65,8 +66,6 @@ export const enableSchedulingProfiler: boolean =
66 export const disableLegacyContext = __EXPERIMENTAL__;
67 export const enableGetInspectorDataForInstanceInProduction = false;
68
68 -export const renameElementSymbol = false;
69 -
69 export const enableCache = true;
70 export const enableLegacyCache = true;
71