[flags] enable owner stacks everywhere (#32376)
this is now canary and on everywhere
Ricky committed
Feb 18, 2025 at 10:29 UTC
8a7b487e3b171c91f2fe18e9142af53f4dd83454
9 files changed
+17
-14
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-2
@@ -25,7 +25,5 @@ export const enableShallowPropDiffing = __VARIANT__;
25
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
26
export const enableSiblingPrerendering = __VARIANT__;
27
export const enableUseEffectCRUDOverload = __VARIANT__;
28
-export const enableOwnerStacks = __VARIANT__;
29
-export const enableRemoveConsolePatches = __VARIANT__;
28
export const enableFastAddPropertiesInDiffing = __VARIANT__;
29
export const enableLazyPublicInstanceInFabric = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
+4
-2
@@ -27,12 +27,14 @@ export const {
27
enableUseEffectCRUDOverload,
28
passChildrenWhenCloningPersistedNodes,
29
enableSiblingPrerendering,
30
- enableOwnerStacks,
31
- enableRemoveConsolePatches,
30
enableFastAddPropertiesInDiffing,
31
enableLazyPublicInstanceInFabric,
32
} = dynamicFlags;
33
34
+// These two can be removed
35
+export const enableOwnerStacks = true;
36
+export const enableRemoveConsolePatches = true;
37
+
38
// The rest of the flags are static for better dead code elimination.
39
export const disableClientCache = true;
40
export const disableCommentsAsDOMContainers = true;
packages/shared/forks/ReactFeatureFlags.native-oss.js
+2
-2
@@ -40,7 +40,7 @@ export const enableLegacyFBSupport = false;
40
export const enableLegacyHidden = false;
41
export const enableNoCloningMemoCache = false;
42
export const enableObjectFiber = false;
43
-export const enableOwnerStacks = false;
43
+export const enableOwnerStacks = true;
44
export const enablePersistedModeClonedFlag = false;
45
export const enablePostpone = false;
46
export const enableReactTestRendererWarning = false;
@@ -80,7 +80,7 @@ export const enableProfilerTimer = __PROFILE__;
80
export const enableProfilerCommitHooks = __PROFILE__;
81
export const enableProfilerNestedUpdatePhase = __PROFILE__;
82
export const enableUpdaterTracking = __PROFILE__;
83
-export const enableRemoveConsolePatches = false;
83
+export const enableRemoveConsolePatches = true;
84
85
// Flow magic to verify the exports of this file match the original version.
86
((((null: any): ExportsType): FeatureFlagsType): ExportsType);
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
+2
-2
@@ -35,7 +35,7 @@ export const enableLegacyFBSupport = false;
35
export const enableLegacyHidden = false;
36
export const enableNoCloningMemoCache = false;
37
export const enableObjectFiber = false;
38
-export const enableOwnerStacks = false;
38
+export const enableOwnerStacks = true;
39
export const enablePersistedModeClonedFlag = false;
40
export const enablePostpone = false;
41
export const enableProfilerCommitHooks = __PROFILE__;
@@ -67,8 +67,8 @@ export const enableHydrationLaneScheduling = true;
67
export const enableYieldingBeforePassive = false;
68
export const enableThrottledScheduling = false;
69
export const enableViewTransition = false;
70
+export const enableRemoveConsolePatches = true;
71
export const enableSwipeTransition = false;
71
-export const enableRemoveConsolePatches = false;
72
export const enableFastAddPropertiesInDiffing = false;
73
export const enableLazyPublicInstanceInFabric = false;
74
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
+2
-2
@@ -70,7 +70,7 @@ export const disableDefaultPropsExceptForClasses = true;
70
export const renameElementSymbol = false;
71
72
export const enableObjectFiber = false;
73
-export const enableOwnerStacks = false;
73
+export const enableOwnerStacks = true;
74
export const enableShallowPropDiffing = false;
75
export const enableSiblingPrerendering = true;
76
@@ -82,8 +82,8 @@ export const enableYieldingBeforePassive = false;
82
83
export const enableThrottledScheduling = false;
84
export const enableViewTransition = false;
85
+export const enableRemoveConsolePatches = true;
86
export const enableSwipeTransition = false;
86
-export const enableRemoveConsolePatches = false;
87
export const enableFastAddPropertiesInDiffing = false;
88
export const enableLazyPublicInstanceInFabric = false;
89
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-2
@@ -26,7 +26,6 @@ export const enableRetryLaneExpiration = __VARIANT__;
26
export const enableTransitionTracing = __VARIANT__;
27
export const favorSafetyOverHydrationPerf = __VARIANT__;
28
export const renameElementSymbol = __VARIANT__;
29
-export const enableOwnerStacks = __VARIANT__;
29
export const retryLaneExpirationMs = 5000;
30
export const syncLaneExpirationMs = 250;
31
export const transitionLaneExpirationMs = 5000;
@@ -37,7 +36,6 @@ export const enableInfiniteRenderLoopDetection = __VARIANT__;
36
export const enableSiblingPrerendering = __VARIANT__;
37
38
export const enableUseEffectCRUDOverload = __VARIANT__;
40
-export const enableRemoveConsolePatches = __VARIANT__;
39
export const enableFastAddPropertiesInDiffing = __VARIANT__;
40
export const enableLazyPublicInstanceInFabric = false;
41
export const enableViewTransition = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
+4
-2
@@ -35,8 +35,6 @@ export const {
35
retryLaneExpirationMs,
36
syncLaneExpirationMs,
37
transitionLaneExpirationMs,
38
- enableOwnerStacks,
39
- enableRemoveConsolePatches,
38
enableFastAddPropertiesInDiffing,
39
enableViewTransition,
40
} = dynamicFeatureFlags;
@@ -44,6 +42,10 @@ export const {
42
// On WWW, __EXPERIMENTAL__ is used for a new modern build.
43
// It's not used anywhere in production yet.
44
45
+// Can remove these two
46
+export const enableOwnerStacks = true;
47
+export const enableRemoveConsolePatches = true;
48
+
49
export const enableProfilerTimer = __PROFILE__;
50
export const enableProfilerCommitHooks = __PROFILE__;
51
export const enableProfilerNestedUpdatePhase = __PROFILE__;
scripts/jest/setupTests.www.js
+1
@@ -11,6 +11,7 @@ jest.mock('shared/ReactFeatureFlags', () => {
11
// Flags that aren't currently used, but we still want to force variants to keep the
12
// code live.
13
actual.disableInputAttributeSyncing = __VARIANT__;
14
+ actual.enableOwnerStacks = __VARIANT__;
15
16
// These are hardcoded to true for the next release,
17
// but still run the tests against both variants until
scripts/jest/setupTests.xplat.js
+2
@@ -11,6 +11,8 @@ jest.mock('shared/ReactFeatureFlags', () => {
11
'shared/forks/ReactFeatureFlags.native-fb.js'
12
);
13
14
+ actual.enableOwnerStacks = __VARIANT__;
15
+
16
// Lots of tests use these, but we don't want to expose it to RN.
17
// Ideally, tests for xplat wouldn't use react-dom, but many of our tests do.
18
// Since the xplat tests run with the www entry points, some of these flags