Use clearer wording
Fixes #13604
Dan committed
Sep 9, 2018 at 16:54 UTC
8a8d973d3cc5623676a84f87af66ef9259c3937c
5 files changed
+10
-8
packages/react-dom/src/client/ReactDOMComponent.js
+3
-1
@@ -302,7 +302,9 @@ function setInitialDOMProperties(
302
// Noop
303
} else if (propKey === AUTOFOCUS) {
304
// We polyfill it separately on the client during commit.
305
- // We blacklist it here rather than in the property list because we emit it in SSR.
305
+ // We could have excluded it in the property list instead of
306
+ // adding a special case here, but then it wouldn't be emitted
307
+ // on server rendering (but we *do* want to emit it in SSR).
308
} else if (registrationNameModules.hasOwnProperty(propKey)) {
309
if (nextProp != null) {
310
if (__DEV__ && typeof nextProp !== 'function') {
packages/react-dom/src/events/BeforeInputEventPlugin.js
+1
-1
@@ -314,7 +314,7 @@ function getNativeBeforeInputChars(topLevelType: TopLevelType, nativeEvent) {
314
315
// If it's a spacebar character, assume that we have already handled
316
// it at the keypress level and bail immediately. Android Chrome
317
- // doesn't give us keycodes, so we need to blacklist it.
317
+ // doesn't give us keycodes, so we need to ignore it.
318
if (chars === SPACEBAR_CHAR && hasSpaceKeypress) {
319
return null;
320
}
scripts/jest/config.build.js
+1
-1
@@ -32,7 +32,7 @@ packages.forEach(name => {
32
module.exports = Object.assign({}, baseConfig, {
33
// Redirect imports to the compiled bundles
34
moduleNameMapper,
35
- // Don't run bundle tests on blacklisted -test.internal.* files
35
+ // Don't run bundle tests on -test.internal.* files
36
testPathIgnorePatterns: ['/node_modules/', '-test.internal.js$'],
37
// Exclude the build output from transforms
38
transformIgnorePatterns: ['/node_modules/', '<rootDir>/build/'],
scripts/rollup/build.js
+3
-3
@@ -250,9 +250,9 @@ function isProfilingBundleType(bundleType) {
250
}
251
}
252
253
-function blacklistFBJS() {
253
+function forbidFBJSImports() {
254
return {
255
- name: 'blacklistFBJS',
255
+ name: 'forbidFBJSImports',
256
resolveId(importee, importer) {
257
if (/^fbjs\//.test(importee)) {
258
throw new Error(
@@ -304,7 +304,7 @@ function getPlugins(
304
// Shim any modules that need forking in this environment.
305
useForks(forks),
306
// Ensure we don't try to bundle any fbjs modules.
307
- blacklistFBJS(),
307
+ forbidFBJSImports(),
308
// Use Node resolution mechanism.
309
resolve({
310
skip: externals,
scripts/rollup/forks.js
+2
-2
@@ -162,7 +162,7 @@ const forks = Object.freeze({
162
}
163
},
164
165
- // This logic is forked on www to blacklist warnings.
165
+ // This logic is forked on www to ignore some warnings.
166
'shared/lowPriorityWarning': (bundleType, entry) => {
167
switch (bundleType) {
168
case FB_WWW_DEV:
@@ -174,7 +174,7 @@ const forks = Object.freeze({
174
}
175
},
176
177
- // This logic is forked on www to blacklist warnings.
177
+ // This logic is forked on www to ignore some warnings.
178
'shared/warningWithoutStack': (bundleType, entry) => {
179
switch (bundleType) {
180
case FB_WWW_DEV: