Unfreeze the react-dom/server interface (#11531)
* Unfreeze the react-dom/server interface this allows stubbing of the exposed named functions, as was possible before v16.1 fixes #11526 * Fix missing version export * Fix missing version export * Whitespace
Matt Travi committed
Nov 13, 2017 at 07:52 UTC
901a091fe04ca5ad1fb9f825e9df39881a87debc
4 files changed
+20
-8
packages/react-dom/server.browser.js
+7
-1
@@ -9,4 +9,10 @@
9
10
'use strict';
11
12
-module.exports = require('./src/server/ReactDOMServerBrowser');
12
+var ReactDOMServer = require('./src/server/ReactDOMServerBrowser');
13
+
14
+// TODO: decide on the top-level export form.
15
+// This is hacky but makes it work with both Rollup and Jest
16
+module.exports = ReactDOMServer.default
17
+ ? ReactDOMServer.default
18
+ : ReactDOMServer;
packages/react-dom/server.node.js
+7
-1
@@ -9,4 +9,10 @@
9
10
'use strict';
11
12
-module.exports = require('./src/server/ReactDOMServerNode');
12
+var ReactDOMServer = require('./src/server/ReactDOMServerNode');
13
+
14
+// TODO: decide on the top-level export form.
15
+// This is hacky but makes it work with both Rollup and Jest
16
+module.exports = ReactDOMServer.default
17
+ ? ReactDOMServer.default
18
+ : ReactDOMServer;
packages/react-dom/src/server/ReactDOMServerBrowser.js
+3
-3
@@ -27,11 +27,11 @@ function renderToStaticNodeStream() {
27
);
28
}
29
30
-export {
30
+// Note: when changing this, also consider https://github.com/facebook/react/issues/11526
31
+export default {
32
renderToString,
33
renderToStaticMarkup,
34
renderToNodeStream,
35
renderToStaticNodeStream,
36
+ version: ReactVersion,
37
};
36
-
37
-export const version = ReactVersion;
packages/react-dom/src/server/ReactDOMServerNode.js
+3
-3
@@ -14,11 +14,11 @@ import {
14
renderToStaticNodeStream,
15
} from './ReactDOMNodeStreamRenderer';
16
17
-export {
17
+// Note: when changing this, also consider https://github.com/facebook/react/issues/11526
18
+export default {
19
renderToString,
20
renderToStaticMarkup,
21
renderToNodeStream,
22
renderToStaticNodeStream,
23
+ version: ReactVersion,
24
};
23
-
24
-export const version = ReactVersion;