Correctly check that element and props are frozen
This fixes an incorrect way of checking introduced in 95373ce769188aacd25c6485bc2c628ff02a856f (it had no effect).
Dan Abramov committed
May 26, 2016 at 01:08 UTC
919eba3c99b8fd697d508d36a6e4c13a079fe7e7
2 files changed
+16
-8
src/isomorphic/classic/element/__tests__/ReactElement-test.js
+12
-6
@@ -53,7 +53,8 @@ describe('ReactElement', function() {
53
expect(element.key).toBe(null);
54
expect(element.ref).toBe(null);
55
var expectation = {};
56
- Object.freeze(expectation);
56
+ expect(Object.isFrozen(element)).toBe(true);
57
+ expect(Object.isFrozen(element.props)).toBe(true);
58
expect(element.props).toEqual(expectation);
59
});
60
@@ -121,7 +122,8 @@ describe('ReactElement', function() {
122
expect(element.key).toBe(null);
123
expect(element.ref).toBe(null);
124
var expectation = {};
124
- Object.freeze(expectation);
125
+ expect(Object.isFrozen(element)).toBe(true);
126
+ expect(Object.isFrozen(element.props)).toBe(true);
127
expect(element.props).toEqual(expectation);
128
});
129
@@ -166,7 +168,8 @@ describe('ReactElement', function() {
168
expect(element.key).toBe('12');
169
expect(element.ref).toBe('34');
170
var expectation = {foo: '56'};
169
- Object.freeze(expectation);
171
+ expect(Object.isFrozen(element)).toBe(true);
172
+ expect(Object.isFrozen(element.props)).toBe(true);
173
expect(element.props).toEqual(expectation);
174
});
175
@@ -180,7 +183,8 @@ describe('ReactElement', function() {
183
expect(element.key).toBe('null');
184
expect(element.ref).toBe(null);
185
var expectation = {foo: '12'};
183
- Object.freeze(expectation);
186
+ expect(Object.isFrozen(element)).toBe(true);
187
+ expect(Object.isFrozen(element.props)).toBe(true);
188
expect(element.props).toEqual(expectation);
189
});
190
@@ -195,7 +199,8 @@ describe('ReactElement', function() {
199
expect(element.key).toBe(null);
200
expect(element.ref).toBe(null);
201
var expectation = {foo: '56'};
198
- Object.freeze(expectation);
202
+ expect(Object.isFrozen(element)).toBe(true);
203
+ expect(Object.isFrozen(element.props)).toBe(true);
204
expect(element.props).toEqual(expectation);
205
});
206
@@ -215,7 +220,8 @@ describe('ReactElement', function() {
220
expect(element.key).toBe('12');
221
expect(element.ref).toBe(null);
222
var expectation = {foo: '56'};
218
- Object.freeze(expectation);
223
+ expect(Object.isFrozen(element)).toBe(true);
224
+ expect(Object.isFrozen(element.props)).toBe(true);
225
expect(element.props).toEqual(expectation);
226
});
227
src/isomorphic/classic/element/__tests__/ReactElementClone-test.js
+4
-2
@@ -345,7 +345,8 @@ describe('ReactElementClone', function() {
345
expect(clone.key).toBe('12');
346
expect(clone.ref).toBe('34');
347
var expectation = {foo: 'ef'};
348
- Object.freeze(expectation);
348
+ expect(Object.isFrozen(element)).toBe(true);
349
+ expect(Object.isFrozen(element.props)).toBe(true);
350
expect(clone.props).toEqual(expectation);
351
});
352
@@ -365,7 +366,8 @@ describe('ReactElementClone', function() {
366
expect(clone.key).toBe('null');
367
expect(clone.ref).toBe(null);
368
var expectation = {foo: 'ef'};
368
- Object.freeze(expectation);
369
+ expect(Object.isFrozen(element)).toBe(true);
370
+ expect(Object.isFrozen(element.props)).toBe(true);
371
expect(clone.props).toEqual(expectation);
372
});
373