@samitouri / QOS-React / commits / 94e652d505

disable `enableSiblingPrerendering` in experimental channel (#30952)

Disables `enableSiblingPrerendering` in the experimental builds until the feature is tested at Meta first.

Josh Story committed Sep 12, 2024 at 09:33 UTC 94e652d505cc2a3ed77de06c0f8e5f4909761d97
3 files changed +6 -6
packages/react-devtools-shared/src/__tests__/TimelineProfiler-test.js
+4 -4
@@ -21,10 +21,10 @@ import semver from 'semver';
21 // TODO: This is how other DevTools tests access the version but we should find
22 // a better solution for this
23 const ReactVersionTestingAgainst = process.env.REACT_VERSION || ReactVersion;
24 -const enableSiblingPrerendering = semver.gte(
25 - ReactVersionTestingAgainst,
26 - '19.0.0',
27 -);
24 +// Disabling this while the flag is off in experimental. Leaving the logic so we can
25 +// restore the behavior when we turn the flag back on.
26 +const enableSiblingPrerendering =
27 + false && semver.gte(ReactVersionTestingAgainst, '19.0.0');
28
29 describe('Timeline profiler', () => {
30 let React;
packages/shared/ReactFeatureFlags.js
+1 -1
@@ -148,7 +148,7 @@ export const enableOwnerStacks = __EXPERIMENTAL__;
148
149 export const enableShallowPropDiffing = false;
150
151 -export const enableSiblingPrerendering = __EXPERIMENTAL__;
151 +export const enableSiblingPrerendering = false;
152
153 /**
154 * Enables an expiration time for retry lanes to avoid starvation.
packages/shared/forks/ReactFeatureFlags.test-renderer.js
+1 -1
@@ -80,7 +80,7 @@ export const enableAddPropertiesFastPath = false;
80
81 export const renameElementSymbol = true;
82 export const enableShallowPropDiffing = false;
83 -export const enableSiblingPrerendering = __EXPERIMENTAL__;
83 +export const enableSiblingPrerendering = false;
84
85 // TODO: This must be in sync with the main ReactFeatureFlags file because
86 // the Test Renderer's value must be the same as the one used by the