Update fuzz tester to not use animation priority
Neglected to fix this earlier because these tests were ignored.
Andrew Clark committed
Jun 19, 2017 at 13:47 UTC
9749a6ea6a7215507e2ff70627fe31ae31fbf0a2
1 file changed
+37
-36
src/renderers/shared/fiber/__tests__/ReactIncrementalTriangle-test.js
+37
-36
@@ -19,7 +19,7 @@ describe('ReactIncrementalTriangle', () => {
19
beforeEach(() => {
20
jest.resetModules();
21
React = require('react');
22
- ReactNoop = require('ReactNoop');
22
+ ReactNoop = require('ReactNoopEntry');
23
24
ReactFeatureFlags = require('ReactFeatureFlags');
25
ReactFeatureFlags.disableNewFiberFeatures = false;
@@ -79,7 +79,7 @@ describe('ReactIncrementalTriangle', () => {
79
if (this.props.depth !== 0) {
80
throw new Error('Cannot activate non-leaf component');
81
}
82
- ReactNoop.performAnimationWork(() => {
82
+ ReactNoop.syncUpdates(() => {
83
this.setState({isActive: true});
84
});
85
}
@@ -87,7 +87,7 @@ describe('ReactIncrementalTriangle', () => {
87
if (this.props.depth !== 0) {
88
throw new Error('Cannot deactivate non-leaf component');
89
}
90
- ReactNoop.performAnimationWork(() => {
90
+ ReactNoop.syncUpdates(() => {
91
this.setState({isActive: false});
92
});
93
}
@@ -121,7 +121,7 @@ describe('ReactIncrementalTriangle', () => {
121
state = {counter: 0};
122
interrupt() {
123
// Triggers a restart from the top.
124
- ReactNoop.performAnimationWork(() => {
124
+ ReactNoop.syncUpdates(() => {
125
this.forceUpdate();
126
});
127
}
@@ -192,40 +192,41 @@ describe('ReactIncrementalTriangle', () => {
192
let expectedCounterAtEnd = app.state.counter;
193
194
let activeTriangle = null;
195
- for (let i = 0; i < actions.length; i++) {
196
- const action = actions[i];
197
- switch (action.type) {
198
- case FLUSH:
199
- ReactNoop.flushUnitsOfWork(action.unitsOfWork);
200
- break;
201
- case STEP:
202
- app.setCounter(action.counter);
203
- expectedCounterAtEnd = action.counter;
204
- break;
205
- case INTERRUPT:
206
- app.interrupt();
207
- break;
208
- case TOGGLE:
209
- const targetTriangle = leafTriangles[action.childIndex];
210
- if (targetTriangle === undefined) {
211
- throw new Error('Target index is out of bounds');
212
- }
213
- if (targetTriangle === activeTriangle) {
214
- activeTriangle = null;
215
- targetTriangle.deactivate();
216
- } else {
217
- if (activeTriangle !== null) {
218
- activeTriangle.deactivate();
195
+ ReactNoop.batchedUpdates(() => {
196
+ for (let i = 0; i < actions.length; i++) {
197
+ const action = actions[i];
198
+ switch (action.type) {
199
+ case FLUSH:
200
+ ReactNoop.flushUnitsOfWork(action.unitsOfWork);
201
+ break;
202
+ case STEP:
203
+ app.setCounter(action.counter);
204
+ expectedCounterAtEnd = action.counter;
205
+ break;
206
+ case INTERRUPT:
207
+ app.interrupt();
208
+ break;
209
+ case TOGGLE:
210
+ const targetTriangle = leafTriangles[action.childIndex];
211
+ if (targetTriangle === undefined) {
212
+ throw new Error('Target index is out of bounds');
213
}
220
- activeTriangle = targetTriangle;
221
- targetTriangle.activate();
222
- }
223
- ReactNoop.flushAnimationPri();
224
- break;
225
- default:
226
- break;
214
+ if (targetTriangle === activeTriangle) {
215
+ activeTriangle = null;
216
+ targetTriangle.deactivate();
217
+ } else {
218
+ if (activeTriangle !== null) {
219
+ activeTriangle.deactivate();
220
+ }
221
+ activeTriangle = targetTriangle;
222
+ targetTriangle.activate();
223
+ }
224
+ break;
225
+ default:
226
+ break;
227
+ }
228
}
228
- }
229
+ });
230
// Flush remaining work
231
ReactNoop.flush();
232
assertConsistentTree(activeTriangle, expectedCounterAtEnd);