@samitouri / QOS-React / commits / 9f24e8c7a2

Renamed overrideHook -> overrideHookState (to stay in sync with React PR)

Brian Vaughn committed Feb 23, 2019 at 09:12 UTC 9f24e8c7a2ca286bfbd5e065745c5726701b320c
4 files changed +8 -8
src/backend/agent.js
+2 -2
@@ -48,7 +48,7 @@ export default class Agent extends EventEmitter {
48 bridge.addListener('highlightElementInDOM', this.highlightElementInDOM);
49 bridge.addListener('inspectElement', this.inspectElement);
50 bridge.addListener('overrideContext', this.overrideContext);
51 - bridge.addListener('overrideHook', this.overrideHook);
51 + bridge.addListener('overrideHookState', this.overrideHookState);
52 bridge.addListener('overrideProps', this.overrideProps);
53 bridge.addListener('overrideState', this.overrideState);
54 bridge.addListener('selectElement', this.selectElement);
@@ -132,7 +132,7 @@ export default class Agent extends EventEmitter {
132 }
133 };
134
135 - overrideHook = ({
135 + overrideHookState = ({
136 id,
137 index,
138 path,
src/backend/renderer.js
+4 -4
@@ -194,7 +194,7 @@ export function attach(
194 DEPRECATED_PLACEHOLDER_SYMBOL_STRING,
195 } = ReactSymbols;
196
197 - const { overrideHook, overrideProps } = renderer;
197 + const { overrideHookState, overrideProps } = renderer;
198
199 const debug = (name: string, fiber: Fiber, parentFiber: ?Fiber): void => {
200 if (__DEBUG__) {
@@ -1180,7 +1180,7 @@ export function attach(
1180 id,
1181
1182 // Does the current renderer support editable hooks?
1183 - canEditHooks: typeof overrideHook === 'function',
1183 + canEditHooks: typeof overrideHookState === 'function',
1184
1185 // Does the current renderer support editable function props?
1186 canEditFunctionProps: typeof overrideProps === 'function',
@@ -1215,8 +1215,8 @@ export function attach(
1215 ) {
1216 const fiber = findCurrentFiberUsingSlowPath(idToFiberMap.get(id));
1217 if (fiber !== null) {
1218 - if (typeof overrideHook === 'function') {
1219 - overrideHook(fiber, index, path, value);
1218 + if (typeof overrideHookState === 'function') {
1219 + overrideHookState(fiber, index, path, value);
1220 }
1221 }
1222 }
src/backend/types.js
+1 -1
@@ -35,7 +35,7 @@ export type ReactRenderer = {
35 bundleType: BundleType,
36
37 // 16.9+
38 - overrideHook?: ?(
38 + overrideHookState?: ?(
39 fiber: Object,
40 index: number,
41 path: Array<string | number>,
src/devtools/views/HooksTree.js
+1 -1
@@ -144,7 +144,7 @@ function HookView({ canEditHooks, hook, id, path = [] }: HookViewProps) {
144 if (canEditHooks && isEditable) {
145 overrideValueFn = (path: Array<string | number>, value: any) => {
146 const rendererID = store.getRendererIDForElement(id);
147 - bridge.send('overrideHook', {
147 + bridge.send('overrideHookState', {
148 id,
149 index,
150 path,