@samitouri / QOS-React / commits / a489e3f057

Disable one irrelevant test for Fiber

We don't use transaction objects.

Sebastian Markbage committed Nov 20, 2016 at 20:51 UTC a489e3f057a4d5e04e282132f5f168682bd9c654
3 files changed +6 -1
scripts/fiber/tests-failing.txt
-1
@@ -132,7 +132,6 @@ src/renderers/shared/stack/reconciler/__tests__/ReactStatelessComponent-test.js
132 * should warn when using non-React functions in JSX
133
134 src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js
135 -* should share reconcile transaction across different roots
135 * should queue mount-ready handlers across different roots
136 * should queue updates from during mount
137 * marks top-level updates
scripts/fiber/tests-passing.txt
+1
@@ -1431,6 +1431,7 @@ src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js
1431 * should update children even if parent blocks updates
1432 * should not reconcile children passed via props
1433 * should flow updates correctly
1434 +* should share reconcile transaction across different roots
1435 * should flush updates in the correct order
1436 * should flush updates in the correct order across roots
1437 * should queue nested updates
src/renderers/shared/stack/reconciler/__tests__/ReactUpdates-test.js
+5
@@ -13,6 +13,7 @@
13
14 var React;
15 var ReactDOM;
16 +var ReactDOMFeatureFlags;
17 var ReactTestUtils;
18 var ReactUpdates;
19
@@ -20,6 +21,7 @@ describe('ReactUpdates', () => {
21 beforeEach(() => {
22 React = require('React');
23 ReactDOM = require('ReactDOM');
24 + ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
25 ReactTestUtils = require('ReactTestUtils');
26 ReactUpdates = require('ReactUpdates');
27 });
@@ -506,6 +508,9 @@ describe('ReactUpdates', () => {
508 });
509
510 it('should share reconcile transaction across different roots', () => {
511 + if (ReactDOMFeatureFlags.useFiber) {
512 + return;
513 + }
514 var ReconcileTransaction = ReactUpdates.ReactReconcileTransaction;
515 spyOn(ReconcileTransaction, 'getPooled').and.callThrough();
516