Remove tests in ReactDOMComponent-test depending on internal API (#11337)
* Remove inputValueTracking from ReactDOMComponent-test dependency * prettier * use node._valueTracker and add some test cases to make sure that value being tracked * using Object.getOwnPropertyDescriptor to get the tracked value * move getValueTracker to each test case and use its corresponding prototype * remove tests and move the value tracker definition before React is imported * Delete these tests completely
Audy Tanudjaja committed
Nov 10, 2017 at 19:01 UTC
ae7639c1165a6321c94c7c7203224c1eeeabb484
1 file changed
-24
packages/react-dom/src/__tests__/ReactDOMComponent-test.js
-24
@@ -14,7 +14,6 @@ describe('ReactDOMComponent', () => {
14
var ReactTestUtils;
15
var ReactDOM;
16
var ReactDOMServer;
17
- var inputValueTracking;
17
18
function normalizeCodeLocInfo(str) {
19
return str && str.replace(/\(at .+?:\d+\)/g, '(at **)');
@@ -26,8 +25,6 @@ describe('ReactDOMComponent', () => {
25
ReactDOM = require('react-dom');
26
ReactDOMServer = require('react-dom/server');
27
ReactTestUtils = require('react-dom/test-utils');
29
- // TODO: can we express this test with only public API?
30
- inputValueTracking = require('../client/inputValueTracking');
28
});
29
30
describe('updateDOM', () => {
@@ -1174,27 +1171,6 @@ describe('ReactDOMComponent', () => {
1171
);
1172
});
1173
1177
- it('should track input values', () => {
1178
- var container = document.createElement('div');
1179
- var inst = ReactDOM.render(
1180
- <input type="text" defaultValue="foo" />,
1181
- container,
1182
- );
1183
-
1184
- var tracker = inputValueTracking._getTrackerFromNode(inst);
1185
-
1186
- expect(tracker.getValue()).toEqual('foo');
1187
- });
1188
-
1189
- it('should track textarea values', () => {
1190
- var container = document.createElement('div');
1191
- var inst = ReactDOM.render(<textarea defaultValue="foo" />, container);
1192
-
1193
- var tracker = inputValueTracking._getTrackerFromNode(inst);
1194
-
1195
- expect(tracker.getValue()).toEqual('foo');
1196
- });
1197
-
1174
it('should throw for children on void elements', () => {
1175
class X extends React.Component {
1176
render() {