@samitouri / QOS-React / commits / b779dd51e8

Stop syncing ReactTypes to RN (#18366)

This is a really old one and all callers have since been codemodded away anyway because of problems. This file is not really as rigorously maintained as the official Flow types but has a few more specifics. However, the inconsistency causes problems when you try to pass files typed using the built-in Flow typing for React and mix it with these. We just happen to get away with it because we compile out the types. If we didn't we would hit those problems by even using these in our renderers.

Sebastian Markbåge committed Mar 21, 2020 at 15:22 UTC b779dd51e87b92e13001b5deac4887bb4984ecf2
1 file changed -2
scripts/rollup/packaging.js
-2
@@ -87,11 +87,9 @@ async function copyWWWShims() {
87 }
88
89 async function copyRNShims() {
90 - const reactTypesBuildTarget = 'build/react-native/shims/ReactTypes.js';
90 await Promise.all([
91 // React Native
92 asyncCopyTo(`${__dirname}/shims/react-native`, 'build/react-native/shims'),
94 - asyncCopyTo(require.resolve('shared/ReactTypes.js'), reactTypesBuildTarget),
93 asyncCopyTo(
94 require.resolve('react-native-renderer/src/ReactNativeTypes.js'),
95 'build/react-native/shims/ReactNativeTypes.js'