@samitouri / QOS-React / commits / ba72c99183

Report version and bundle type to DevTools (#9586)

* Report version and bundle type to DevTools * Flip the flag the other way around It's easier to remember 0 is always PROD, and 1 is like DEV flag. 2 could be PROFILE in the future. * Add version to RN inject call

Dan Abramov committed May 2, 2017 at 20:34 UTC ba72c9918339ddfdee6f165fec1ba748fce5241d

2 files changed +8

src/renderers/dom/fiber/ReactDOMFiber.js

@@ -28,6 +28,7 @@ var ReactFiberReconciler = require('ReactFiberReconciler');

28 var ReactInputSelection = require('ReactInputSelection');

29 var ReactInstanceMap = require('ReactInstanceMap');

30 var ReactPortal = require('ReactPortal');

31 +var ReactVersion = require('ReactVersion');

32 var {isValidElement} = require('react');

33 var {injectInternals} = require('ReactFiberDevToolsHook');

34 var {

@@ -556,6 +557,9 @@ if (typeof injectInternals === 'function') {

557 injectInternals({

558 findFiberByHostInstance: ReactDOMComponentTree.getClosestInstanceFromNode,

559 findHostInstanceByFiber: DOMRenderer.findHostInstance,

560 + // This is an enum because we may add more (e.g. profiler build)

561 + bundleType: __DEV__ ? 1 : 0,

562 + version: ReactVersion,

563 });

564 }

565

src/renderers/native/ReactNativeFiber.js

@@ -23,6 +23,7 @@ const ReactNativeInjection = require('ReactNativeInjection');

23 const ReactNativeTagHandles = require('ReactNativeTagHandles');

24 const ReactNativeViewConfigRegistry = require('ReactNativeViewConfigRegistry');

25 const ReactPortal = require('ReactPortal');

26 +const ReactVersion = require('ReactVersion');

27 const UIManager = require('UIManager');

29 const deepFreezeAndThrowOnMutationInDev = require('deepFreezeAndThrowOnMutationInDev');

@@ -464,6 +465,9 @@ if (typeof injectInternals === 'function') {

465 injectInternals({

466 findFiberByHostInstance: ReactNativeComponentTree.getClosestInstanceFromNode,

467 findHostInstanceByFiber: NativeRenderer.findHostInstance,

468 + // This is an enum because we may add more (e.g. profiler build)

469 + bundleType: __DEV__ ? 1 : 0,

470 + version: ReactVersion,

471 });

472 }

473