Fix redundant null type coercion (#9114)
Vincent Taing committed
Mar 6, 2017 at 15:20 UTC
bb149c817083d3b2d6473c2e8f4f89b14886b790
1 file changed
+6
-6
src/renderers/shared/stack/reconciler/ReactUpdateQueue.js
+6
-6
@@ -134,8 +134,8 @@ var ReactUpdateQueue = {
134
return;
135
}
136
137
- if (callback) {
138
- callback = callback === undefined ? null : callback;
137
+ callback = callback === undefined ? null : callback;
138
+ if (callback !== null) {
139
if (__DEV__) {
140
warnOnInvalidCallback(callback, callerName);
141
}
@@ -174,8 +174,8 @@ var ReactUpdateQueue = {
174
internalInstance._pendingStateQueue = [completeState];
175
internalInstance._pendingReplaceState = true;
176
177
- if (callback) {
178
- callback = callback === undefined ? null : callback;
177
+ callback = callback === undefined ? null : callback;
178
+ if (callback !== null) {
179
if (__DEV__) {
180
warnOnInvalidCallback(callback, callerName);
181
}
@@ -222,8 +222,8 @@ var ReactUpdateQueue = {
222
(internalInstance._pendingStateQueue = []);
223
queue.push(partialState);
224
225
- if (callback) {
226
- callback = callback === undefined ? null : callback;
225
+ callback = callback === undefined ? null : callback;
226
+ if (callback !== null) {
227
if (__DEV__) {
228
warnOnInvalidCallback(callback, callerName);
229
}