Add Flow reminder to PR template (#8805)
* Added flow to PR template * Added record-tests step to PR template and contribution docs * Updated order of PR checks
Jack Cross committed
Jan 17, 2017 at 09:34 UTC
bfd5b1878e6eeebd8899bd221cb62ddc046c875d
2 files changed
+8
-5
.github/PULL_REQUEST_TEMPLATE.md
+6
-4
@@ -1,8 +1,10 @@
1
-*Before* submitting a pull request, please make sure the following is done...
1
+**Before submitting a pull request,** please make sure the following is done:
2
3
-1. Fork the repo and create your branch from `master`.
3
+1. Fork [the repository](https://github.com/facebook/react) and create your branch from `master`.
4
2. If you've added code that should be tested, add tests!
5
3. If you've changed APIs, update the documentation.
6
4. Ensure the test suite passes (`npm test`).
7
-5. Make sure your code lints (`npm run lint`) - we've done our best to make sure these rules match our internal linting guidelines.
8
-6. If you haven't already, complete the [CLA](https://code.facebook.com/cla).
7
+5. Make sure your code lints (`npm run lint`).
8
+6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
9
+7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
10
+8. If you haven't already, complete the [CLA](https://code.facebook.com/cla).
docs/contributing/how-to-contribute.md
+2
-1
@@ -82,7 +82,8 @@ The core team is monitoring for pull requests. We will review your pull request
82
4. Ensure the test suite passes (`npm test`).
83
5. Make sure your code lints (`npm run lint`).
84
6. Run the [Flow](https://flowtype.org/) typechecks (`npm run flow`).
85
-7. If you haven't already, complete the CLA.
85
+7. If you added or removed any tests, run `./scripts/fiber/record-tests` before submitting the pull request, and commit the resulting changes.
86
+8. If you haven't already, complete the CLA.
87
88
### Contributor License Agreement (CLA)
89