Node scripts should fail if not NODE_ENV specified
Brian Vaughn committed
Apr 18, 2019 at 18:13 UTC
c0b414d58140f2dda765ef114d981a967992026b
4 files changed
+20
-3
package.json
+1
-1
@@ -47,7 +47,7 @@
47
"precommit": "lint-staged",
48
"prettier": "prettier --write '**/*.{js,json,css}'",
49
"prettier:ci": "prettier --check '**/*.{js,json,css}'",
50
- "start": "cd ./shells/dev && opener ./index.html && webpack --config webpack.config.js --watch",
50
+ "start": "cd ./shells/dev && opener ./index.html && cross-env NODE_ENV=development webpack --config webpack.config.js --watch",
51
"start:prod": "cross-env NODE_ENV=production npm start",
52
"test": "jest",
53
"test-debug": "node --inspect-brk node_modules/.bin/jest --runInBand",
shells/browser/shared/webpack.backend.js
+7
-1
@@ -3,7 +3,13 @@ const { resolve } = require('path');
3
const { DefinePlugin } = require('webpack');
4
const { getGitHubURL, getVersionString } = require('../../utils');
5
6
-const __DEV__ = process.env.NODE_ENV === 'development';
6
+const NODE_ENV = process.env.NODE_ENV;
7
+if (!NODE_ENV) {
8
+ console.error('NODE_ENV not set');
9
+ process.exit(1);
10
+}
11
+
12
+const __DEV__ = NODE_ENV === 'development';
13
14
const GITHUB_URL = getGitHubURL();
15
const DEVTOOLS_VERSION = getVersionString();
shells/browser/shared/webpack.config.js
+5
@@ -4,6 +4,11 @@ const { DefinePlugin } = require('webpack');
4
const { getGitHubURL, getVersionString } = require('../../utils');
5
6
const NODE_ENV = process.env.NODE_ENV;
7
+if (!NODE_ENV) {
8
+ console.error('NODE_ENV not set');
9
+ process.exit(1);
10
+}
11
+
12
const __DEV__ = NODE_ENV === 'development';
13
14
const GITHUB_URL = getGitHubURL();
shells/dev/webpack.config.js
+7
-1
@@ -3,7 +3,13 @@ const { resolve } = require('path');
3
const { DefinePlugin } = require('webpack');
4
const { getGitHubURL, getVersionString } = require('../utils');
5
6
-const __DEV__ = process.env.NODE_ENV === 'development';
6
+const NODE_ENV = process.env.NODE_ENV;
7
+if (!NODE_ENV) {
8
+ console.error('NODE_ENV not set');
9
+ process.exit(1);
10
+}
11
+
12
+const __DEV__ = NODE_ENV === 'development';
13
14
const GITHUB_URL = getGitHubURL();
15
const DEVTOOLS_VERSION = getVersionString();