@samitouri / QOS-React / commits / cc77be957e

Remove unnecessary error overriding in (#19949)

Paul Doyle committed Oct 2, 2020 at 14:10 UTC cc77be957e502ca6b855f1600d7fd11748dceb18
1 file changed -18
packages/shared/__tests__/ReactErrorProd-test.internal.js
-18
@@ -11,29 +11,11 @@
11 let formatProdErrorMessage;
12
13 describe('ReactErrorProd', () => {
14 - let globalErrorMock;
15 -
14 beforeEach(() => {
17 - if (!__DEV__) {
18 - // In production, our Jest environment overrides the global Error
19 - // class in order to decode error messages automatically. However
20 - // this is a single test where we actually *don't* want to decode
21 - // them. So we assert that the OriginalError exists, and temporarily
22 - // set the global Error object back to it.
23 - globalErrorMock = global.Error;
24 - global.Error = globalErrorMock.OriginalError;
25 - expect(typeof global.Error).toBe('function');
26 - }
15 jest.resetModules();
16 formatProdErrorMessage = require('shared/formatProdErrorMessage').default;
17 });
18
31 - afterEach(() => {
32 - if (!__DEV__) {
33 - global.Error = globalErrorMock;
34 - }
35 - });
36 -
19 it('should throw with the correct number of `%s`s in the URL', () => {
20 expect(formatProdErrorMessage(124, 'foo', 'bar')).toEqual(
21 'Minified React error #124; visit ' +