Set enableFastJSX flag to true (#30343)
When these to diffs are landed, we can merge this - [x] D59772879 - [x] D59773043
Jan Kassens committed
Jul 22, 2024 at 11:50 UTC
d025ddd3b954dfc52ad7e6a036913946a8ca2644
11 files changed
+4
-16
packages/react/src/__tests__/ReactJSXRuntime-test.js
+1
-1
@@ -377,7 +377,7 @@ describe('ReactJSXRuntime', () => {
377
expect(didCall).toBe(false);
378
});
379
380
- // @gate enableFastJSX && enableRefAsProp
380
+ // @gate enableRefAsProp
381
it('does not clone props object if key and ref is not spread', async () => {
382
const config = {
383
foo: 'foo',
packages/react/src/jsx/ReactJSXElement.js
+3
-6
@@ -23,7 +23,6 @@ import {
23
enableRefAsProp,
24
disableStringRefs,
25
disableDefaultPropsExceptForClasses,
26
- enableFastJSX,
26
enableOwnerStacks,
27
} from 'shared/ReactFeatureFlags';
28
import {checkPropStringCoercion} from 'shared/CheckStringCoercion';
@@ -82,9 +81,7 @@ if (__DEV__) {
81
didWarnAboutElementRef = {};
82
}
83
85
-const enableFastJSXWithStringRefs = enableFastJSX && enableRefAsProp;
86
-const enableFastJSXWithoutStringRefs =
87
- enableFastJSXWithStringRefs && disableStringRefs;
84
+const enableFastJSXWithoutStringRefs = enableRefAsProp && disableStringRefs;
85
86
function hasValidRef(config) {
87
if (__DEV__) {
@@ -416,7 +413,7 @@ export function jsxProd(type, config, maybeKey) {
413
let props;
414
if (
415
(enableFastJSXWithoutStringRefs ||
419
- (enableFastJSXWithStringRefs && !('ref' in config))) &&
416
+ (enableRefAsProp && !('ref' in config))) &&
417
!('key' in config)
418
) {
419
// If key was not spread in, we can reuse the original props object. This
@@ -701,7 +698,7 @@ function jsxDEVImpl(
698
let props;
699
if (
700
(enableFastJSXWithoutStringRefs ||
704
- (enableFastJSXWithStringRefs && !('ref' in config))) &&
701
+ (enableRefAsProp && !('ref' in config))) &&
702
!('key' in config)
703
) {
704
// If key was not spread in, we can reuse the original props object. This
packages/shared/ReactFeatureFlags.js
-1
@@ -195,7 +195,6 @@ export const enableInfiniteRenderLoopDetection = true;
195
// during element creation.
196
export const enableRefAsProp = true;
197
export const disableStringRefs = true;
198
-export const enableFastJSX = true;
198
199
// Warn on any usage of ReactTestRenderer
200
export const enableReactTestRendererWarning = true;
packages/shared/forks/ReactFeatureFlags.native-fb-dynamic.js
-1
@@ -19,7 +19,6 @@
19
20
export const alwaysThrottleRetries = __VARIANT__;
21
export const enableAddPropertiesFastPath = __VARIANT__;
22
-export const enableFastJSX = __VARIANT__;
22
export const enableObjectFiber = __VARIANT__;
23
export const enableShallowPropDiffing = __VARIANT__;
24
export const passChildrenWhenCloningPersistedNodes = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.native-fb.js
-1
@@ -21,7 +21,6 @@ const dynamicFlags: DynamicExportsType = (dynamicFlagsUntyped: any);
21
export const {
22
alwaysThrottleRetries,
23
enableAddPropertiesFastPath,
24
- enableFastJSX,
24
enableObjectFiber,
25
enableShallowPropDiffing,
26
passChildrenWhenCloningPersistedNodes,
packages/shared/forks/ReactFeatureFlags.native-oss.js
-1
@@ -45,7 +45,6 @@ export const enableCreateEventHandleAPI = false;
45
export const enableDebugTracing = false;
46
export const enableDeferRootSchedulingToMicrotask = true;
47
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
48
-export const enableFastJSX = true;
48
export const enableFilterEmptyStringAttributesDOM = true;
49
export const enableFizzExternalRuntime = true;
50
export const enableFlightReadableStream = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.js
-1
@@ -89,7 +89,6 @@ export const enableShallowPropDiffing = false;
89
// const __NEXT_MAJOR__ = __EXPERIMENTAL__;
90
export const enableRefAsProp = true;
91
export const disableStringRefs = true;
92
-export const enableFastJSX = true;
92
export const disableLegacyMode = true;
93
export const disableLegacyContext = true;
94
export const disableLegacyContextForFunctionComponents = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.native-fb.js
-1
@@ -37,7 +37,6 @@ export const enableCreateEventHandleAPI = false;
37
export const enableDebugTracing = false;
38
export const enableDeferRootSchedulingToMicrotask = true;
39
export const enableDO_NOT_USE_disableStrictPassiveEffect = false;
40
-export const enableFastJSX = true;
40
export const enableFilterEmptyStringAttributesDOM = true;
41
export const enableFizzExternalRuntime = true;
42
export const enableFlightReadableStream = true;
packages/shared/forks/ReactFeatureFlags.test-renderer.www.js
-1
@@ -81,7 +81,6 @@ export const enableInfiniteRenderLoopDetection = false;
81
82
export const enableRefAsProp = true;
83
export const disableStringRefs = false;
84
-export const enableFastJSX = false;
84
85
export const enableReactTestRendererWarning = false;
86
export const disableLegacyMode = true;
packages/shared/forks/ReactFeatureFlags.www-dynamic.js
-1
@@ -21,7 +21,6 @@ export const disableSchedulerTimeoutInWorkLoop = __VARIANT__;
21
export const enableAddPropertiesFastPath = __VARIANT__;
22
export const enableDeferRootSchedulingToMicrotask = __VARIANT__;
23
export const enableDO_NOT_USE_disableStrictPassiveEffect = __VARIANT__;
24
-export const enableFastJSX = __VARIANT__;
24
export const enableLazyContextPropagation = __VARIANT__;
25
export const enableNoCloningMemoCache = __VARIANT__;
26
export const enableObjectFiber = __VARIANT__;
packages/shared/forks/ReactFeatureFlags.www.js
-1
@@ -23,7 +23,6 @@ export const {
23
enableDebugTracing,
24
enableDeferRootSchedulingToMicrotask,
25
enableDO_NOT_USE_disableStrictPassiveEffect,
26
- enableFastJSX,
26
enableInfiniteRenderLoopDetection,
27
enableLazyContextPropagation,
28
enableNoCloningMemoCache,