@samitouri / QOS-React / commits / d16c26da40

[ci] Specify if-no-files-found on actions/upload-artifact@v4 (#32679)

Defaults to warn, but since some steps require these artifacts to be uploaded we specify an error if its not found. Some other steps like playwright test-results are only uploaded on failure so it's okay to ignore. --- [//]: # (BEGIN SAPLING FOOTER) Stack created with [Sapling](https://sapling-scm.com). Best reviewed with [ReviewStack](https://reviewstack.dev/facebook/react/pull/32679). * #32680 * __->__ #32679 * #32678

lauren committed Mar 19, 2025 at 17:22 UTC d16c26da40c96704e24b43832d2f7057f586c415
4 files changed +14
.github/workflows/compiler_playground.yml
+1
@@ -50,3 +50,4 @@ jobs:
50 with:
51 name: test-results
52 path: compiler/apps/playground/test-results
53 + if-no-files-found: ignore
.github/workflows/devtools_regression_tests.yml
+5
@@ -47,6 +47,7 @@ jobs:
47 with:
48 name: build
49 path: build
50 + if-no-files-found: error
51
52 build_devtools_and_process_artifacts:
53 name: Build DevTools and process artifacts
@@ -84,17 +85,20 @@ jobs:
85 with:
86 name: react-devtools
87 path: build/devtools.tgz
88 + if-no-files-found: error
89 # Simplifies getting the extension for local testing
90 - name: Archive chrome extension
91 uses: actions/upload-artifact@v4
92 with:
93 name: react-devtools-chrome-extension
94 path: build/devtools/chrome-extension.zip
95 + if-no-files-found: error
96 - name: Archive firefox extension
97 uses: actions/upload-artifact@v4
98 with:
99 name: react-devtools-firefox-extension
100 path: build/devtools/firefox-extension.zip
101 + if-no-files-found: error
102
103 run_devtools_tests_for_versions:
104 name: Run DevTools tests for versions
@@ -179,3 +183,4 @@ jobs:
183 with:
184 name: screenshots
185 path: ./tmp/screenshots
186 + if-no-files-found: warn
.github/workflows/runtime_build_and_test.yml
+6
@@ -302,6 +302,7 @@ jobs:
302 with:
303 name: _build_${{ matrix.worker_id }}_${{ matrix.release_channel }}
304 path: build
305 + if-no-files-found: error
306
307 test_build:
308 name: yarn test-build
@@ -426,6 +427,7 @@ jobs:
427 path: |
428 ./build.tgz
429 ./build2.tgz
430 + if-no-files-found: error
431
432 check_error_codes:
433 name: Search build artifacts for unminified errors
@@ -603,11 +605,13 @@ jobs:
605 with:
606 name: flight-playwright-report
607 path: fixtures/flight/playwright-report
608 + if-no-files-found: warn
609 - name: Archive Flight fixture artifacts
610 uses: actions/upload-artifact@v4
611 with:
612 name: flight-test-results
613 path: fixtures/flight/test-results
614 + if-no-files-found: ignore
615
616 # ----- DEVTOOLS -----
617 build_devtools_and_process_artifacts:
@@ -655,6 +659,7 @@ jobs:
659 with:
660 name: react-devtools-${{ matrix.browser }}-extension
661 path: build/devtools/${{ matrix.browser }}-extension.zip
662 + if-no-files-found: error
663
664 merge_devtools_artifacts:
665 name: Merge DevTools artifacts
@@ -767,3 +772,4 @@ jobs:
772 with:
773 name: sizebot-message
774 path: sizebot-message.md
775 + if-no-files-found: ignore
.github/workflows/runtime_commit_artifacts.yml
+2
@@ -170,10 +170,12 @@ jobs:
170 with:
171 name: compiled
172 path: compiled/
173 + if-no-files-found: error
174 - uses: actions/upload-artifact@v4
175 with:
176 name: compiled-rn
177 path: compiled-rn/
178 + if-no-files-found: error
179
180 commit_www_artifacts:
181 needs: download_artifacts