@samitouri / QOS-React / commits / d3e0a3aaf3

Fix jest/matchers/toWarnDev expected, actual order for jest-diff (#12285) (#12288)

`toWarnDev` calls `jestDiff(a, b)` which calls `diffStrings(a, b)` where by default `a` is annotated as `'Expected'` (green), `b` as `'Received'` (red). So the first argument passed into `jestDiff` should be the expected message, the second should be the actual message. It was vice versa previously. - https://github.com/facebook/jest/blob/457776b2889a9be1ce8a2c636a23417264a98d99/packages/jest-diff/src/index.js#L54 - https://github.com/facebook/jest/blob/457776b2889a9be1ce8a2c636a23417264a98d99/packages/jest-diff/src/index.js#L93 - https://github.com/facebook/jest/blob/457776b2889a9be1ce8a2c636a23417264a98d99/packages/jest-diff/src/diff_strings.js#L249-L251

Ivan Babak committed Jun 8, 2018 at 05:18 UTC d3e0a3aaf33dd0134a2c5296db8b6ca43cab968e
1 file changed +2 -2
scripts/jest/matchers/toWarnDev.js
+2 -2
@@ -49,11 +49,11 @@ const createMatcherFor = consoleMethod =>
49 } else if (expectedMessages.length === 1) {
50 errorMessage =
51 'Unexpected warning recorded: ' +
52 - jestDiff(normalizedMessage, expectedMessages[0]);
52 + jestDiff(expectedMessages[0], normalizedMessage);
53 } else {
54 errorMessage =
55 'Unexpected warning recorded: ' +
56 - jestDiff([normalizedMessage], expectedMessages);
56 + jestDiff(expectedMessages, [normalizedMessage]);
57 }
58
59 // Record the call stack for unexpected warnings.