@samitouri / QOS-React / commits / d5d10d140e

Simplify imports in react reconciler (#13718)

* Simplify imports in ReactChildFiber * Import type first in ReactCurrentFiber * Simplify imports in ReactFiberBeginWork * Simplify imports in ReactFiberScheduler * Simplify import in ReactFiberTreeReflection * Simplify import in ReactFiberUnwindWork * Remove repeated import * Fix imports from ReactFiberExpirationTime * Master imports in ReactFiberBeginWork

Maksim Markelov committed Nov 1, 2018 at 07:12 UTC d5d10d140ed8739c83f3cee5d43f0bf60eea1002
6 files changed +11 -7
packages/react-reconciler/src/ReactChildFiber.js
+2 -2
@@ -9,8 +9,8 @@
9
10 import type {ReactElement} from 'shared/ReactElementType';
11 import type {ReactPortal} from 'shared/ReactTypes';
12 -import type {Fiber} from 'react-reconciler/src/ReactFiber';
13 -import type {ExpirationTime} from 'react-reconciler/src/ReactFiberExpirationTime';
12 +import type {Fiber} from './ReactFiber';
13 +import type {ExpirationTime} from './ReactFiberExpirationTime';
14
15 import getComponentName from 'shared/getComponentName';
16 import {Placement, Deletion} from 'shared/ReactSideEffectTags';
packages/react-reconciler/src/ReactCurrentFiber.js
+2 -2
@@ -7,6 +7,8 @@
7 * @flow
8 */
9
10 +import type {Fiber} from './ReactFiber';
11 +
12 import ReactSharedInternals from 'shared/ReactSharedInternals';
13 import {
14 IndeterminateComponent,
@@ -21,8 +23,6 @@ import getComponentName from 'shared/getComponentName';
23
24 const ReactDebugCurrentFrame = ReactSharedInternals.ReactDebugCurrentFrame;
25
24 -import type {Fiber} from './ReactFiber';
25 -
26 type LifeCyclePhase = 'render' | 'getChildContext';
27
28 function describeFiber(fiber: Fiber): string {
packages/react-reconciler/src/ReactFiberBeginWork.js
+1 -1
@@ -8,7 +8,7 @@
8 */
9
10 import type {ReactProviderType, ReactContext} from 'shared/ReactTypes';
11 -import type {Fiber} from 'react-reconciler/src/ReactFiber';
11 +import type {Fiber} from './ReactFiber';
12 import type {FiberRoot} from './ReactFiberRoot';
13 import type {ExpirationTime} from './ReactFiberExpirationTime';
14 import type {SuspenseState} from './ReactFiberSuspenseComponent';
packages/react-reconciler/src/ReactFiberScheduler.js
+3
@@ -78,6 +78,9 @@ import {
78 noTimeout,
79 prepareForCommit,
80 resetAfterCommit,
81 + scheduleTimeout,
82 + cancelTimeout,
83 + noTimeout,
84 } from './ReactFiberHostConfig';
85 import {
86 markPendingPriorityLevel,
packages/react-reconciler/src/ReactFiberTreeReflection.js
+1 -1
@@ -7,7 +7,7 @@
7 * @flow
8 */
9
10 -import type {Fiber} from 'react-reconciler/src/ReactFiber';
10 +import type {Fiber} from './ReactFiber';
11
12 import invariant from 'shared/invariant';
13 import warningWithoutStack from 'shared/warningWithoutStack';
packages/react-reconciler/src/ReactFiberUnwindWork.js
+2 -1
@@ -61,11 +61,12 @@ import {
61 isAlreadyFailedLegacyErrorBoundary,
62 retrySuspendedRoot,
63 } from './ReactFiberScheduler';
64 -import {NoWork, Sync} from './ReactFiberExpirationTime';
64
65 import invariant from 'shared/invariant';
66 import maxSigned31BitInt from './maxSigned31BitInt';
67 import {
68 + NoWork,
69 + Sync,
70 expirationTimeToMs,
71 LOW_PRIORITY_EXPIRATION,
72 } from './ReactFiberExpirationTime';