Reassign process.env.NODE_ENV instead of shimming process
Dan Abramov committed
Jan 31, 2017 at 16:28 UTC
d6d129a1b22112d1a79c3685cdf82c6e48c76c67
2 files changed
+4
-16
src/isomorphic/classic/types/__tests__/ReactPropTypesProduction-test.js
+2
-8
@@ -12,8 +12,6 @@
12
'use strict';
13
14
describe('ReactPropTypesProduction', function() {
15
- var oldProcess;
16
-
15
var PropTypes;
16
var React;
17
var ReactPropTypeLocations;
@@ -21,11 +19,7 @@ describe('ReactPropTypesProduction', function() {
19
20
beforeEach(function() {
21
__DEV__ = false;
24
- oldProcess = process;
25
- global.process = {
26
- cwd: process.cwd,
27
- env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
28
- };
22
+ process.env['NODE_ENV'] = 'production';
23
24
jest.resetModules();
25
PropTypes = require('ReactPropTypes');
@@ -36,7 +30,7 @@ describe('ReactPropTypesProduction', function() {
30
31
afterEach(function() {
32
__DEV__ = true;
39
- global.process = oldProcess;
33
+ process.env['NODE_ENV'] = 'test';
34
});
35
36
function expectThrowsInProduction(declaration, value) {
src/renderers/dom/__tests__/ReactDOMProduction-test.js
+2
-8
@@ -11,8 +11,6 @@
11
'use strict';
12
13
describe('ReactDOMProduction', () => {
14
- var oldProcess;
15
-
14
var ReactDOMFeatureFlags = require('ReactDOMFeatureFlags');
15
16
var React;
@@ -20,11 +18,7 @@ describe('ReactDOMProduction', () => {
18
19
beforeEach(() => {
20
__DEV__ = false;
23
- oldProcess = process;
24
- global.process = {
25
- cwd: process.cwd,
26
- env: Object.assign({}, process.env, {NODE_ENV: 'production'}),
27
- };
21
+ process.env['NODE_ENV'] = 'production';
22
23
jest.resetModules();
24
React = require('React');
@@ -33,7 +27,7 @@ describe('ReactDOMProduction', () => {
27
28
afterEach(() => {
29
__DEV__ = true;
36
- global.process = oldProcess;
30
+ process.env['NODE_ENV'] = 'test';
31
});
32
33
it('should use prod fbjs', () => {