Removed some outdated TODO comments
Brian Vaughn committed
Mar 24, 2019 at 10:14 UTC
d973452c362ed7f9808f93663fa6219e25528864
5 files changed
+13
-8
shells/browser/shared/src/main.js
-1
@@ -126,7 +126,6 @@ function createPanelIfReactLoaded() {
126
});
127
});
128
129
- // TODO (profiling) Is there a way to detect profiling support and conditionally register this panel?
129
chrome.devtools.panels.create('⚛ Profiler', '', 'panel.html', panel => {
130
panel.onShown.addListener(panel => {
131
profilerPortalContainer = panel.container;
src/backend/agent.js
-3
@@ -46,9 +46,6 @@ export default class Agent extends EventEmitter {
46
addBridge(bridge: Bridge) {
47
this._bridge = bridge;
48
49
- // TODO (profiling) Component commits
50
- // TODO (profiling) Interactions
51
-
49
bridge.addListener('getCommitDetails', this.getCommitDetails);
50
bridge.addListener('getInteractions', this.getInteractions);
51
bridge.addListener('getProfilingStatus', this.getProfilingStatus);
src/backend/renderer.js
+9
-2
@@ -1419,7 +1419,11 @@ export function attach(
1419
};
1420
}
1421
}
1422
- // TODO (profiling) Is this right? Should I return null? Does it matter?
1422
+
1423
+ console.warn(
1424
+ `getCommitDetails(): No profiling info recorded for root "${rootID}" and commit ${commitIndex}`
1425
+ );
1426
+
1427
return {
1428
commitIndex,
1429
interactions: [],
@@ -1455,7 +1459,10 @@ export function attach(
1459
};
1460
}
1461
1458
- // TODO (profiling) Is this right? Should I return null? Does it matter?
1462
+ console.warn(
1463
+ `getInteractions(): No interactions recorded for root "${rootID}"`
1464
+ );
1465
+
1466
return {
1467
interactions: [],
1468
rootID,
src/devtools/views/Profiler/CommitTreeBuilder.js
+4
-1
@@ -112,7 +112,10 @@ export function getCommitTree({
112
}
113
}
114
115
- // TODO (profiling) Should I throw here? Is this ever expected?
115
+ console.error(
116
+ `getCommitTree(): Unable to reconstruct tree for root "${rootID}" and commit ${commitIndex}`
117
+ );
118
+
119
return {
120
nodes: new Map(),
121
rootID,
src/devtools/views/Profiler/SnapshotCommitList.js
-1
@@ -95,7 +95,6 @@ function List({
95
96
// When the mouse is down, dragging over a commit should auto-select it.
97
// This provides a nice way for users to swipe across a range of commits to compare them.
98
- // TODO (profiling) This interaction may not feel as nice with suspense; reconsider it?
98
const [isMouseDown, setIsMouseDown] = useState(false);
99
const handleMouseDown = useCallback(() => {
100
setIsMouseDown(true);