Remove "unstable" warning from ReactDOM (#10017)
* Remove "unstable" warning from ReactDOM * Remove assertion about the warning * There's more!
Dan Abramov committed
Jun 21, 2017 at 19:06 UTC
df10073f7d26d573db19dfc030b6b9edcbcfd27f
2 files changed
-31
src/renderers/__tests__/refs-test.js
-18
@@ -316,7 +316,6 @@ describe('string refs between fiber and stack', () => {
316
});
317
318
it('attaches, detaches from fiber component with stack layer', () => {
319
- spyOn(console, 'error');
319
const ReactCurrentOwner = require('ReactCurrentOwner');
320
321
const ReactDOMStack = require('ReactDOMStackEntry');
@@ -353,18 +352,9 @@ describe('string refs between fiber and stack', () => {
352
ReactDOMFiber.unmountComponentAtNode(container);
353
expect(a.refs.span).toBe(undefined);
354
expect(layerMounted).toBe(true);
356
- if (!ReactDOMFeatureFlags.useFiber) {
357
- expectDev(console.error.calls.count()).toBe(1);
358
- expectDev(console.error.calls.argsFor(0)[0]).toBe(
359
- 'Warning: You are using React DOM Fiber which is an experimental ' +
360
- 'renderer. It is likely to have bugs, breaking changes and is ' +
361
- 'unsupported.',
362
- );
363
- }
355
});
356
357
it('attaches, detaches from stack component with fiber layer', () => {
367
- spyOn(console, 'error');
358
const ReactCurrentOwner = require('ReactCurrentOwner');
359
const ReactDOM = require('ReactDOMStackEntry');
360
const ReactDOMFiber = require('ReactDOMFiberEntry');
@@ -400,14 +390,6 @@ describe('string refs between fiber and stack', () => {
390
ReactDOM.unmountComponentAtNode(container);
391
expect(a.refs.span).toBe(undefined);
392
expect(layerMounted).toBe(true);
403
- if (!ReactDOMFeatureFlags.useFiber) {
404
- expectDev(console.error.calls.count()).toBe(1);
405
- expectDev(console.error.calls.argsFor(0)[0]).toBe(
406
- 'Warning: You are using React DOM Fiber which is an experimental ' +
407
- 'renderer. It is likely to have bugs, breaking changes and is ' +
408
- 'unsupported.',
409
- );
410
- }
393
});
394
});
395
src/renderers/dom/fiber/ReactDOMFiberEntry.js
-13
@@ -454,18 +454,6 @@ ReactGenericBatching.injection.injectFiberBatchedUpdates(
454
DOMRenderer.batchedUpdates,
455
);
456
457
-var warned = false;
458
-
459
-function warnAboutUnstableUse() {
460
- // Ignore this warning is the feature flag is turned on. E.g. for tests.
461
- warning(
462
- warned || ReactDOMFeatureFlags.useFiber,
463
- 'You are using React DOM Fiber which is an experimental renderer. ' +
464
- 'It is likely to have bugs, breaking changes and is unsupported.',
465
- );
466
- warned = true;
467
-}
468
-
457
function renderSubtreeIntoContainer(
458
parentComponent: ?ReactComponent<any, any, any>,
459
children: ReactNodeList,
@@ -588,7 +576,6 @@ var ReactDOMFiber = {
576
isValidContainer(container),
577
'unmountComponentAtNode(...): Target container is not a DOM element.',
578
);
591
- warnAboutUnstableUse();
579
580
if (container._reactRootContainer) {
581
if (__DEV__) {