@samitouri / QOS-React / commits / e8a2b47eb5

[compiler] Remove sleep in manual release script

I originally added this prior to the compiler being OSS'd as a "just in case" feature to panic cancel if something went wrong. Now that the compiler is already launched this is unnecessary. ghstack-source-id: dd17dc8a331657ce23c0cbc012ba967cfc3b9542 Pull Request resolved: https://github.com/facebook/react/pull/30613

Lauren Tan committed Aug 6, 2024 at 14:41 UTC e8a2b47eb5d807a2da22915a6d444d3947c9a885
1 file changed -14
compiler/scripts/release/publish-manual.js
-14
@@ -11,7 +11,6 @@ const PUBLISHABLE_PACKAGES = [
11 'eslint-plugin-react-compiler',
12 'react-compiler-healthcheck',
13 ];
14 -const TIME_TO_RECONSIDER = 3_000;
14
15 function _spawn(command, args, options, cb) {
16 const child = cp.spawn(command, args, options);
@@ -33,10 +32,6 @@ function execHelper(command, options, streamStdout = false) {
32 });
33 }
34
36 -function sleep(ms) {
37 - return new Promise(resolve => setTimeout(resolve, ms));
38 -}
39 -
35 async function getDateStringForCommit(commit) {
36 let dateString = await execHelper(
37 `git show -s --no-show-signature --format=%cd --date=format:%Y%m%d ${commit}`
@@ -191,15 +186,6 @@ async function main() {
186 );
187 }
188
194 - if (debug === false) {
195 - spinner.info(
196 - `🚨🚨🚨 About to publish to npm in ${
197 - TIME_TO_RECONSIDER / 1000
198 - } seconds. You still have time to kill this script!`
199 - );
200 - await sleep(TIME_TO_RECONSIDER);
201 - }
202 -
189 for (const pkgName of pkgNames) {
190 const pkgDir = path.resolve(__dirname, `../../packages/${pkgName}`);
191 console.log(`\n========== ${pkgName} ==========\n`);