Remove setProps and replaceProps from src (#7045)
Toru Kobayashi committed
Jun 15, 2016 at 14:11 UTC
e8fa464d6f4362cadcee625eb29dece56181eb13
4 files changed
+1
-7
src/isomorphic/modern/class/__tests__/ReactCoffeeScriptClass-test.coffee
-2
@@ -362,8 +362,6 @@ describe 'ReactCoffeeScriptClass', ->
362
test Inner(name: 'foo'), 'DIV', 'foo'
363
expect(-> instance.replaceState {}).toThrow()
364
expect(-> instance.isMounted()).toThrow()
365
- expect(-> instance.setProps name: 'bar').toThrow()
366
- expect(-> instance.replaceProps name: 'bar').toThrow()
365
expect(console.error.calls.count()).toBe 2
366
expect(console.error.calls.argsFor(0)[0]).toContain(
367
'replaceState(...) is deprecated in plain JavaScript React classes'
src/isomorphic/modern/class/__tests__/ReactES6Class-test.js
-2
@@ -402,8 +402,6 @@ describe('ReactES6Class', function() {
402
var instance = test(<Inner name="foo" />, 'DIV', 'foo');
403
expect(() => instance.replaceState({})).toThrow();
404
expect(() => instance.isMounted()).toThrow();
405
- expect(() => instance.setProps({name: 'bar'})).toThrow();
406
- expect(() => instance.replaceProps({name: 'bar'})).toThrow();
405
expect(console.error.calls.count()).toBe(2);
406
expect(console.error.calls.argsFor(0)[0]).toContain(
407
'replaceState(...) is deprecated in plain JavaScript React classes'
src/isomorphic/modern/class/__tests__/ReactTypeScriptClass-test.ts
-2
@@ -489,8 +489,6 @@ describe('ReactTypeScriptClass', function() {
489
);
490
expect(() => instance.replaceState({})).toThrow();
491
expect(() => instance.isMounted()).toThrow();
492
- expect(() => instance.setProps({ name: 'bar' })).toThrow();
493
- expect(() => instance.replaceProps({ name: 'bar' })).toThrow();
492
expect((<any>console.error).calls.count()).toBe(2);
493
expect((<any>console.error).calls.argsFor(0)[0]).toContain(
494
'replaceState(...) is deprecated in plain JavaScript React classes'
src/renderers/shared/stack/reconciler/ReactUpdates.js
+1
-1
@@ -232,7 +232,7 @@ function enqueueUpdate(component) {
232
// Various parts of our code (such as ReactCompositeComponent's
233
// _renderValidatedComponent) assume that calls to render aren't nested;
234
// verify that that's the case. (This is called by each top-level update
235
- // function, like setProps, setState, forceUpdate, etc.; creation and
235
+ // function, like setState, forceUpdate, etc.; creation and
236
// destruction of top-level components is guarded in ReactMount.)
237
238
if (!batchingStrategy.isBatchingUpdates) {