react-art: convert var to let/const (#11720)
Raphael Amorim committed
Nov 30, 2017 at 13:23 UTC
e997756e2a95150e039b648e2758b08deea68511
2 files changed
+36
-36
packages/react-art/index.js
+1
-1
@@ -9,6 +9,6 @@
9
10
'use strict';
11
12
-var ReactART = require('./src/ReactART');
12
+const ReactART = require('./src/ReactART');
13
14
module.exports = ReactART;
packages/react-art/src/__tests__/ReactART-test.js
+35
-35
@@ -11,25 +11,25 @@
11
12
'use strict';
13
14
-var React = require('react');
15
-var ReactDOM = require('react-dom');
16
-var ReactTestUtils = require('react-dom/test-utils');
14
+const React = require('react');
15
+const ReactDOM = require('react-dom');
16
+const ReactTestUtils = require('react-dom/test-utils');
17
18
-var Group;
19
-var Shape;
20
-var Surface;
21
-var TestComponent;
18
+let Group;
19
+let Shape;
20
+let Surface;
21
+let TestComponent;
22
23
-var Missing = {};
23
+const Missing = {};
24
25
-var ReactART = require('react-art');
26
-var ARTSVGMode = require('art/modes/svg');
27
-var ARTCurrentMode = require('art/modes/current');
25
+const ReactART = require('react-art');
26
+const ARTSVGMode = require('art/modes/svg');
27
+const ARTCurrentMode = require('art/modes/current');
28
29
function testDOMNodeStructure(domNode, expectedStructure) {
30
expect(domNode).toBeDefined();
31
expect(domNode.nodeName).toBe(expectedStructure.nodeName);
32
- for (var prop in expectedStructure) {
32
+ for (const prop in expectedStructure) {
33
if (!expectedStructure.hasOwnProperty(prop)) {
34
continue;
35
}
@@ -58,7 +58,7 @@ describe('ReactART', () => {
58
59
TestComponent = class extends React.Component {
60
render() {
61
- var a = (
61
+ const a = (
62
<Shape
63
d="M0,0l50,0l0,50l-50,0z"
64
fill={new ReactART.LinearGradient(['black', 'white'])}
@@ -71,7 +71,7 @@ describe('ReactART', () => {
71
/>
72
);
73
74
- var b = (
74
+ const b = (
75
<Shape
76
fill="#3C5A99"
77
key="b"
@@ -86,7 +86,7 @@ describe('ReactART', () => {
86
</Shape>
87
);
88
89
- var c = <Group key="c" />;
89
+ const c = <Group key="c" />;
90
91
return (
92
<Surface width={150} height={200}>
@@ -100,18 +100,18 @@ describe('ReactART', () => {
100
});
101
102
it('should have the correct lifecycle state', () => {
103
- var instance = <TestComponent />;
103
+ let instance = <TestComponent />;
104
instance = ReactTestUtils.renderIntoDocument(instance);
105
- var group = instance.refs.group;
105
+ const group = instance.refs.group;
106
// Duck type test for an ART group
107
expect(typeof group.indicate).toBe('function');
108
});
109
110
it('should render a reasonable SVG structure in SVG mode', () => {
111
- var instance = <TestComponent />;
111
+ let instance = <TestComponent />;
112
instance = ReactTestUtils.renderIntoDocument(instance);
113
114
- var expectedStructure = {
114
+ const expectedStructure = {
115
nodeName: 'svg',
116
width: '150',
117
height: '200',
@@ -132,18 +132,18 @@ describe('ReactART', () => {
132
],
133
};
134
135
- var realNode = ReactDOM.findDOMNode(instance);
135
+ const realNode = ReactDOM.findDOMNode(instance);
136
testDOMNodeStructure(realNode, expectedStructure);
137
});
138
139
it('should be able to reorder components', () => {
140
- var container = document.createElement('div');
141
- var instance = ReactDOM.render(
140
+ const container = document.createElement('div');
141
+ const instance = ReactDOM.render(
142
<TestComponent flipped={false} />,
143
container,
144
);
145
146
- var expectedStructure = {
146
+ const expectedStructure = {
147
nodeName: 'svg',
148
children: [
149
{nodeName: 'defs'},
@@ -159,12 +159,12 @@ describe('ReactART', () => {
159
],
160
};
161
162
- var realNode = ReactDOM.findDOMNode(instance);
162
+ const realNode = ReactDOM.findDOMNode(instance);
163
testDOMNodeStructure(realNode, expectedStructure);
164
165
ReactDOM.render(<TestComponent flipped={true} />, container);
166
167
- var expectedNewStructure = {
167
+ const expectedNewStructure = {
168
nodeName: 'svg',
169
children: [
170
{nodeName: 'defs'},
@@ -184,11 +184,11 @@ describe('ReactART', () => {
184
});
185
186
it('should be able to reorder many components', () => {
187
- var container = document.createElement('div');
187
+ const container = document.createElement('div');
188
189
class Component extends React.Component {
190
render() {
191
- var chars = this.props.chars.split('');
191
+ const chars = this.props.chars.split('');
192
return (
193
<Surface>
194
{chars.map(text => <Shape key={text} title={text} />)}
@@ -198,11 +198,11 @@ describe('ReactART', () => {
198
}
199
200
// Mini multi-child stress test: lots of reorders, some adds, some removes.
201
- var before = 'abcdefghijklmnopqrst';
202
- var after = 'mxhpgwfralkeoivcstzy';
201
+ const before = 'abcdefghijklmnopqrst';
202
+ const after = 'mxhpgwfralkeoivcstzy';
203
204
- var instance = ReactDOM.render(<Component chars={before} />, container);
205
- var realNode = ReactDOM.findDOMNode(instance);
204
+ let instance = ReactDOM.render(<Component chars={before} />, container);
205
+ const realNode = ReactDOM.findDOMNode(instance);
206
expect(realNode.textContent).toBe(before);
207
208
instance = ReactDOM.render(<Component chars={after} />, container);
@@ -212,7 +212,7 @@ describe('ReactART', () => {
212
});
213
214
it('renders composite with lifecycle inside group', () => {
215
- var mounted = false;
215
+ let mounted = false;
216
217
class CustomShape extends React.Component {
218
render() {
@@ -241,7 +241,7 @@ describe('ReactART', () => {
241
}
242
}
243
244
- var ref = null;
244
+ let ref = null;
245
246
class Outer extends React.Component {
247
componentDidMount() {
@@ -270,7 +270,7 @@ describe('ReactART', () => {
270
}
271
}
272
273
- var ref = {};
273
+ let ref = {};
274
275
class Outer extends React.Component {
276
componentDidMount() {
@@ -292,7 +292,7 @@ describe('ReactART', () => {
292
}
293
}
294
295
- var container = document.createElement('div');
295
+ const container = document.createElement('div');
296
ReactDOM.render(<Outer />, container);
297
expect(ref).not.toBeDefined();
298
ReactDOM.render(<Outer mountCustomShape={true} />, container);