[attribute-behavior] Canonicalize values immediately after reading them (#10584)
In case they are mutated
Andrew Clark committed
Aug 31, 2017 at 16:46 UTC
edc9c2fc70b0c8141a91244d7e14152d28f4479b
1 file changed
+3
-1
fixtures/attribute-behavior/src/App.js
+3
-1
@@ -2573,6 +2573,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) {
2573
};
2574
2575
let defaultValue;
2576
+ let canonicalDefaultValue;
2577
let result;
2578
let canonicalResult;
2579
let ssrResult;
@@ -2586,6 +2587,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) {
2587
try {
2588
renderer.render(React.createElement(tagName, baseProps), container);
2589
defaultValue = read(container.firstChild);
2590
+ canonicalDefaultValue = getCanonicalizedValue(defaultValue);
2591
renderer.render(React.createElement(tagName, props), container);
2592
result = read(container.firstChild);
2593
canonicalResult = getCanonicalizedValue(result);
@@ -2662,7 +2664,7 @@ function getRenderedAttributeValue(renderer, serverRenderer, attribute, type) {
2664
defaultValue,
2665
result,
2666
canonicalResult,
2665
- canonicalDefaultValue: getCanonicalizedValue(defaultValue),
2667
+ canonicalDefaultValue,
2668
didWarn,
2669
didError,
2670
ssrResult,