Set fragment export flags to true (#11672)
Clement Hoang committed
Nov 27, 2017 at 13:09 UTC
f6894dc48be2e389ffae03cea736122a971e3f76
9 files changed
+2
-19
packages/react-cs-renderer/src/ReactNativeCSFeatureFlags.js
-1
@@ -15,7 +15,6 @@ import typeof * as CSFeatureFlagsType from './ReactNativeCSFeatureFlags';
15
export const debugRenderPhaseSideEffects = false;
16
export const enableAsyncSubtreeAPI = true;
17
export const enableAsyncSchedulingByDefaultInReactDOM = false;
18
-export const enableReactFragment = false;
18
export const enableCreateRoot = false;
19
export const enableUserTimingAPI = __DEV__;
20
packages/react-dom/src/__tests__/ReactDOMServerIntegrationFragment-test.internal.js
-1
@@ -18,7 +18,6 @@ let ReactDOMServer;
18
function initModules() {
19
// Reset warning cache.
20
jest.resetModuleRegistry();
21
- require('shared/ReactFeatureFlags').enableReactFragment = true;
21
React = require('react');
22
ReactDOM = require('react-dom');
23
ReactDOMServer = require('react-dom/server');
packages/react-native-renderer/src/ReactNativeFeatureFlags.js
-1
@@ -18,7 +18,6 @@ export const {debugRenderPhaseSideEffects} = require('ReactFeatureFlags');
18
// The rest of the flags are static for better dead code elimination.
19
export const enableAsyncSubtreeAPI = true;
20
export const enableAsyncSchedulingByDefaultInReactDOM = false;
21
-export const enableReactFragment = false;
21
export const enableCreateRoot = false;
22
export const enableUserTimingAPI = __DEV__;
23
export const enableMutatingReconciler = true;
packages/react-reconciler/src/ReactChildFiber.js
-2
@@ -12,7 +12,6 @@ import type {ReactCall, ReactPortal, ReactReturn} from 'shared/ReactTypes';
12
import type {Fiber} from 'react-reconciler/src/ReactFiber';
13
import type {ExpirationTime} from 'react-reconciler/src/ReactFiberExpirationTime';
14
15
-import {enableReactFragment} from 'shared/ReactFeatureFlags';
15
import {Placement, Deletion} from 'shared/ReactTypeOfSideEffect';
16
import {
17
getIteratorFn,
@@ -1376,7 +1375,6 @@ function ChildReconciler(shouldTrackSideEffects) {
1375
// This leads to an ambiguity between <>{[...]}</> and <>...</>.
1376
// We treat the ambiguous cases above the same.
1377
if (
1379
- enableReactFragment &&
1378
typeof newChild === 'object' &&
1379
newChild !== null &&
1380
newChild.type === REACT_FRAGMENT_TYPE &&
packages/react-reconciler/src/__tests__/ReactFragment-test.internal.js
-3
@@ -15,9 +15,6 @@ describe('ReactFragment', () => {
15
beforeEach(function() {
16
jest.resetModules();
17
18
- const ReactFeatureFlags = require('shared/ReactFeatureFlags');
19
- ReactFeatureFlags.enableReactFragment = true;
20
-
18
React = require('react');
19
ReactNoop = require('react-noop-renderer');
20
});
packages/react/src/React.js
+2
-5
@@ -7,7 +7,6 @@
7
8
import assign from 'object-assign';
9
import ReactVersion from 'shared/ReactVersion';
10
-import {enableReactFragment} from 'shared/ReactFeatureFlags';
10
import {REACT_FRAGMENT_TYPE} from 'shared/ReactSymbols';
11
12
import {Component, PureComponent, AsyncComponent} from './ReactBaseClasses';
@@ -39,6 +38,8 @@ var React = {
38
PureComponent,
39
unstable_AsyncComponent: AsyncComponent,
40
41
+ Fragment: REACT_FRAGMENT_TYPE,
42
+
43
createElement: __DEV__ ? createElementWithValidation : createElement,
44
cloneElement: __DEV__ ? cloneElementWithValidation : cloneElement,
45
createFactory: __DEV__ ? createFactoryWithValidation : createFactory,
@@ -53,10 +54,6 @@ var React = {
54
},
55
};
56
56
-if (enableReactFragment) {
57
- React.Fragment = REACT_FRAGMENT_TYPE;
58
-}
59
-
57
if (__DEV__) {
58
Object.assign(React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED, {
59
// These should not be included in production.
packages/react/src/__tests__/ReactJSXElementValidator-test.internal.js
-3
@@ -16,9 +16,6 @@ describe('ReactJSXElementValidator', () => {
16
beforeEach(() => {
17
jest.resetModules();
18
19
- const ReactFeatureFlags = require('shared/ReactFeatureFlags');
20
- ReactFeatureFlags.enableReactFragment = true;
21
-
19
React = require('react');
20
ReactTestUtils = require('react-dom/test-utils');
21
});
packages/shared/ReactFeatureFlags.js
-2
@@ -11,8 +11,6 @@ import invariant from 'fbjs/lib/invariant';
11
12
export const enableAsyncSubtreeAPI = true;
13
export const enableAsyncSchedulingByDefaultInReactDOM = false;
14
-// Exports React.Fragment
15
-export const enableReactFragment = false;
14
// Exports ReactDOM.createRoot
15
export const enableCreateRoot = false;
16
export const enableUserTimingAPI = __DEV__;
scripts/rollup/shims/rollup/ReactFeatureFlags-www.js
-1
@@ -18,7 +18,6 @@ export const {
18
19
// The rest of the flags are static for better dead code elimination.
20
export const enableAsyncSubtreeAPI = true;
21
-export const enableReactFragment = false;
21
export const enableCreateRoot = true;
22
23
// The www bundles only use the mutating reconciler.