Removed ReactMarkupChecksum from renderToString (#10053)
* Removed ReactMarkupChecksum from renderToString * Oops. I messed up the merge in the previous commit.
Sasha Aickin committed
Jun 27, 2017 at 14:20 UTC
f8a3a3989a2ba1c0a010070c6fe2eb6ca53a36df
2 files changed
+25
-17
src/renderers/dom/ReactDOMStringRenderer.js
-2
@@ -13,7 +13,6 @@
13
14
var invariant = require('fbjs/lib/invariant');
15
var React = require('react');
16
-var ReactMarkupChecksum = require('ReactMarkupChecksum');
16
var ReactPartialRenderer = require('ReactPartialRenderer');
17
18
/**
@@ -28,7 +27,6 @@ function renderToString(element) {
27
);
28
var renderer = new ReactPartialRenderer(element, false);
29
var markup = renderer.read(Infinity);
31
- markup = ReactMarkupChecksum.addChecksumToMarkup(markup);
30
return markup;
31
}
32
src/renderers/dom/shared/__tests__/ReactServerRendering-test.js
+25
-15
@@ -53,9 +53,11 @@ describe('ReactDOMServer', () => {
53
ROOT_ATTRIBUTE_NAME +
54
'="" ' +
55
ID_ATTRIBUTE_NAME +
56
- '="[^"]*" ' +
57
- ReactMarkupChecksum.CHECKSUM_ATTR_NAME +
58
- '="[^"]+">hello world</span>',
56
+ '="[^"]*"' +
57
+ (ReactDOMFeatureFlags.useFiber
58
+ ? ''
59
+ : ' ' + ReactMarkupChecksum.CHECKSUM_ATTR_NAME + '="[^"]+"') +
60
+ '>hello world</span>',
61
),
62
);
63
});
@@ -68,9 +70,11 @@ describe('ReactDOMServer', () => {
70
ROOT_ATTRIBUTE_NAME +
71
'="" ' +
72
ID_ATTRIBUTE_NAME +
71
- '="[^"]*" ' +
72
- ReactMarkupChecksum.CHECKSUM_ATTR_NAME +
73
- '="[^"]+"/>',
73
+ '="[^"]*"' +
74
+ (ReactDOMFeatureFlags.useFiber
75
+ ? ''
76
+ : ' ' + ReactMarkupChecksum.CHECKSUM_ATTR_NAME + '="[^"]+"') +
77
+ '/>',
78
),
79
);
80
});
@@ -83,9 +87,11 @@ describe('ReactDOMServer', () => {
87
ROOT_ATTRIBUTE_NAME +
88
'="" ' +
89
ID_ATTRIBUTE_NAME +
86
- '="[^"]*" ' +
87
- ReactMarkupChecksum.CHECKSUM_ATTR_NAME +
88
- '="[^"]+"/>',
90
+ '="[^"]*"' +
91
+ (ReactDOMFeatureFlags.useFiber
92
+ ? ''
93
+ : ' ' + ReactMarkupChecksum.CHECKSUM_ATTR_NAME + '="[^"]+"') +
94
+ '/>',
95
),
96
);
97
});
@@ -127,9 +133,11 @@ describe('ReactDOMServer', () => {
133
ROOT_ATTRIBUTE_NAME +
134
'="" ' +
135
ID_ATTRIBUTE_NAME +
130
- '="[^"]*" ' +
131
- ReactMarkupChecksum.CHECKSUM_ATTR_NAME +
132
- '="[^"]+">' +
136
+ '="[^"]*"' +
137
+ (ReactDOMFeatureFlags.useFiber
138
+ ? ''
139
+ : ' ' + ReactMarkupChecksum.CHECKSUM_ATTR_NAME + '="[^"]+"') +
140
+ '>' +
141
'<span ' +
142
ID_ATTRIBUTE_NAME +
143
'="[^"]*">' +
@@ -196,9 +204,11 @@ describe('ReactDOMServer', () => {
204
ROOT_ATTRIBUTE_NAME +
205
'="" ' +
206
ID_ATTRIBUTE_NAME +
199
- '="[^"]*" ' +
200
- ReactMarkupChecksum.CHECKSUM_ATTR_NAME +
201
- '="[^"]+">' +
207
+ '="[^"]*"' +
208
+ (ReactDOMFeatureFlags.useFiber
209
+ ? ''
210
+ : ' ' + ReactMarkupChecksum.CHECKSUM_ATTR_NAME + '="[^"]+"') +
211
+ '>' +
212
(ReactDOMFeatureFlags.useFiber
213
? 'Component name: <!-- -->TestComponent'
214
: '<!-- react-text: [0-9]+ -->Component name: <!-- /react-text -->' +