Use memoizedState in componentDidUpdate
We forgot to clone this value so it didn't work before. This is covered by existing tests in ReactDOMProduction.
Sebastian Markbage committed
Oct 11, 2016 at 15:52 UTC
fae3e5308bca79da4f7acc2d06b8adc3fbb1ea27
2 files changed
+2
-3
src/renderers/shared/fiber/ReactFiber.js
+1
@@ -253,6 +253,7 @@ exports.cloneFiber = function(fiber : Fiber, priorityLevel : PriorityLevel) : Fi
253
alt.pendingWorkPriority = priorityLevel;
254
255
alt.memoizedProps = fiber.memoizedProps;
256
+ alt.memoizedState = fiber.memoizedState;
257
alt.output = fiber.output;
258
259
return alt;
src/renderers/shared/fiber/ReactFiberCommitWork.js
+1
-3
@@ -289,9 +289,7 @@ module.exports = function<T, P, I, TI, C>(config : HostConfig<T, P, I, TI, C>) {
289
} else {
290
if (typeof instance.componentDidUpdate === 'function') {
291
const prevProps = current.memoizedProps;
292
- // TODO: This is the new state. We don't currently have the previous
293
- // state anymore.
294
- const prevState = instance.state || null;
292
+ const prevState = current.memoizedState;
293
instance.componentDidUpdate(prevProps, prevState);
294
}
295
}