@samitouri / QOS-React / commits / fe6e074128

Fix usage of console.error to prevent transform (#24188)

We were suppressing the `react-internals/warning-args` lint rule for the call to `console.error` in `defaultOnRecoverableError`. As far as I could tell, the lint rule exists because on dev builds, we replace all calls to `console.error` with [this error function](https://github.com/facebook/react/blob/main/packages/shared/consoleWithStackDev.js#L31-L37) which expects a format string + args and nothing else. We were trying to pass in an `Error` object directly. After this commit's change, we will still be passing an `Error` but the transform won't occur.

Yash Srivastav committed Mar 29, 2022 at 10:45 UTC fe6e0741286345edb2aa23784c21f8ea611ebdea
1 file changed +2 -2
packages/react-dom/src/client/ReactDOMRoot.js
+2 -2
@@ -81,8 +81,8 @@ const defaultOnRecoverableError =
81 reportError
82 : (error: mixed) => {
83 // In older browsers and test environments, fallback to console.error.
84 - // eslint-disable-next-line react-internal/no-production-logging, react-internal/warning-args
85 - console.error(error);
84 + // eslint-disable-next-line react-internal/no-production-logging
85 + console['error'](error);
86 };
87
88 function ReactDOMRoot(internalRoot: FiberRoot) {