Fix crash running `yarn flags --sort flag` (#28344)
Sebastian Silbermann committed
Feb 17, 2024 at 15:28 UTC
fef30c2e0403e0c6986904be89fcd01e665866ee
1 file changed
+9
-5
scripts/flags/flags.js
+9
-5
@@ -318,11 +318,15 @@ for (const flag of allFlagsUniqueFlags) {
318
let sorted = table;
319
if (isDiff || argv.sort) {
320
const sortChannel = argToHeader(isDiff ? argv.diff[0] : argv.sort);
321
- sorted = Object.fromEntries(
322
- Object.entries(table).sort(([, rowA], [, rowB]) =>
323
- rowB[sortChannel].toString().localeCompare(rowA[sortChannel])
324
- )
325
- );
321
+ const sortBy =
322
+ sortChannel === 'flag'
323
+ ? ([flagA], [flagB]) => {
324
+ return flagA.localeCompare(flagB);
325
+ }
326
+ : ([, rowA], [, rowB]) => {
327
+ return rowB[sortChannel].toString().localeCompare(rowA[sortChannel]);
328
+ };
329
+ sorted = Object.fromEntries(Object.entries(table).sort(sortBy));
330
}
331
332
if (argv.csv) {