@samitouri / QOSAMI-WSL-2 / commits / abce91d1

Spelling (#12954)

* link: Collect WSL logs (recommended method) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Advanced Authoring Tests in C++ Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: CMake Documentation and Community Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Collect WSL logs for networking issues Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Collect WSL logs (recommended method) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: ; otherwise, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: a Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: access Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: accessible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: across Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: actively Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: adapters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: address Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: addresses Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: and Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: appropriate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: argument Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: associated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: attach Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: available Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: beginning Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: between Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: binaries Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: bound Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: buffer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: buffers Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: cannot Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: canonical Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: capabilities Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: case-insensitive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: case-sensitive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: certified Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: command Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: committer Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: communication Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: complains Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: configuration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: consumed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: continue Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: converted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: currently Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: customers Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: daemon Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: deferred Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: definitions Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: delimiter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: delivered Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: dellink Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: derived Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: descriptor Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: destined Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: destruct Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: destructible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: destructor Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: detach Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: differentiate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: directories Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: disassociate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: disposition Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: distribution Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: distro Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: duping Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: emitted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: empty Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: environment Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: every time Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: exclusive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expected Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: expire Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: explicitly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fall back Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: false Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: fastfail Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: filesystem Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: first Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: followed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: functionality Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: functionally Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: github Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: greater Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guarantee Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: guaranteed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: handles Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hangup Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hierarchy Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hogwarts Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: hydrated Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: icrnl Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: implementation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: implementing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: initialize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instance Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instantiate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: instantiations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: intentionally Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interpret Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: interpreter Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: irreversibly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: iteration Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: iterator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: its Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: kernel Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: kmsg Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: knowledge Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: maximum Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: mirrored Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: msftconnecttest Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: multi Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: multiple Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: mutable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: namespace Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: notifications Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: occurred Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: occurring Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: otherwise, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: outstanding Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: overridden Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: partition Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: pass through Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: passthrough Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: performs Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: periodically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: positional Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: precedence Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preexisting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: preferring Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: prepopulate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: previous Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: privileges Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: process Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: processes Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: programmatically Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: protection Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: provided Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: reasonable Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: receive Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: received Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: red hat Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: reentrant Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: registered Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: regularly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: relay Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: release Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: representing Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: requests Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: response Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: resurrect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: retention Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: returned Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: security Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: semaphore Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: separate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: separator Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: service Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: set up Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: setup Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: severely Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: should Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: signal Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: similarly Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: simple Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: simplified Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: single Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: specified Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: splitting Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: standard Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: stress Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: succeed Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: success Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: successfully Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: supplementary Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: synced Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: system Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: take Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: than Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that opening Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: threadpool Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: to Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: true Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: truncate Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: tunneling Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unexpected Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: uninitialize Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unique Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unprivileged Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: unregistered Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: untrusted Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: upgrade Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: utility Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: validating Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: variant Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: variation Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: variations Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: verify Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: visible Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: winget Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: worker Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: written Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: wslservice Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * format source --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Ben Hillis <benhillis@gmail.com> Co-authored-by: Ben Hillis <benhill@ntdev.microsoft.com>

Josh Soref committed Jul 23, 2025 at 18:19 UTC abce91d14bc6ed16943673ddf9984ae2f6e281af
150 files changed +523 -522
.github/policies/resourceManagement.yml
+4 -4
@@ -184,10 +184,10 @@ configuration:
184 The scipt will output the path of the log file once done.
185
186
187 - Once completed please upload the output files to this Github issue.
187 + Once completed please upload the output files to this GitHub issue.
188
189
190 - [Click here](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method) for more info on logging
190 + See [Collect WSL logs (recommended method)](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method).
191
192
193 If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue.
@@ -229,10 +229,10 @@ configuration:
229 The scipt will output the path of the log file once done.
230
231
232 - Once completed please upload the output files to this Github issue.
232 + Once completed please upload the output files to this GitHub issue.
233
234
235 - [Click here](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method) for more info on logging
235 + See [Collect WSL logs (recommended method)](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method).
236
237
238 Thank you!
.github/workflows/winget.yml
+1 -1
@@ -1,4 +1,4 @@
1 -name: Publish to Winget
1 +name: Publish to WinGet
2
3 on:
4 release:
.pipelines/build-stage.yml
+1 -1
@@ -168,7 +168,7 @@ stages:
168 workingDirectory: "."
169 cmakeArgs: . --fresh -A ${{ platform }} -DCMAKE_BUILD_TYPE=Release -DCMAKE_SYSTEM_VERSION=10.0.26100.0 -DPACKAGE_VERSION=$(version.WSL_PACKAGE_VERSION) -DWSL_NUGET_PACKAGE_VERSION=$(version.WSL_NUGET_PACKAGE_VERSION) -DSKIP_PACKAGE_SIGNING=${{ parameters.isRelease }} -DOFFICIAL_BUILD=${{ parameters.isRelease }} -DPIPELINE_BUILD_ID=$(Build.BuildId) -DVSO_ORG=${{ parameters.vsoOrg }} -DVSO_PROJECT=${{ parameters.vsoProject }} -DWSL_BUILD_WSL_SETTINGS=true
170
171 - # This additional Restore NuGet package task is added as a workaround for WSL Settings to have its' packages restored properly.
171 + # This additional Restore NuGet package task is added as a workaround for WSL Settings to have its packages restored properly.
172 # Without this, building wsl settings may encounter the following error:
173 #
174 # The plugin credential provider could not acquire credentials. Authentication may require manual action.
.pipelines/flight-stage.yml
+2 -2
@@ -100,7 +100,7 @@ stages:
100 zipPath: $(StoreBrokerPayloadPath)\WindowsSubsystemForLinux.zip
101 force: true
102 skipPolling: true # skips polling Partner Centre/store API for the state of the package; skipping will mean that errors in the process will only show up in Partner Center
103 - targetPublishMode: Immediate # on completion of this task, the package will be published to the WSL SelfHost flight once ceritified (no manual clicking of any buttons in Partner Center)
103 + targetPublishMode: Immediate # on completion of this task, the package will be published to the WSL SelfHost flight once certified (no manual clicking of any buttons in Partner Center)
104 preserveSubmissionId: false
105 deletePackages: true
106 numberOfPackagesToKeep: 0
@@ -115,6 +115,6 @@ stages:
115 pip install --user -r tools/devops/requirements.txt
116 python tools/devops/create-release.py '${{ parameters.packageVersion }}' drop\bundle\Microsoft.WSL_${{ parameters.packageVersion }}.0_x64_ARM64.msixbundle drop\bundle\wsl.${{ parameters.packageVersion }}.0.arm64.msi drop\bundle\wsl.${{ parameters.packageVersion }}.0.x64.msi --no-fetch --github-token "$env:token" ${{ iif(parameters.publishPackage, '--publish --auto-release-notes', '--use-current-ref') }}
117
118 - displayName: Create Github release
118 + displayName: Create GitHub release
119 env:
120 token: $(GITHUB_RELEASE_TOKEN)
\ No newline at end of file
CONTRIBUTING.md
+2 -2
@@ -19,7 +19,7 @@ You can file issues for WSL at the WSL repository, or linked repositories. Befor
19
20 1. If your issue is related to WSL documentation, please file it at [microsoftdocs/wsl](https://github.com/microsoftdocs/WSL/issues)
21 2. If your issue is related to a Linux GUI app, please file it at [microsoft/wslg](https://github.com/microsoft/wslg/issues)
22 -3. Otherwise if you have a technical issue related to WSL in general, such as start up issues, etc., please file it at [microsoft/wsl](https://github.com/microsoft/WSL/issues)
22 +3. Otherwise, if you have a technical issue related to WSL in general, such as start up issues, etc., please file it at [microsoft/wsl](https://github.com/microsoft/WSL/issues)
23
24 Please provide as much information as possible when reporting a bug or filing an issue on the Windows Subsystem for Linux, and be sure to include logs as necessary!
25
@@ -94,7 +94,7 @@ After reboot, the kernel dump will be in `%SystemRoot%\MEMORY.DMP` (unless this
94 Please send this dump to: secure@microsoft.com .
95 Make sure that the email body contains:
96
97 -- The Github issue number, if any
97 +- The GitHub issue number, if any
98 - That this dump is intended for the WSL team
99
100 ### 11) Reporting a WSL process crash
cloudtest/TestMap.xml.in
+3 -3
@@ -12,21 +12,21 @@
12 <Provider Type="VSODrop">
13 <Properties>
14 <Add Name="CloudTest.ProviderCustomName" Value="[test_distro]" />
15 - <!-- When updating the drops for this make sure the rentention is set to never expire -->
15 + <!-- When updating the drops for this make sure the retention is set to never expire -->
16 <Add Name="DropURL" Value="https://${VSO_ORG}.artifacts.visualstudio.com/_apis/drop/drops/WSL/${CLOUDTEST_TEST_DISTRO_DROP}"/>
17 </Properties>
18 </Provider>
19 <Provider Type="VSODrop">
20 <Properties>
21 <Add Name="CloudTest.ProviderCustomName" Value="[test_packages]" />
22 - <!-- When updating the drops for this make sure the rentention is set to never expire -->
22 + <!-- When updating the drops for this make sure the retention is set to never expire -->
23 <Add Name="DropURL" Value="https://${VSO_ORG}.artifacts.visualstudio.com/_apis/drop/drops/WSL/${CLOUDTEST_TEST_PACKAGES}"/>
24 </Properties>
25 </Provider>
26 <Provider Type="VSODrop">
27 <Properties>
28 <Add Name="CloudTest.ProviderCustomName" Value="[dump_tool]" />
29 - <!-- When updating the drops for this make sure the rentention is set to never expire -->
29 + <!-- When updating the drops for this make sure the retention is set to never expire -->
30 <Add Name="DropURL" Value="https://${VSO_ORG}.artifacts.visualstudio.com/_apis/drop/drops/WSL/${DUMPTOOL_DROP}"/>
31 </Properties>
32 </Provider>
doc/docs/technical-documentation/boot-process.md
+1 -1
@@ -43,7 +43,7 @@ sequenceDiagram
43
44 ## CreateInstance()
45
46 -When [wslervice.exe](wslservice.exe.md) receives the CreateInstance() call via COM, it will:
46 +When [wslservice.exe](wslservice.exe.md) receives the CreateInstance() call via COM, it will:
47
48 1) Identify which distribution the user wants to create. This is done by looking up the `DistributionRegistration` (see `src/windows/service/exe/DistributionRegistration.cpp`) in the Windows registry, matching either on the distribution ID, or using the default if none is provided.
49
doc/docs/technical-documentation/drvfs.md
+2 -2
@@ -14,9 +14,9 @@ When a Linux process is created, [wslservice.exe](wslservice.exe.md) determines
14
15 *Note: This section only applies to WSL2 distributions. *
16
17 -When a [session leader](session-leader.md) is created, [wslsevice.exe](wslservice.exe.md) starts a [plan9](https://9fans.github.io/plan9port/man/man9/intro.html) file server. This file server can be connected to from the WSL2 virtual machine to mount Windows drives.
17 +When a [session leader](session-leader.md) is created, [wslservice.exe](wslservice.exe.md) starts a [plan9](https://9fans.github.io/plan9port/man/man9/intro.html) file server. This file server can be connected to from the WSL2 virtual machine to mount Windows drives.
18
19 -When the WSL distribution is created, [wslservice.exe](wslservice.exe.md) uses the `LX_INIT_CONFIGURATION_INFORMATION` message to indicate wether the process that created the distribution is elevated or not. Based on this, [init](init.md) will mount either or the elevated, or un-elevated version of the plan9 server.
19 +When the WSL distribution is created, [wslservice.exe](wslservice.exe.md) uses the `LX_INIT_CONFIGURATION_INFORMATION` message to indicate whether the process that created the distribution is elevated or not. Based on this, [init](init.md) will mount either or the elevated, or un-elevated version of the plan9 server.
20
21 Later when the first command is created in the namespace that hasn't been mounted yet, (either elevated, or non-elevated), [wslservice.exe](wslservice.exe.md) sends a `LxInitMessageRemountDrvfs` to [init](init.md), which tell `init` to mount the other namespace.
22
doc/docs/technical-documentation/systemd.md
+1 -1
@@ -20,4 +20,4 @@ When systemd is enabled, WSL tries synchronizes launching processes with systemd
20 To improve compatibility with systemd, WSL creates various systemd configuration files during boot (under `/run`). These configurations files are used to:
21
22 - Protect the WSL [binfmt interpret](interop.md) from being deleted by `systemd-binfmt.service`
23 -- Protect the X11 socket from being deleted by `systemd-tmpfiles.serviceè
\ No newline at end of file
23 +- Protect the X11 socket from being deleted by `systemd-tmpfiles-setup.service`
intune/en-US/WSL.adml
+1 -1
@@ -32,7 +32,7 @@
32 <string id="NestedVirtualizationExplain">When set to disabled, this policy disables nested virtualization configuration via .wslconfig (wsl2.nestedVirtualization). This policy only applies to Store WSL.</string>
33
34 <string id="KernelDebugUserSettingConfigurable">Allow kernel debugging</string>
35 - <string id="KernelDebugExplain">When set to disabled, this policy disables kernel kernel debugging configuration via .wslconfig (wsl2.kernelDebugPort). This policy only applies to Store WSL.</string>
35 + <string id="KernelDebugExplain">When set to disabled, this policy disables kernel debugging configuration via .wslconfig (wsl2.kernelDebugPort). This policy only applies to Store WSL.</string>
36
37 <string id="CustomNetworkingUserSettingConfigurable">Allow custom networking configuration</string>
38 <string id="CustomNetworkingExplain">When set to disabled, this policy disables custom networking configuration via .wslconfig (wsl2.networkingmode). This policy only applies to Store WSL.</string>
nuget.config
+1 -1
@@ -21,7 +21,7 @@
21 <add key="WSL" value="https://pkgs.dev.azure.com/shine-oss/wsl/_packaging/WslDependencies/nuget/v3/index.json" />
22 </packageSources>
23 <disabledPackageSources>
24 - <!-- Override any User and Computer NuGet package settings to gurantee
24 + <!-- Override any User and Computer NuGet package settings to guarantee
25 Project only (above sources) are enabled and the only ones present. -->
26 <clear />
27 </disabledPackageSources>
src/linux/init/DnsServer.cpp
+1 -1
@@ -118,7 +118,7 @@ try
118 return;
119 }
120
121 - // Stop tracking the request, irrespective of the DNS response being succesfully sent
121 + // Stop tracking the request, irrespective of the DNS response being successfully sent
122 const auto removeDnsRequest = wil::scope_exit([&] { m_udpRequests.erase(dnsClientIdentifier.DnsClientId); });
123
124 sockaddr_in& remoteAddr = it->second;
src/linux/init/DnsTunnelingChannel.cpp
+1 -1
@@ -103,7 +103,7 @@ void DnsTunnelingChannel::ReceiveLoop() noexcept
103 return;
104 }
105
106 - // Get the message type from the the message header
106 + // Get the message type from the message header
107 switch (message->MessageType)
108 {
109 case LxGnsMessageDnsTunneling:
src/linux/init/GnsEngine.cpp
+1 -1
@@ -53,7 +53,7 @@ Interface GnsEngine::OpenAdapterImpl(const GUID& id)
53 if (adapterId.has_value() && adapterId.value() == id)
54 {
55 interfaceName = e.path().filename().string();
56 - // Special case _wlanxx interfaces: look for the the wlanxx version instead.
56 + // Special case _wlanxx interfaces: look for the wlanxx version instead.
57 if (interfaceName.compare(0, 5, "_wlan") == 0)
58 {
59 continue;
src/linux/init/binfmt.cpp
+1 -1
@@ -785,7 +785,7 @@ Arguments:
785
786 MessageType - Supplies the message type.
787
788 - Argc - Supplies the command line agrument count.
788 + Argc - Supplies the command line argument count.
789
790 Argv - Supplies the command line arguments.
791
src/linux/init/binfmt.h
+2 -2
@@ -15,13 +15,13 @@ Abstract:
15 #pragma once
16
17 //
18 -// Name of the WSL binfmt_misc intrepreter.
18 +// Name of the WSL binfmt_misc interpreter.
19 //
20
21 #define LX_INIT_BINFMT_NAME "WSLInterop"
22
23 //
24 -// Name of the WSL 'late' binfmt_misc intrepreter.
24 +// Name of the WSL 'late' binfmt_misc interpreter.
25 // This name is used by the wsl-binfmt systemd unit which
26 // registers the interpreter a second time after systemd-binfmt to make sure
27 // that wsl's interpreter is always registered last.
src/linux/init/config.cpp
+4 -4
@@ -854,7 +854,7 @@ try
854
855 if (WI_IsFlagSet(Config.FeatureFlags.value(), LxInitFeatureRootfsCompressed))
856 {
857 - LOG_WARNING("{} root file system is compressed, performance may be severly impacted.", DistributionName);
857 + LOG_WARNING("{} root file system is compressed, performance may be severely impacted.", DistributionName);
858 }
859
860 //
@@ -1967,7 +1967,7 @@ try
1967 // Initialize the mount options.
1968 //
1969 // N.B. If the options weren't specified, ConfigDrvFsOptions will be an
1970 - // emptry string. Since DrvFs ignores empty mount options, the extra
1970 + // empty string. Since DrvFs ignores empty mount options, the extra
1971 // comma on the end in that case is not a problem.
1972 //
1973
@@ -2454,7 +2454,7 @@ Arguments:
2454
2455 Return Value:
2456
2457 - The file descriptor represending the mount namespace on soccess, -1 on failure.
2457 + The file descriptor representing the mount namespace on success, -1 on failure.
2458
2459 --*/
2460
@@ -2505,7 +2505,7 @@ try
2505 // Attempt to open the /etc/default/locale file. If the file does not exist
2506 // then the $LANG environment variable will not be updated.
2507 //
2508 - // N.B. This file is being opened by root. The only user-visable content
2508 + // N.B. This file is being opened by root. The only user-visible content
2509 // will be the contents of the last line of the file that contains
2510 // "LANG=".
2511 //
src/linux/init/drvfs.cpp
+2 -2
@@ -258,7 +258,7 @@ try
258 // For virtio-9p, there are two errors that could indicate the PCI device is not ready:
259 // EBUSY - Returned if all devices with the tag are already in use.
260 // ENOENT - Returned if there are no devices with the tag, which can happen after the VM first boots.
261 - // In this case, check if the the target exists; if it doesn't, ENOENT is for that and there's no reason to retry.
261 + // In this case, check if the target exists; if it doesn't, ENOENT is for that and there's no reason to retry.
262 //
263 // For virtiofs, EINVAL will be returned if the tag is not ready.
264 auto savedErrno = wil::ResultFromCaughtException();
@@ -336,7 +336,7 @@ try
336 return MountFilesystem(DRVFS_FS_TYPE, Source, Target, Options, ExitCode);
337 }
338
339 - // Use virtiofs if the source of the mount is the root of a drive, otherwise use 9p.
339 + // Use virtiofs if the source of the mount is the root of a drive; otherwise, use 9p.
340 if (WSL_USE_VIRTIO_FS(Config))
341 {
342 if (wsl::shared::string::IsDriveRoot(Source))
src/linux/init/init.cpp
+6 -6
@@ -356,7 +356,7 @@ ExecStart=/bin/mount -o bind,ro,X-mount.mkdir -t none /mnt/wslg/.X11-unix /tmp/.
356 {
357 // N.B. ExecStop is required to prevent distributions from removing the WSL binfmt entry on shutdown.
358 auto systemdBinfmtContent = std::format(
359 - R"(# Note: This file is generated by WSL to prevent binfmt.d from overriding WSL's binfmt interpretor.
359 + R"(# Note: This file is generated by WSL to prevent binfmt.d from overriding WSL's binfmt interpreter.
360 # To disable this unit, add the following to /etc/wsl.conf:
361 # [boot]
362 # protectBinfmt=false
@@ -1821,7 +1821,7 @@ Return Value:
1821 if (BytesWritten < 0)
1822 {
1823 //
1824 - // If writing on stdin's pipe would block, mark the write as pending an continue.
1824 + // If writing on stdin's pipe would block, mark the write as pending and continue.
1825 // This is required blocking on the write() could lead to a deadlock if the child process
1826 // is blocking trying to write on stderr / stdout while the relay tries to write stdin.
1827 //
@@ -2318,7 +2318,7 @@ Return Value:
2318 }
2319
2320 //
2321 - // Initialize distro init agruments and environment.
2321 + // Initialize distro init arguments and environment.
2322 //
2323
2324 auto InitializeStringVector = [&](std::vector<const char*>& PointerVector,
@@ -2685,7 +2685,7 @@ Routine Description:
2685
2686 Arguments:
2687
2688 - Config - Supplies the distribution configuraiton.
2688 + Config - Supplies the distribution configuration.
2689
2690 Return Value:
2691
@@ -2845,7 +2845,7 @@ Return Value:
2845 //
2846
2847 //
2848 - // N.B. SIGTTOU along with most other signals are blocked, otherwise
2848 + // N.B. SIGTTOU along with most other signals are blocked. Otherwise,
2849 // this could generate a signal with the default behavior of
2850 // stopping the process (waiting for SIGCONT to continue).
2851 //
@@ -3343,7 +3343,7 @@ void WaitForBootProcess(wsl::linux::WslDistributionConfig& Config)
3343 }
3344
3345 //
3346 - // Launch the boot process wait for for it to finish booting.
3346 + // Launch the boot process wait for it to finish booting.
3347 //
3348
3349 MESSAGE_HEADER Message{};
src/linux/init/localhost.cpp
+1 -1
@@ -319,7 +319,7 @@ bool IsSameSockAddr(const sockaddr_storage& left, const sockaddr_storage& right)
319 // Start looking for ports bound to localhost or wildcard.
320 int ScanProcNetTCP(wsl::shared::SocketChannel& channel)
321 {
322 - // Peridocally scan procfs for listening TCP sockets.
322 + // Periodically scan procfs for listening TCP sockets.
323 std::vector<sockaddr_storage> relays{};
324 int result = 0;
325 for (;;)
src/linux/init/main.cpp
+11 -11
@@ -762,7 +762,7 @@ void EnableCrashDumpCollection()
762 return;
763 }
764
765 - // If the first character is a pipe, then the kernel will interperet this path as a command.
765 + // If the first character is a pipe, then the kernel will interpret this path as a command.
766 constexpr auto core_pattern = "|/" LX_INIT_WSL_CAPTURE_CRASH " %t %E %p %s";
767 WriteToFile("/proc/sys/kernel/core_pattern", core_pattern);
768 }
@@ -1745,7 +1745,7 @@ try
1745 };
1746
1747 //
1748 - // Set the communicaiton channel to expected file descriptor value.
1748 + // Set the communication channel to expected file descriptor value.
1749 //
1750
1751 if (SocketFd != LX_INIT_UTILITY_VM_INIT_SOCKET_FD)
@@ -1779,7 +1779,7 @@ try
1779 {
1780 //
1781 // Creating the temporary mount can fail if:
1782 - // - The distro VHD was mounted read-only (because an fsck is needed)
1782 + // - The distro VHD was mounted read-only (because a fsck is needed)
1783 // - The distro VHD is full
1784 //
1785 // Mount a writable overlay if that's the case so the distro can start.
@@ -1873,7 +1873,7 @@ try
1873 }
1874
1875 //
1876 - // Bind mount the init deamon into the distro namespace.
1876 + // Bind mount the init daemon into the distro namespace.
1877 //
1878
1879 auto Path = std::format("{}{}", Target, LX_INIT_PATH);
@@ -2107,7 +2107,7 @@ try
2107 }
2108
2109 //
2110 - // Mount to a temporary location if overlayfs was requested, otherwise mount
2110 + // Mount to a temporary location if overlayfs was requested; otherwise, mount
2111 // the device directly on the target.
2112 //
2113
@@ -2260,7 +2260,7 @@ Return Value:
2260 }
2261
2262 //
2263 - // Chroot to system system distro mount point.
2263 + // Chroot to system distro mount point.
2264 //
2265 // N.B. This allows running binaries present in the system distro without having to chroot.
2266 //
@@ -2362,7 +2362,7 @@ try
2362 auto* DeviceName = &DevicePath[sizeof(DEVFS_PATH)];
2363
2364 //
2365 - // Find the partion on the specified device.
2365 + // Find the partition on the specified device.
2366 //
2367 // N.B. A retry is needed because there is a delay between when a device is
2368 // hot-added, and when the device is available in the guest.
@@ -2492,7 +2492,7 @@ void ProcessLaunchInitMessage(
2492 //
2493 // Allow /etc/wsl.conf in the user distro to opt-out of GUI support.
2494 //
2495 - // N.B. A connection for the system disto must established even if the distro opts out
2495 + // N.B. A connection for the system distro must established even if the distro opts out
2496 // of GUI app support because WslService is waiting to accept a connection.
2497 //
2498
@@ -3168,7 +3168,7 @@ Routine Description:
3168
3169 Arguments:
3170
3171 - MessageFd - Supplies a file desciptor to the socket the message was received
3171 + MessageFd - Supplies a file descriptor to the socket the message was received
3172 on. This is used for operations that require responses, for example a
3173 VHD eject request.
3174
@@ -3579,7 +3579,7 @@ Return Value:
3579 // set to SYS_BIND to make bind system call.
3580 #ifdef __x86_64__
3581 // 32bit:
3582 - // If syscall_nr == __NR_socketcall then contine else goto allow:
3582 + // If syscall_nr == __NR_socketcall then continue else goto allow:
3583 BPF_STMT(BPF_LD + BPF_W + BPF_ABS, syscall_nr),
3584 BPF_JUMP(BPF_JMP + BPF_JEQ + BPF_K, I386_NR_socketcall, 0, 3),
3585 // if syscall arg0 == SYS_BIND then goto user_notify: else goto allow:
@@ -3905,7 +3905,7 @@ int main(int Argc, char* Argv[])
3905 }
3906
3907 //
3908 - // Open kmesg for logging and ensure that the file descriptor is not set to one of the standard file descriptors.
3908 + // Open kmsg for logging and ensure that the file descriptor is not set to one of the standard file descriptors.
3909 //
3910 // N.B. This is to work around a rare race condition where init is launched without /dev/console set as the controlling terminal.
3911 //
src/linux/init/telemetry.cpp
+1 -1
@@ -236,7 +236,7 @@ unsigned int StartTelemetryAgent()
236 }
237 }
238
239 - // Regularily flush messages back to the service.
239 + // Regularly flush messages back to the service.
240
241 auto now = std::chrono::steady_clock::now();
242 if (drvfsNotifyCommand.has_value() || now > nextFlush)
src/linux/init/util.cpp
+6 -6
@@ -733,8 +733,8 @@ Arguments:
733
734 CommandLine - Supplies the command line of the process to launch.
735
736 - Output - Supplies an optional pointer to an std::string to receive the output of the command.
737 - If no buffer is provied the output will appear in stdout.
736 + Output - Supplies an optional pointer to a std::string to receive the output of the command.
737 + If no buffer is provided the output will appear in stdout.
738
739 ExpectedStatus - Supplies the expected return status of the command.
740
@@ -1433,7 +1433,7 @@ Return Value:
1433 //
1434 // Check if the prefix matches.
1435 //
1436 - // N.B. For Windows paths, this is done case insensitive.
1436 + // N.B. For Windows paths, this is done case-insensitive.
1437 //
1438
1439 if (!wsl::shared::string::StartsWith(Path, Prefix, WinPath))
@@ -2894,7 +2894,7 @@ Arguments:
2894 Path - Supplies the path to translate.
2895
2896 Reverse - Supplies a bool, if set perform translation from Windows->Linux
2897 - path, otherwise translation from Linux->Windows path.
2897 + path; otherwise, translation from Linux->Windows path.
2898
2899 Return Value:
2900
@@ -3015,7 +3015,7 @@ Arguments:
3015 Path - Supplies the path to translate.
3016
3017 Reverse - Supplies a bool, if set perform translation from Windows->Linux
3018 - path, otherwise translation from Linux->Windows path.
3018 + path; otherwise, translation from Linux->Windows path.
3019
3020 Return Value:
3021
@@ -3350,7 +3350,7 @@ int ProcessCreateProcessMessage(wsl::shared::SocketChannel& channel, gsl::span<g
3350 }
3351 else if (execResult == sizeof(execResult))
3352 {
3353 - // Otherwise return the error code to the service
3353 + // Otherwise, return the error code to the service
3354 execResult = abs(execResult);
3355 }
3356 else
src/linux/mountutil/mountutilcpp.h
+1 -1
@@ -17,7 +17,7 @@ public:
17 THROW_LAST_ERROR_IF(MountEnumCreateEx(&m_mountEnum, mountInfoFile) < 0);
18 }
19
20 - // Desctruct this instance of the MountEnum class.
20 + // Destruct this instance of the MountEnum class.
21 ~MountEnum()
22 {
23 MountEnumFree(&m_mountEnum);
src/linux/netlinkutil/Interface.cpp
+1 -1
@@ -73,7 +73,7 @@ void Interface::ChangeAddress(const Address& address, const std::optional<Addres
73 }
74 }
75
76 -// TMessage must be drived from AddressMessage or one of its children
76 +// TMessage must be derived from AddressMessage or one of its children
77 template <typename TAddr, typename TMessage>
78 void Interface::ChangeAddressImpl(const Address& address, const std::optional<Address>& broadcastAddress, Operation operation)
79 {
src/linux/netlinkutil/Makefile.linux
+1 -1
@@ -1,4 +1,4 @@
1 -# This makefile is used to work from a linux environement and is not part of the OS build process.
1 +# This makefile is used to work from a linux environment and is not part of the OS build process.
2
3 CXXFLAGS += -std=c++20 -Wall -Wextra -g3 -fPIC -I../inc
4 LDFLAGS +=
src/linux/plan9/expected.h
+4 -4
@@ -30,7 +30,7 @@ namespace details {
30 new (P9_EXPECTED_STD addressof(value)) T(P9_EXPECTED_STD forward<Args>(args)...);
31 }
32
33 - // Storage for the BasicExpected class for types that are trivially destructable.
33 + // Storage for the BasicExpected class for types that are trivially destructible.
34 template <typename T, typename E>
35 struct TrivialExpectedStorage
36 {
@@ -98,7 +98,7 @@ namespace details {
98 return *this;
99 }
100
101 - // Default destructor, because the value type is trivially destructable.
101 + // Default destructor, because the value type is trivially destructible.
102 ~TrivialExpectedStorage() = default;
103
104 bool HasValue;
@@ -111,7 +111,7 @@ namespace details {
111 };
112 };
113
114 - // Storage for the BasicExpected class for types that are not trivially destructable.
114 + // Storage for the BasicExpected class for types that are not trivially destructible.
115 template <typename T, typename E>
116 struct NonTrivialExpectedStorage
117 {
@@ -204,7 +204,7 @@ namespace details {
204 };
205 };
206
207 - // Class that helps to select between the storage for trivially and non-trivially destructable
207 + // Class that helps to select between the storage for trivially and non-trivially destructible
208 // types.
209 template <typename T, typename E>
210 struct ExpectedStorage
src/linux/plan9/p9data.h
+1 -1
@@ -21,7 +21,7 @@ namespace p9fs {
21 // the message if all dynamic content is omitted. In the case of strings, the
22 // size of the two-byte length field is included, but the string length itself
23 // is not. The omitted components are listed with each message type, and the
24 -// caller is responsible for adding the the right values if necessary.
24 +// caller is responsible for adding the right values if necessary.
25 constexpr UINT32 GetMessageSize(MessageType messageType)
26 {
27 switch (messageType)
src/linux/plan9/p9file.h
+1 -1
@@ -18,7 +18,7 @@ struct Root final : public IRoot
18 {
19 Root(std::shared_ptr<const Share> share, int rootFd, uid_t uid, gid_t gid) : Share{share}, RootFd{rootFd}, Uid{uid}, Gid{gid}
20 {
21 - Plan9TraceLoggingProvider::LogMessage(std::format("Instanciate root, uid={}", uid));
21 + Plan9TraceLoggingProvider::LogMessage(std::format("Instantiate root, uid={}", uid));
22 if (uid == -1)
23 {
24 return; // No uid passed, don't try to get the additional groups.
src/linux/plan9/p9fs.cpp
+1 -1
@@ -105,7 +105,7 @@ Expected<std::shared_ptr<const IRoot>> ShareList::MakeRoot(std::string_view anam
105 {
106 // The server is not running as root, which won't work.
107 // N.B. It's possible to make this work as long as the server has CAP_SETUID, but that
108 - // is currrently not needed.
108 + // is currently not needed.
109 return LxError{LX_EPERM};
110 }
111
src/linux/plan9/p9handler.cpp
+1 -1
@@ -1218,7 +1218,7 @@ private:
1218
1219 // Utilize a small stack-allocated buffer that's large enough for the largest response
1220 // without dynamic content (which is Rgetattr). Messages requiring a larger response will
1221 - // allocate a dynamic buffer by calling MessageResonse::EnsureSize.
1221 + // allocate a dynamic buffer by calling MessageResponse::EnsureSize.
1222 // N.B. Message handlers that only return the header (e.g. HandleClunk) don't need to call
1223 // EnsureSize since the static buffer is always big enough for that.
1224 gsl::byte staticBuffer[c_staticBufferSize];
src/linux/plan9/p9io.cpp
+1 -1
@@ -79,7 +79,7 @@ void CoroutineIoIssuer::PostIssue(CoroutineIoOperation& operation, CancelToken&
79 else if (token.Cancelled())
80 {
81 // The IO did not complete synchronously, but the operation has been
82 - // cancelled. Depending on when the cancel occured, the IO may not have
82 + // cancelled. Depending on when the cancel occurred, the IO may not have
83 // been cancelled, so cancel it now.
84 aio_cancel(operation.ControlBlock.aio_fildes, &operation.ControlBlock);
85 }
src/linux/plan9/p9scheduler.cpp
+1 -1
@@ -140,7 +140,7 @@ Scheduler::Unblocker Scheduler::Unblock() noexcept
140 /// Try to claim queue ownership for the current thread. If this function
141 /// returns true, then the caller must call RunAndRelease to process the queue.
142 ///
143 -/// If fromKick, then the caller is the thread that was explictly kicked to
143 +/// If fromKick, then the caller is the thread that was explicitly kicked to
144 /// process the queue. Otherwise, this is an IO completion or other
145 /// opportunistic thread.
146 bool Scheduler::Claim(bool fromKick) noexcept
src/linux/plan9/p9tracelogging.cpp
+1 -1
@@ -271,7 +271,7 @@ void LogMessageBuilder::AddRawValue(UINT64 value, int base)
271 m_message += ConvertNumber(buffer, c_numberBufferSize, value, base);
272 }
273
274 -// Adds an qid value without any separators or prefix.
274 +// Adds a qid value without any separators or prefix.
275 void LogMessageBuilder::AddRawValue(const Qid& value)
276 {
277 m_message += "{";
src/shared/configfile/configfile.cpp
+1 -1
@@ -816,7 +816,7 @@ InvalidLine:
816 {
817 // Write out the rest of the remaining
818 // invalid line. WEOF and '\n' will be
819 - // handled/writen by the NewLine label.
819 + // handled/written by the NewLine label.
820 configFileOutput += ch;
821 }
822 }
src/shared/inc/CommandLine.h
+2 -2
@@ -375,7 +375,7 @@ public:
375 const TChar* value = nullptr;
376 if (e.Positional)
377 {
378 - value = m_argv[i]; // Positonal arguments directly receive arvg[i]
378 + value = m_argv[i]; // Positional arguments directly receive arvg[i]
379 }
380 else if (i + 1 < m_argc)
381 {
@@ -465,7 +465,7 @@ private:
465 }
466 else
467 {
468 - // Otherwise we need an actual value
468 + // Otherwise, we need an actual value
469 if (Value == nullptr)
470 {
471 return -1;
src/shared/inc/conncheckshared.h
+1 -1
@@ -147,7 +147,7 @@ inline unique_socket ConnCheckConnectSocket(int family, const char* hostname, co
147
148 // Attempts to establish a TCPv4 and a TCPv6 connection to a port on a host.
149 // ipv6hostname is an optional parameter in case the IPv6 equivalent hostname is different.
150 -// example: www.msftconnectest.com and ipv6.msftconnectest.com
150 +// example: www.msftconnecttest.com and ipv6.msftconnecttest.com
151 // This API is blocking/synchronous.
152 inline ConnCheckResult CheckConnection(const char* hostname, const char* ipv6hostname, const char* port)
153 {
src/shared/inc/lxinitshared.h
+3 -3
@@ -76,7 +76,7 @@ Abstract:
76 #define LX_INIT_DEFAULT_ROUTE_V6_PREFIX LX_INIT_UNSPECIFIED_V6_ADDRESS "/0"
77
78 //
79 -// The hard-coded link-local addressess used for communicating over the loopback to the host
79 +// The hard-coded link-local addresses used for communicating over the loopback to the host
80 //
81 #define LX_INIT_IPV4_LOOPBACK_GATEWAY_ADDRESS "169.254.73.152"
82 #define LX_INIT_IPV6_LOOPBACK_GATEWAY_ADDRESS "fe80::500:4aef:feef:2aa2"
@@ -155,7 +155,7 @@ Abstract:
155 //
156 // Typical default DrvFs-specific 9p mount options.
157 //
158 -// N.B. These are used to pre-populate virtiofs shares with default mount options.
158 +// N.B. These are used to prepopulate virtiofs shares with default mount options.
159 // These will match the default values used by the system distro, and will typically
160 // match the default uid / gid for the user distro. If the values do not match, a new
161 // virtiofs share will be created.
@@ -176,7 +176,7 @@ Abstract:
176 #define LX_INIT_HVSOCKET_TIMEOUT_SECONDS (30)
177
178 //
179 -// The data for begining a port listener.
179 +// The data for beginning a port listener.
180 //
181
182 #define LX_INIT_LOCALHOST_RELAY "localhost"
src/shared/inc/stringshared.h
+11 -11
@@ -713,7 +713,7 @@ inline MacAddress ParseMacAddress(const std::basic_string<T>& Input, T Separator
713 }
714
715 template <typename TChar>
716 -inline std::basic_string<TChar> FormatMacAddress(const MacAddress& input, TChar seperator)
716 +inline std::basic_string<TChar> FormatMacAddress(const MacAddress& input, TChar separator)
717 {
718 std::basic_string<TChar> output(17, '\0');
719
@@ -724,15 +724,15 @@ inline std::basic_string<TChar> FormatMacAddress(const MacAddress& input, TChar
724 output.size() + 1,
725 MAC_ADDRESS_FORMAT_STRING,
726 input[0],
727 - seperator,
727 + separator,
728 input[1],
729 - seperator,
729 + separator,
730 input[2],
731 - seperator,
731 + separator,
732 input[3],
733 - seperator,
733 + separator,
734 input[4],
735 - seperator,
735 + separator,
736 input[5]);
737 }
738 else if constexpr (std::is_same_v<TChar, wchar_t>)
@@ -742,15 +742,15 @@ inline std::basic_string<TChar> FormatMacAddress(const MacAddress& input, TChar
742 output.size() + 1,
743 STRING_TO_WIDE_STRING(MAC_ADDRESS_FORMAT_STRING),
744 input[0],
745 - seperator,
745 + separator,
746 input[1],
747 - seperator,
747 + separator,
748 input[2],
749 - seperator,
749 + separator,
750 input[3],
751 - seperator,
751 + separator,
752 input[4],
753 - seperator,
753 + separator,
754 input[5]);
755 }
756 else
src/windows/common/Distribution.cpp
+1 -1
@@ -141,7 +141,7 @@ DistributionList ReadFromManifest(const std::wstring& url)
141 }
142 }
143
144 - // The "Default" string takes precendence. If not present, use the first legacy distro entry.
144 + // The "Default" string takes precedence. If not present, use the first legacy distro entry.
145 if (!distros.Default.has_value() && distros.Distributions.has_value() && distros.Distributions->size() > 0)
146 {
147 distros.Default = (*distros.Distributions)[0].Name;
src/windows/common/ExecutionContext.h
+1 -1
@@ -64,7 +64,7 @@ enum Context : ULONGLONG
64 Install = 0x4000000000,
65 ReadDistroConfig = 0x8000000000,
66 UpdatePackage = 0x10000000000,
67 - QueryLatestGithubRelease = 0x20000000000,
67 + QueryLatestGitHubRelease = 0x20000000000,
68 VerifyChecksum = 0x40000000000,
69 };
70
src/windows/common/Localization.cpp
+1 -1
@@ -45,7 +45,7 @@ std::vector<std::wstring> GetUserLanguages(bool impersonate)
45 {
46 if (g_runningInService)
47 {
48 - // N.B. If we're in the service the locale needs to be queried everytime since different users
48 + // N.B. If we're in the service the locale needs to be queried every time since different users
49 // can have different language configurations.
50 std::optional<wil::unique_coreverttoself_call> revert;
51 if (impersonate)
src/windows/common/SubProcess.cpp
+1 -1
@@ -166,7 +166,7 @@ wil::unique_handle SubProcess::Start()
166 StartupInfo.StartupInfo.cb = sizeof(StartupInfo);
167 StartupInfo.StartupInfo.dwFlags = STARTF_USESTDHANDLES;
168
169 - // N.B. Passing a pseudoconsole requires all standard handlles to be null
169 + // N.B. Passing a pseudoconsole requires all standard handles to be null
170 if (m_pseudoConsole == nullptr)
171 {
172 StartupInfo.StartupInfo.hStdInput = ARGUMENT_PRESENT(m_stdIn) ? m_stdIn : GetStdHandle(STD_INPUT_HANDLE);
src/windows/common/WslClient.cpp
+3 -3
@@ -630,7 +630,7 @@ int Install(_In_ std::wstring_view commandLine)
630
631 if (legacyDistro != nullptr)
632 {
633 - wsl::windows::common::distribution::Launch(*legacyDistro, installResult.InstalledViaGithub, !installResult.Alreadyinstalled);
633 + wsl::windows::common::distribution::Launch(*legacyDistro, installResult.InstalledViaGitHub, !installResult.Alreadyinstalled);
634 }
635 else
636 {
@@ -1076,7 +1076,7 @@ LaunchProcessOptions ParseLegacyArguments(_Inout_ std::wstring_view& commandLine
1076 // Strip any leading whitespace.
1077 commandLine = wsl::windows::common::string::StripLeadingWhitespace(commandLine);
1078
1079 - // Check for a distributon GUID as the first parameter and strip it out if present.
1079 + // Check for a distribution GUID as the first parameter and strip it out if present.
1080 auto argument = wsl::windows::common::helpers::ParseArgument(commandLine);
1081 auto distroGuid = wsl::shared::string::ToGuid(argument);
1082 if (distroGuid.has_value())
@@ -1523,7 +1523,7 @@ int RunDebugShell()
1523 // a pipe is connected, so it's lost.
1524 THROW_IF_WIN32_BOOL_FALSE(WriteFile(pipe.get(), "\n", 1, nullptr, nullptr));
1525
1526 - // Create a thread to realy stdin to the pipe.
1526 + // Create a thread to relay stdin to the pipe.
1527 wsl::windows::common::SvcCommIo Io;
1528 auto exitEvent = wil::unique_event(wil::EventOptions::ManualReset);
1529 std::thread inputThread(
src/windows/common/WslCoreConfig.cpp
+2 -2
@@ -314,10 +314,10 @@ void wsl::core::Config::Initialize(_In_opt_ HANDLE UserToken)
314 MemorySizeBytes = std::min<UINT64>(MemorySizeBytes, MaximumMemorySizeBytes);
315 }
316
317 - // Use the user-defined swap size if one was specified, otherwise set to 25%
317 + // Use the user-defined swap size if one was specified; otherwise, set to 25%
318 // the memory size rounded up to the nearest GB.
319 //
320 - // N.B. This heuristic is modeled after RedHat and Ubuntu's recommended swap size.
320 + // N.B. This heuristic is modeled after Red Hat and Ubuntu's recommended swap size.
321 if (SwapSizeBytes == UINT64_MAX)
322 {
323 SwapSizeBytes = ((MemorySizeBytes / 4 + _1GB - 1) & ~(_1GB - 1));
src/windows/common/WslCoreFirewallSupport.cpp
+1 -1
@@ -175,7 +175,7 @@ try
175 //
176 // Currently, there are 3 possible levels of Hyper-V firewall OS support:
177 // 1 - No Hyper-V firewall OS support.
178 - // 2 - Initial Hyper-V firewall support (Support for mirrrored mode only).
178 + // 2 - Initial Hyper-V firewall support (Support for mirrored mode only).
179 // To check for this support, we query for the 'MSFT_NetFirewallHyperVVMCreator' object.
180 // 3 - Enterprise Hyper-V firewall support (Support for NAT mode, configuring default settings values, and configuring per-profile configs).
181 // To check for this support, we query for the 'MSFT_NetFirewallHyperVProfile' object.
src/windows/common/WslCoreNetworkingSupport.h
+2 -2
@@ -73,7 +73,7 @@ inline bool operator<(const SOCKADDR_INET& lhs, const SOCKADDR_INET& rhs) noexce
73 return lhs.Ipv4.sin_addr.S_un.S_addr < rhs.Ipv4.sin_addr.S_un.S_addr;
74 }
75
76 - // implmenting the comparison operation following the shortcut from mstcpip.h IN6_ADDR_EQUAL
76 + // implementing the comparison operation following the shortcut from mstcpip.h IN6_ADDR_EQUAL
77 const __int64 UNALIGNED* lhsRawPointer = (__int64 UNALIGNED*)(&lhs.Ipv6.sin6_addr);
78 const __int64 UNALIGNED* rhsRawPointer = (__int64 UNALIGNED*)(&rhs.Ipv6.sin6_addr);
79 if (lhsRawPointer[0] == rhsRawPointer[0])
@@ -94,7 +94,7 @@ inline bool operator>(const SOCKADDR_INET& lhs, const SOCKADDR_INET& rhs) noexce
94 return lhs.Ipv4.sin_addr.S_un.S_addr > rhs.Ipv4.sin_addr.S_un.S_addr;
95 }
96
97 - // implmenting the comparison operation following the shortcut from mstcpip.h IN6_ADDR_EQUAL
97 + // implementing the comparison operation following the shortcut from mstcpip.h IN6_ADDR_EQUAL
98 const __int64 UNALIGNED* lhsRawPointer = (__int64 UNALIGNED*)(&lhs.Ipv6.sin6_addr);
99 const __int64 UNALIGNED* rhsRawPointer = (__int64 UNALIGNED*)(&rhs.Ipv6.sin6_addr);
100 if (lhsRawPointer[0] == rhsRawPointer[0])
src/windows/common/WslInstall.cpp
+2 -2
@@ -145,7 +145,7 @@ try
145 std::tie(installResult.Name, installResult.Id) =
146 InstallModernDistribution(*distro, version, localName, location, vhdSize, fixedVhd);
147
148 - installResult.InstalledViaGithub = true;
148 + installResult.InstalledViaGitHub = true;
149 }
150 else if (const auto* distro = std::get_if<Distribution>(&*installResult.Distribution))
151 {
@@ -193,7 +193,7 @@ try
193 }
194
195 installResult.Name = distro->FriendlyName;
196 - installResult.InstalledViaGithub = useGitHub;
196 + installResult.InstalledViaGitHub = useGitHub;
197 }
198 else
199 {
src/windows/common/WslInstall.h
+1 -1
@@ -24,7 +24,7 @@ public:
24 std::wstring Name;
25 std::optional<GUID> Id;
26 std::optional<wsl::windows::common::distribution::TDistribution> Distribution;
27 - bool InstalledViaGithub{};
27 + bool InstalledViaGitHub{};
28 bool Alreadyinstalled{};
29 };
30
src/windows/common/WslSecurity.cpp
+1 -1
@@ -46,7 +46,7 @@ void wsl::windows::common::security::ApplyProcessMitigationPolicies()
46 LOG_IF_WIN32_BOOL_FALSE(SetProcessMitigationPolicy(ProcessDynamicCodePolicy, &codePolicy, sizeof(codePolicy)));
47
48 // Note: Enabling PROCESS_MITIGATION_SYSTEM_CALL_DISABLE_POLICY::DisallowWin32kSystemCalls
49 - // breaks the service initialization logic (CoIntializeSecurity fails).
49 + // breaks the service initialization logic (CoInitializeSecurity fails).
50
51 PROCESS_MITIGATION_FONT_DISABLE_POLICY fontPolicy{};
52 fontPolicy.DisableNonSystemFonts = true;
src/windows/common/filesystem.cpp
+8 -8
@@ -213,7 +213,7 @@ revert_dir_case_sensitivity EnableNtfsDirCaseSensitivity()
213
214 //
215 // Just in case, make sure at least the main enable flag is set after
216 - // reverting, otherwise WSL will break.
216 + // reverting; otherwise, WSL will break.
217 //
218
219 WI_SetFlag(Flags, c_enableDirCaseSensitivity);
@@ -326,7 +326,7 @@ void EnsureCaseSensitiveDirectoryRecursive(_In_ HANDLE Directory)
326 }
327
328 //
329 - // After all children are processed, mark the directory case sensitive.
329 + // After all children are processed, mark the directory case-sensitive.
330 //
331 // N.B. This is done with a retry because if the NtfsEnableDirCaseSensitivity
332 // flag was just changed from 3 to 1, NTFS may not have updated its
@@ -562,7 +562,7 @@ void wsl::windows::common::filesystem::CreateRootFs(_In_ PCWSTR Path, _In_ ULONG
562 }
563
564 //
565 - // Make sure the directory is marked case sensitive.
565 + // Make sure the directory is marked case-sensitive.
566 //
567 // N.B. This is done without impersonating the client because setting this
568 // attribute requires the "delete subfolders and files" permission on
@@ -649,7 +649,7 @@ std::pair<ULONG, ULONG> wsl::windows::common::filesystem::EnumerateFixedDrives(H
649
650 void wsl::windows::common::filesystem::EnsureCaseSensitiveDirectory(_In_ PCWSTR Path, _In_ ULONG Flags)
651 {
652 - // N.B. Passing SYNCHRONIZE and FILE_SYNCHRONOUS_IO_NONALERT is required, otherwise NtQueryDirectoryFile
652 + // N.B. Passing SYNCHRONIZE and FILE_SYNCHRONOUS_IO_NONALERT is required; otherwise, NtQueryDirectoryFile
653 // might return STATUS_PENDING, which would break our folder enumeration logic.
654
655 const wil::unique_hfile Directory{CreateFileW(
@@ -753,8 +753,8 @@ void wsl::windows::common::filesystem::EnsureDirectoryWithAttributes(
753 SetExtendedAttributes(Path, LX_S_IFDIR | Mode, Uid, Gid, DistroVersion);
754
755 //
756 - // Mark a new directory case sensitive, or upgrade the entire tree if it
757 - // exists. If the root is already case sensitive, it's assumed the entire
756 + // Mark a new directory case-sensitive, or upgrade the entire tree if it
757 + // exists. If the root is already case-sensitive, it's assumed the entire
758 // tree is.
759 //
760
@@ -804,7 +804,7 @@ std::pair<std::string, std::string> wsl::windows::common::filesystem::GetHostAnd
804 WI_VERIFY(GetComputerNameExA(ComputerNameDnsDomain, nullptr, &size) == FALSE);
805
806 // If there is no domain name, initialize with a default. Truncate the
807 - // domain name to the max size that the the driver allows.
807 + // domain name to the max size that the driver allows.
808 // N.B. If the buffer is too small, GetComputerNameEx() sets 'size' to the string size,
809 // ** including ** the null terminator. On success it returns the string size,
810 // See: https://learn.microsoft.com/en-us/windows/win32/api/sysinfoapi/nf-sysinfoapi-getcomputernameexa
@@ -909,7 +909,7 @@ std::string wsl::windows::common::filesystem::GetWindowsHosts(const std::filesys
909 std::string LineCopy = Line;
910
911 // Each line is in the following format:
912 - // <host-adress> <host-alias1> <host-alias2> ...
912 + // <host-address> <host-alias1> <host-alias2> ...
913 //
914 // N.B. There must be at least one host aliases for each host address.
915
src/windows/common/filesystem.hpp
+2 -2
@@ -36,7 +36,7 @@ DEFINE_ENUM_FLAG_OPERATORS(TempFileFlags);
36 // Used only in unit tests.
37 constexpr ULONG c_case_sensitive_folders_only = 0x100;
38
39 -// Make sure that the above flag doesn't conflict with create intance flags
39 +// Make sure that the above flag doesn't conflict with create instance flags
40 static_assert((LXSS_CREATE_INSTANCE_FLAGS_ALL & c_case_sensitive_folders_only) == 0);
41
42 struct TempFile
@@ -124,7 +124,7 @@ std::pair<ULONG, ULONG> EnumerateFixedDrives(HANDLE Token = nullptr);
124 bool EnsureDirectory(_In_ LPCWSTR pPath);
125
126 /// <summary>
127 -/// Marks every directory in a tree case sensitive.
127 +/// Marks every directory in a tree case-sensitive.
128 /// </summary>
129 void EnsureCaseSensitiveDirectory(_In_ PCWSTR Path, _In_ ULONG Flags);
130
src/windows/common/interop.cpp
+1 -1
@@ -348,7 +348,7 @@ std::string FormatCommandLine(gsl::span<gsl::byte> CommandLineData, USHORT Comma
348 //
349 // N.B. Any empty arguments or arguments that contain whitespace must be
350 // encapsulated in quotes. Quotes must also be escaped according to
351 - // stardard command-line parsing rules:
351 + // standard command-line parsing rules:
352 // https://msdn.microsoft.com/en-us/library/17w5ykft.aspx.
353 //
354 // This logic is largely taken from AppendQuotedForWindows in
src/windows/common/lxssbusclient.cpp
+4 -4
@@ -392,7 +392,7 @@ Arguments:
392
393 BufferSize - Supplies the size of the buffer in bytes.
394
395 - SizeReceieved - Supplies a buffer to store the number of bytes received.
395 + SizeReceived - Supplies a buffer to store the number of bytes received.
396
397 Return Value:
398
@@ -469,7 +469,7 @@ Arguments:
469
470 BufferSize - Supplies the size of the buffer in bytes.
471
472 - SizeReceieved - Supplies a buffer to store the number of bytes received.
472 + SizeReceived - Supplies a buffer to store the number of bytes received.
473
474 IoStatus - Supplies a pointer to an io status block.
475
@@ -754,7 +754,7 @@ LxBusClientWaitForConnection(_In_ HANDLE ServerPortHandle, _Out_ PLXBUS_IPC_SERV
754
755 Routine Description:
756
757 - Waits for for a client connection on the provided server port.
757 + Waits for a client connection on the provided server port.
758
759 Arguments:
760
@@ -780,7 +780,7 @@ LxBusClientWaitForLxProcess(_In_ HANDLE LxProcessHandle, _Out_ PLXBUS_IPC_LX_PRO
780
781 Routine Description:
782
783 - Waits for for a client connection on the provided server port.
783 + Waits for a client connection on the provided server port.
784
785 Arguments:
786
src/windows/common/svccomm.cpp
+5 -5
@@ -552,14 +552,14 @@ wsl::windows::common::SvcComm::SvcComm()
552 THROW_IF_FAILED(m_userSession->QueryInterface(IID_PPV_ARGS(&clientSecurity)));
553
554 // Get the current proxy blanket settings.
555 - DWORD authnSvc, authzSvc, authnLvl, capabilites;
556 - THROW_IF_FAILED(clientSecurity->QueryBlanket(m_userSession.get(), &authnSvc, &authzSvc, NULL, &authnLvl, NULL, NULL, &capabilites));
555 + DWORD authnSvc, authzSvc, authnLvl, capabilities;
556 + THROW_IF_FAILED(clientSecurity->QueryBlanket(m_userSession.get(), &authnSvc, &authzSvc, NULL, &authnLvl, NULL, NULL, &capabilities));
557
558 // Make sure that dynamic cloaking is used.
559 - WI_ClearFlag(capabilites, EOAC_STATIC_CLOAKING);
560 - WI_SetFlag(capabilites, EOAC_DYNAMIC_CLOAKING);
559 + WI_ClearFlag(capabilities, EOAC_STATIC_CLOAKING);
560 + WI_SetFlag(capabilities, EOAC_DYNAMIC_CLOAKING);
561 THROW_IF_FAILED(clientSecurity->SetBlanket(
562 - m_userSession.get(), authnSvc, authzSvc, NULL, authnLvl, RPC_C_IMP_LEVEL_IMPERSONATE, NULL, capabilites));
562 + m_userSession.get(), authnSvc, authzSvc, NULL, authnLvl, RPC_C_IMP_LEVEL_IMPERSONATE, NULL, capabilities));
563 }
564
565 wsl::windows::common::SvcComm::~SvcComm()
src/windows/common/wslutil.cpp
+18 -18
@@ -31,7 +31,7 @@ using namespace wsl::windows::common::wslutil;
31 constexpr auto c_latestReleaseUrl = L"https://api.github.com/repos/Microsoft/WSL/releases/latest";
32 constexpr auto c_releaseListUrl = L"https://api.github.com/repos/Microsoft/WSL/releases";
33 constexpr auto c_specificReleaseListUrl = L"https://api.github.com/repos/Microsoft/WSL/releases/tags/";
34 -constexpr auto c_userAgent = L"wsl-install"; // required to use the Github API
34 +constexpr auto c_userAgent = L"wsl-install"; // required to use the GitHub API
35 constexpr auto c_pipePrefix = L"\\\\.\\pipe\\";
36
37 namespace {
@@ -171,7 +171,7 @@ static const std::map<Context, LPCWSTR> g_contextStrings{
171 X(UnregisterDistro),
172 X(RegisterLxBus),
173 X(MountDisk),
174 - X(QueryLatestGithubRelease),
174 + X(QueryLatestGitHubRelease),
175 X(DebugShell),
176 X(Plugin),
177 X(CallMsi),
@@ -255,7 +255,7 @@ int UpdatePackageImpl(bool preRelease, bool repair)
255 PrintMessage(Localization::MessageCheckingForUpdates());
256 }
257
258 - auto [version, release] = GetLatestGithubRelease(preRelease);
258 + auto [version, release] = GetLatestGitHubRelease(preRelease);
259
260 if (!repair && ParseWslPackageVersion(version) <= wsl::shared::PackageVersion)
261 {
@@ -825,7 +825,7 @@ std::wstring wsl::windows::common::wslutil::GetErrorString(HRESULT result)
825
826 return Localization::MessageOsNotSupported(helpers::GetWindowsVersionString().c_str(), kbUrl.c_str());
827
828 - // All the errors below this comment are not supposed to be reachable here (since there's meant to be emmited from the
828 + // All the errors below this comment are not supposed to be reachable here (since there's meant to be emitted from the
829 // service). But if we somehow hit them here, it's better show something useful to the user.
830 case WSL_E_VM_MODE_MOUNT_NAME_ALREADY_EXISTS:
831 return Localization::MessageDiskMountNameAlreadyExists();
@@ -899,7 +899,7 @@ std::wstring wsl::windows::common::wslutil::GetErrorString(HRESULT result)
899 return GetSystemErrorString(result);
900 }
901
902 -std::optional<std::pair<std::wstring, GithubReleaseAsset>> wsl::windows::common::wslutil::GetGithubAssetFromRelease(const GithubRelease& Release)
902 +std::optional<std::pair<std::wstring, GitHubReleaseAsset>> wsl::windows::common::wslutil::GetGitHubAssetFromRelease(const GitHubRelease& Release)
903 {
904 auto findAsset = [&Release](LPCWSTR Suffix) {
905 for (const auto& asset : Release.assets)
@@ -913,7 +913,7 @@ std::optional<std::pair<std::wstring, GithubReleaseAsset>> wsl::windows::common:
913 }
914 }
915
916 - return std::optional<std::pair<std::wstring, GithubReleaseAsset>>();
916 + return std::optional<std::pair<std::wstring, GitHubReleaseAsset>>();
917 };
918
919 // Look for an MSI package first
@@ -929,31 +929,31 @@ std::optional<std::pair<std::wstring, GithubReleaseAsset>> wsl::windows::common:
929 return asset.value();
930 }
931
932 -std::pair<std::wstring, GithubReleaseAsset> wsl::windows::common::wslutil::GetLatestGithubRelease(bool preRelease)
932 +std::pair<std::wstring, GitHubReleaseAsset> wsl::windows::common::wslutil::GetLatestGitHubRelease(bool preRelease)
933 {
934 - ExecutionContext context(Context::QueryLatestGithubRelease);
934 + ExecutionContext context(Context::QueryLatestGitHubRelease);
935
936 auto registryKey = registry::OpenLxssMachineKey();
937 const auto url =
938 registry::ReadString(registryKey.get(), nullptr, c_githubUrlOverrideRegistryValue, preRelease ? c_releaseListUrl : c_latestReleaseUrl);
939 - WSL_LOG("PollLatestGithubRelease", TraceLoggingValue(url.c_str(), "url"));
939 + WSL_LOG("PollLatestGitHubRelease", TraceLoggingValue(url.c_str(), "url"));
940
941 winrt::Windows::Web::Http::HttpClient client;
942 client.DefaultRequestHeaders().Append(L"User-Agent", c_userAgent);
943 const auto response = client.GetAsync(winrt::Windows::Foundation::Uri(url)).get();
944 response.EnsureSuccessStatusCode();
945
946 - return GetLatestGithubRelease(preRelease, response.Content().ReadAsStringAsync().get().c_str());
946 + return GetLatestGitHubRelease(preRelease, response.Content().ReadAsStringAsync().get().c_str());
947 }
948
949 -std::pair<std::wstring, GithubReleaseAsset> wsl::windows::common::wslutil::GetLatestGithubRelease(bool preRelease, LPCWSTR releases)
949 +std::pair<std::wstring, GitHubReleaseAsset> wsl::windows::common::wslutil::GetLatestGitHubRelease(bool preRelease, LPCWSTR releases)
950 {
951 - std::optional<GithubRelease> parsed{};
951 + std::optional<GitHubRelease> parsed{};
952
953 if (preRelease)
954 {
955 std::optional<std::tuple<uint32_t, uint32_t, uint32_t>> highestVersion;
956 - for (const auto& e : wsl::shared::FromJson<std::vector<GithubRelease>>(releases))
956 + for (const auto& e : wsl::shared::FromJson<std::vector<GitHubRelease>>(releases))
957 {
958 auto version = ParseWslPackageVersion(e.name);
959 if (!highestVersion.has_value() || version > highestVersion)
@@ -965,21 +965,21 @@ std::pair<std::wstring, GithubReleaseAsset> wsl::windows::common::wslutil::GetLa
965 }
966 else
967 {
968 - parsed = wsl::shared::FromJson<GithubRelease>(releases);
968 + parsed = wsl::shared::FromJson<GitHubRelease>(releases);
969 }
970
971 THROW_HR_IF(E_UNEXPECTED, !parsed.has_value());
972
973 // Find the latest release with an msix package asset
974 - auto asset = GetGithubAssetFromRelease(parsed.value());
974 + auto asset = GetGitHubAssetFromRelease(parsed.value());
975 THROW_HR_IF_MSG(E_UNEXPECTED, !asset.has_value(), "No suitable WSL release found on github");
976
977 return asset.value();
978 }
979
980 -GithubRelease wsl::windows::common::wslutil::GetGithubReleaseByTag(_In_ const std::wstring& inTag)
980 +GitHubRelease wsl::windows::common::wslutil::GetGitHubReleaseByTag(_In_ const std::wstring& inTag)
981 {
982 - ExecutionContext context(Context::QueryLatestGithubRelease);
982 + ExecutionContext context(Context::QueryLatestGitHubRelease);
983
984 const winrt::Windows::Web::Http::HttpClient client;
985 client.DefaultRequestHeaders().Append(L"User-Agent", c_userAgent);
@@ -989,7 +989,7 @@ GithubRelease wsl::windows::common::wslutil::GetGithubReleaseByTag(_In_ const st
989
990 const auto content = response.Content().ReadAsStringAsync().get();
991
992 - return wsl::shared::FromJson<GithubRelease>(content.c_str());
992 + return wsl::shared::FromJson<GitHubRelease>(content.c_str());
993 }
994
995 int wsl::windows::common::wslutil::GetLogicalProcessorCount()
src/windows/common/wslutil.h
+10 -10
@@ -41,26 +41,26 @@ inline constexpr GUID WslTerminalNamespace = {0xbe9372fe, 0x59e1, 0x4876, {0xbd,
41 inline constexpr GUID GeneratedProfilesTerminalNamespace = {0x2bde4a90, 0xd05f, 0x401c, {0x94, 0x92, 0xe4, 0x8, 0x84, 0xea, 0xd1, 0xd8}};
42
43 inline auto c_msixPackageFamilyName = L"MicrosoftCorporationII.WindowsSubsystemForLinux_8wekyb3d8bbwe";
44 -inline auto c_githubUrlOverrideRegistryValue = L"GithubUrlOverride";
44 +inline auto c_githubUrlOverrideRegistryValue = L"GitHubUrlOverride";
45 inline auto c_vhdFileExtension = L".vhd";
46 inline auto c_vhdxFileExtension = L".vhdx";
47
48 -struct GithubReleaseAsset
48 +struct GitHubReleaseAsset
49 {
50 std::wstring url;
51 uint64_t id{};
52 std::wstring name;
53
54 - NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(GithubReleaseAsset, url, id, name);
54 + NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(GitHubReleaseAsset, url, id, name);
55 };
56
57 -struct GithubRelease
57 +struct GitHubRelease
58 {
59 std::wstring name;
60 - std::vector<GithubReleaseAsset> assets;
60 + std::vector<GitHubReleaseAsset> assets;
61 std::wstring created_at;
62
63 - NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(GithubRelease, name, assets, created_at);
63 + NLOHMANN_DEFINE_TYPE_INTRUSIVE_WITH_DEFAULT(GitHubRelease, name, assets, created_at);
64 };
65
66 template <typename T>
@@ -98,13 +98,13 @@ DWORD GetDefaultVersion(void);
98
99 std::wstring GetErrorString(_In_ HRESULT result);
100
101 -std::optional<std::pair<std::wstring, GithubReleaseAsset>> GetGithubAssetFromRelease(const GithubRelease& Release);
101 +std::optional<std::pair<std::wstring, GitHubReleaseAsset>> GetGitHubAssetFromRelease(const GitHubRelease& Release);
102
103 -std::pair<std::wstring, GithubReleaseAsset> GetLatestGithubRelease(_In_ bool preRelease);
103 +std::pair<std::wstring, GitHubReleaseAsset> GetLatestGitHubRelease(_In_ bool preRelease);
104
105 -std::pair<std::wstring, GithubReleaseAsset> GetLatestGithubRelease(_In_ bool preRelease, _In_ LPCWSTR releases);
105 +std::pair<std::wstring, GitHubReleaseAsset> GetLatestGitHubRelease(_In_ bool preRelease, _In_ LPCWSTR releases);
106
107 -GithubRelease GetGithubReleaseByTag(_In_ const std::wstring& Version);
107 +GitHubRelease GetGitHubReleaseByTag(_In_ const std::wstring& Version);
108
109 int GetLogicalProcessorCount();
110
src/windows/inc/WmiService.h
+32 -32
@@ -448,7 +448,7 @@ public:
448 }
449
450 // Invokes an instance method with zero -> 5 arguments from the instantiated IWbemClassObject
451 - // Returns a WmiInstace containing the [out] parameters from the method call
451 + // Returns a WmiInstance containing the [out] parameters from the method call
452 // (the property "ReturnValue" contains the return value)
453 WmiInstance execute_method(PCWSTR method)
454 {
@@ -468,11 +468,11 @@ public:
468
469 // Instantiate a class object to iterate through each property
470 const WmiClassObject propertyObject(m_wbemServices, inParamsDefinition);
471 - auto propertyItererator = propertyObject.property_begin();
471 + auto propertyIterator = propertyObject.property_begin();
472
473 // write the property
474 WmiInstance propertyclassObject(m_wbemServices, inParamsInstance);
475 - propertyclassObject.set(*propertyItererator, arg1);
475 + propertyclassObject.set(*propertyIterator, arg1);
476
477 // execute the method with the properties set
478 return execute_method_impl(method, inParamsInstance.get());
@@ -491,13 +491,13 @@ public:
491
492 // Instantiate a class object to iterate through each property
493 const WmiClassObject propertyObject(m_wbemServices, inParamsDefinition);
494 - auto propertyItererator = propertyObject.property_begin();
494 + auto propertyIterator = propertyObject.property_begin();
495
496 // write each property
497 WmiInstance propertyclassObject(m_wbemServices, inParamsInstance);
498 - propertyclassObject.set(*propertyItererator, arg1);
499 - ++propertyItererator;
500 - propertyclassObject.set(*propertyItererator, arg2);
498 + propertyclassObject.set(*propertyIterator, arg1);
499 + ++propertyIterator;
500 + propertyclassObject.set(*propertyIterator, arg2);
501
502 // execute the method with the properties set
503 return execute_method_impl(method, inParamsInstance.get());
@@ -516,15 +516,15 @@ public:
516
517 // Instantiate a class object to iterate through each property
518 const WmiClassObject propertyObject(m_wbemServices, inParamsDefinition);
519 - auto propertyItererator = propertyObject.property_begin();
519 + auto propertyIterator = propertyObject.property_begin();
520
521 // write each property
522 WmiInstance propertyclassObject(m_wbemServices, inParamsInstance);
523 - propertyclassObject.set(*propertyItererator, arg1);
524 - ++propertyItererator;
525 - propertyclassObject.set(*propertyItererator, arg2);
526 - ++propertyItererator;
527 - propertyclassObject.set(*propertyItererator, arg3);
523 + propertyclassObject.set(*propertyIterator, arg1);
524 + ++propertyIterator;
525 + propertyclassObject.set(*propertyIterator, arg2);
526 + ++propertyIterator;
527 + propertyclassObject.set(*propertyIterator, arg3);
528
529 // execute the method with the properties set
530 return execute_method_impl(method, inParamsInstance.get());
@@ -543,17 +543,17 @@ public:
543
544 // Instantiate a class object to iterate through each property
545 const WmiClassObject propertyObject(m_wbemServices, inParamsDefinition);
546 - auto propertyItererator = propertyObject.property_begin();
546 + auto propertyIterator = propertyObject.property_begin();
547
548 // write each property
549 WmiInstance propertyclassObject(m_wbemServices, inParamsInstance);
550 - propertyclassObject.set(*propertyItererator, arg1);
551 - ++propertyItererator;
552 - propertyclassObject.set(*propertyItererator, arg2);
553 - ++propertyItererator;
554 - propertyclassObject.set(*propertyItererator, arg3);
555 - ++propertyItererator;
556 - propertyclassObject.set(*propertyItererator, arg4);
550 + propertyclassObject.set(*propertyIterator, arg1);
551 + ++propertyIterator;
552 + propertyclassObject.set(*propertyIterator, arg2);
553 + ++propertyIterator;
554 + propertyclassObject.set(*propertyIterator, arg3);
555 + ++propertyIterator;
556 + propertyclassObject.set(*propertyIterator, arg4);
557
558 // execute the method with the properties set
559 return execute_method_impl(method, inParamsInstance.get());
@@ -572,20 +572,20 @@ public:
572
573 // Instantiate a class object to iterate through each property
574 const WmiClassObject propertyObject(m_wbemServices, inParamsDefinition);
575 - auto propertyItererator = propertyObject.property_begin();
575 + auto propertyIterator = propertyObject.property_begin();
576
577 // write each property
578 //
579 WmiInstance propertyclassObject(m_wbemServices, inParamsInstance);
580 - propertyclassObject.set(*propertyItererator, arg1);
581 - ++propertyItererator;
582 - propertyclassObject.set(*propertyItererator, arg2);
583 - ++propertyItererator;
584 - propertyclassObject.set(*propertyItererator, arg3);
585 - ++propertyItererator;
586 - propertyclassObject.set(*propertyItererator, arg4);
587 - ++propertyItererator;
588 - propertyclassObject.set(*propertyItererator, arg5);
580 + propertyclassObject.set(*propertyIterator, arg1);
581 + ++propertyIterator;
582 + propertyclassObject.set(*propertyIterator, arg2);
583 + ++propertyIterator;
584 + propertyclassObject.set(*propertyIterator, arg3);
585 + ++propertyIterator;
586 + propertyclassObject.set(*propertyIterator, arg4);
587 + ++propertyIterator;
588 + propertyclassObject.set(*propertyIterator, arg5);
589
590 // execute the method with the properties set
591 return execute_method_impl(method, inParamsInstance.get());
@@ -807,7 +807,7 @@ public:
807
808 private:
809 WmiService m_wbemServices;
810 - // Marking wbemEnumerator mutabale to allow for const correctness of begin() and end()
810 + // Marking wbemEnumerator mutable to allow for const correctness of begin() and end()
811 // specifically, invoking Reset() is an implementation detail and should not affect external contracts
812 mutable wil::com_ptr<IEnumWbemClassObject> m_wbemEnumerator;
813 };
src/windows/inc/WmiVariant.h
+2 -2
@@ -479,7 +479,7 @@ inline bool WmiReadFromVariant(_In_ const VARIANT* variant, _Inout_ std::vector<
479
480 inline wil::unique_variant WmiMakeVariant(const std::vector<unsigned short>& data)
481 {
482 - // WMI marshaler complaines type mismatch using VT_UI2 | VT_ARRAY, and VT_I4 | VT_ARRAY works fine.
482 + // WMI marshaler complains type mismatch using VT_UI2 | VT_ARRAY, and VT_I4 | VT_ARRAY works fine.
483 auto* const tempSafeArray = SafeArrayCreateVector(VT_I4, 0, static_cast<ULONG>(data.size()));
484 THROW_IF_NULL_ALLOC(tempSafeArray);
485 auto guardArray = wil::scope_exit([&]() noexcept { SafeArrayDestroy(tempSafeArray); });
@@ -506,7 +506,7 @@ inline wil::unique_variant WmiMakeVariant(const std::vector<unsigned short>& dat
506
507 inline bool WmiReadFromVariant(_In_ const VARIANT* variant, _Inout_ std::vector<unsigned short>* value)
508 {
509 - // WMI marshaler complaines type mismatch using VT_UI2 | VT_ARRAY, and VT_I4 | VT_ARRAY works fine.
509 + // WMI marshaler complains type mismatch using VT_UI2 | VT_ARRAY, and VT_I4 | VT_ARRAY works fine.
510 if (IsVariantEmptyOrNull(variant))
511 {
512 return false;
src/windows/inc/WslCoreConfigInterface.h
+1 -1
@@ -34,7 +34,7 @@ enum WslConfigEntry
34 AutoProxyEnabled,
35 InitialAutoProxyTimeout,
36 DNSProxyEnabled,
37 - DNSTunellingEnabled,
37 + DNSTunnelingEnabled,
38 BestEffortDNSParsingEnabled,
39 AutoMemoryReclaim,
40 GUIApplicationsEnabled,
src/windows/inc/WslPluginApi.h
+3 -3
@@ -67,7 +67,7 @@ struct WSLSessionInformation
67
68 struct WSLDistributionInformation
69 {
70 - GUID Id; // Distribution ID, guaranteed to be the same accross reboots
70 + GUID Id; // Distribution ID, guaranteed to be the same across reboots
71 LPCWSTR Name;
72 uint64_t PidNamespace;
73 LPCWSTR PackageFamilyName; // Package family name, or NULL if none
@@ -78,7 +78,7 @@ struct WSLDistributionInformation
78
79 struct WslOfflineDistributionInformation
80 {
81 - GUID Id; // Distribution ID, guaranteed to be the same accross reboots
81 + GUID Id; // Distribution ID, guaranteed to be the same across reboots
82 LPCWSTR Name;
83 LPCWSTR PackageFamilyName; // Package family name, or NULL if none
84 LPCWSTR Flavor; // Type of distribution (ubuntu, debian, ...). Introduced in 2.4.4
@@ -120,7 +120,7 @@ typedef HRESULT (*WSLPluginAPI_OnDistributionStarted)(const struct WSLSessionInf
120 // In this case, it's possible for this notification to be called multiple times for the same distribution.
121 typedef HRESULT (*WSLPluginAPI_OnDistributionStopping)(const struct WSLSessionInformation* Session, const struct WSLDistributionInformation* Distribution);
122
123 -// Called when a distribution is registered or unregisteed.
123 +// Called when a distribution is registered or unregistered.
124 // Returning failure will NOT cause the operation to fail.
125 typedef HRESULT (*WSLPluginAPI_OnDistributionRegistered)(const struct WSLSessionInformation* Session, const struct WslOfflineDistributionInformation* Distribution);
126
src/windows/inc/comservicehelper.h
+4 -4
@@ -59,7 +59,7 @@ namespace Windows { namespace Internal {
59 }
60 else
61 {
62 - // Otherwise take a reference on the MTA apartment.
62 + // Otherwise, take a reference on the MTA apartment.
63 m_hrMtaInitialized = CoIncrementMTAUsage(&m_mtaUsageCookie);
64 }
65 RETURN_IF_FAILED(m_hrMtaInitialized);
@@ -277,7 +277,7 @@ namespace Windows { namespace Internal {
277 RETURN_IF_WIN32_BOOL_FALSE(MakeAbsoluteSD(
278 pSDRelative, pSDAbsolute, &cbSDAbsolute, pDacl, &cbDacl, pSacl, &cbSacl, pOwner, &cbOwner, pPrimaryGroup, &cbPrimaryGroup));
279
280 - // ...and now we can call CoInitializeSecuirity
280 + // ...and now we can call CoInitializeSecurity
281 RETURN_IF_FAILED(CoInitializeSecurity(
282 pSDAbsolute, -1, nullptr, nullptr, RPC_C_AUTHN_LEVEL_DEFAULT, RPC_C_IMP_LEVEL_IDENTIFY, NULL, EOAC_NONE, nullptr));
283
@@ -296,7 +296,7 @@ namespace Windows { namespace Internal {
296 // COM callback object to support unloading shared-process services
297 Microsoft::WRL::ComPtr<IContextCallback> m_icc;
298
299 - // COM Server descritptor
299 + // COM Server descriptor
300 ServerDescriptor m_serverDescriptor{};
301 };
302
@@ -644,7 +644,7 @@ namespace Windows { namespace Internal {
644 // control codes to the service.
645 //
646 // We stop asynchronously to have the same codepath as system
647 - // stop requestes.
647 + // stop requests.
648 //
649 reinterpret_cast<TBase*>(this)->OnSystemShutdown();
650 StopAsync();
src/windows/inc/wslversioninfo.h
+1 -1
@@ -8,7 +8,7 @@ Module Name:
8
9 Abstract:
10
11 - This file contains version definitions for WSL binairies.
11 + This file contains version definitions for WSL binaries.
12
13 --*/
14
src/windows/libwsl/WslCoreConfigInterface.cpp
+3 -3
@@ -113,7 +113,7 @@ WslConfigSetting GetWslConfigSetting(WslConfig_t wslConfig, WslConfigEntry wslCo
113 case IgnoredPorts:
114 {
115 // The IgnoredPorts member is stored as a set of 16-bit unsigned integers.
116 - // These are convereted back to a string here for the caller to consume.
116 + // These are converted back to a string here for the caller to consume.
117 wslConfig->IgnoredPortsStr.clear();
118 std::vector<uint16_t> ignoredPorts{wslConfig->Config.IgnoredPorts.begin(), wslConfig->Config.IgnoredPorts.end()};
119 std::sort(ignoredPorts.begin(), ignoredPorts.end());
@@ -144,7 +144,7 @@ WslConfigSetting GetWslConfigSetting(WslConfig_t wslConfig, WslConfigEntry wslCo
144 static_assert(std::is_same<decltype(wslConfigSetting.BoolValue), decltype(wslConfig->Config.EnableDnsProxy)>::value);
145 wslConfigSetting.BoolValue = wslConfig->Config.EnableDnsProxy;
146 break;
147 - case DNSTunellingEnabled:
147 + case DNSTunnelingEnabled:
148 static_assert(std::is_same<decltype(wslConfigSetting.BoolValue), decltype(wslConfig->Config.EnableDnsTunneling)>::value);
149 wslConfigSetting.BoolValue = wslConfig->Config.EnableDnsTunneling;
150 break;
@@ -451,7 +451,7 @@ unsigned long SetWslConfigSetting(WslConfig_t wslConfig, WslConfigSetting wslCon
451 case DNSProxyEnabled:
452 return SetWslConfigSetting(
453 wslConfig, ConfigSetting::DnsProxy, defaultConfig.EnableDnsProxy, wslConfigSetting.BoolValue, wslConfig->Config.EnableDnsProxy);
454 - case DNSTunellingEnabled:
454 + case DNSTunnelingEnabled:
455 {
456 static_assert(std::is_same<decltype(wslConfigSetting.BoolValue), decltype(wslConfig->Config.EnableDnsTunneling)>::value);
457 ConfigKey key({ConfigSetting::DnsTunneling, ConfigSetting::Experimental::DnsTunneling}, wslConfigSetting.BoolValue);
src/windows/service/exe/DistributionRegistration.h
+1 -1
@@ -105,7 +105,7 @@ namespace Property {
105 inline DistributionPropertyWithDefault<DWORD> RunOOBE{L"RunOOBE", 0};
106 inline DistributionPropertyWithDefault<DWORD> Modern{L"Modern", 0};
107
108 - inline DistributionPropertyWithDefault<std::vector<std::string>> DefaultEnvironmnent{
108 + inline DistributionPropertyWithDefault<std::vector<std::string>> DefaultEnvironment{
109 L"DefaultEnvironment",
110 {"HOSTTYPE=x86_64",
111 "LANG=en_US.UTF-8",
src/windows/service/exe/DnsResolver.cpp
+1 -1
@@ -179,7 +179,7 @@ try
179
180 m_dnsChannel.Stop();
181
182 - // Stop interface change notificaions
182 + // Stop interface change notifications
183 m_interfaceNotificationHandle.reset();
184
185 GenerateTelemetry();
src/windows/service/exe/LxssCreateProcess.cpp
+2 -2
@@ -104,7 +104,7 @@ CreateLxProcessData LxssCreateProcess::ParseArguments(
104 return Parsed;
105 }
106
107 -// static function defintions
107 +// static function definitions
108 std::vector<gsl::byte> LxssCreateProcess::CreateMessage(_In_ LX_MESSAGE_TYPE MessageType, _In_ const CreateLxProcessData& CreateProcessData, _In_ ULONG DefaultUid)
109 {
110 //
@@ -226,7 +226,7 @@ std::vector<gsl::byte> LxssCreateProcess::CreateMessage(_In_ LX_MESSAGE_TYPE Mes
226 Common->CurrentWorkingDirectoryOffset = wsl::shared::string::CopyToSpan(CreateProcessData.CurrentWorkingDirectory, CommonSpan, Offset);
227
228 //
229 - // Populate the CommmandLine strings.
229 + // Populate the CommandLine strings.
230 //
231
232 WI_ASSERT(CreateProcessData.CommandLine.size() <= USHORT_MAX);
src/windows/service/exe/LxssHttpProxy.cpp
+2 -2
@@ -266,7 +266,7 @@ try
266 else
267 {
268 // note that the DropReason is not included in AreProxyStringsIdentical as we don't want to toast if that is only change,
269 - // but we still want to make sure the drop reason is updated, otherwise we risk not reporting the correct drop reason to user
269 + // but we still want to make sure the drop reason is updated; otherwise, we risk not reporting the correct drop reason to user
270 if (newProxySettings.UnsupportedProxyDropReason != m_proxySettings->UnsupportedProxyDropReason)
271 {
272 m_proxySettings->UnsupportedProxyDropReason = newProxySettings.UnsupportedProxyDropReason;
@@ -552,7 +552,7 @@ std::optional<HttpProxySettings> HttpProxyStateTracker::WaitForInitialProxySetti
552 void HttpProxyStateTracker::ConfigureNetworkingMode(wsl::core::NetworkingMode mode) noexcept
553 {
554 auto lock = m_proxySettingsLock.lock();
555 - // if we fallback to NAT mode need to strip bad settings
555 + // if we fall back to NAT mode need to strip bad settings
556 if (m_proxySettings.has_value() && mode != m_networkMode)
557 {
558 FilterProxySettingsByNetworkConfiguration(m_proxySettings.value(), mode);
src/windows/service/exe/LxssHttpProxy.h
+2 -2
@@ -138,7 +138,7 @@ public:
138
139 /// <summary>
140 /// If no proxy queries have completed, wait for timeout for result.
141 - /// Otherwise return the proxy settings.
141 + /// Otherwise, return the proxy settings.
142 /// </summary>
143 std::optional<HttpProxySettings> WaitForInitialProxySettings();
144
@@ -199,7 +199,7 @@ private:
199 QueryState m_queryState{QueryState::NoQuery};
200
201 /// <summary>
202 - /// Used to impersonate user, as it is required for the proxy queries to run as the user, otherwise the results will be incorrect.
202 + /// Used to impersonate user, as it is required for the proxy queries to run as the user; otherwise, the results will be incorrect.
203 /// </summary>
204 wil::unique_handle m_userToken{};
205
src/windows/service/exe/LxssInstance.cpp
+2 -2
@@ -442,7 +442,7 @@ void LxssInstance::_ConfigureFilesystem(_In_ ULONG Flags)
442 // Part of this process will try to upgrade existing LxFs folders to
443 // enable the per-directory case sensitivity flag. To allow easy detection
444 // of already processed folders, and resumption in case the process is
445 - // interrupted, directories are only marked case sensitive after their
445 + // interrupted, directories are only marked case-sensitive after their
446 // children are processed.
447 //
448 // Paths for LXSS instances look like so:
@@ -474,7 +474,7 @@ void LxssInstance::_ConfigureFilesystem(_In_ ULONG Flags)
474 ensureDirectoryWithAttributes(LXSS_ROOTFS_DIRECTORY, LXSS_ROOTFS_PERMISSIONS);
475
476 // If this is the legacy distribution, ensure that the additional LxFs
477 - // directories exist and have the correct attributes. Otherwise ensure that
477 + // directories exist and have the correct attributes. Otherwise, ensure that
478 // the rootfs/mnt directory exists for DrvFs mounts.
479 switch (m_configuration.Version)
480 {
src/windows/service/exe/LxssInstance.h
+1 -1
@@ -112,7 +112,7 @@ public:
112
113 /// <summary>
114 /// Registers connection targets with the Plan 9 Redirector for the calling user, if they're
115 - /// not already regsistered.
115 + /// not already registered.
116 /// </summary>
117 void RegisterPlan9ConnectionTarget(_In_ HANDLE userToken) override;
118
src/windows/service/exe/LxssIpTables.h
+2 -2
@@ -118,7 +118,7 @@ class LxssNetworkingFirewallPort;
118 class LxssNetworkingNat;
119
120 /// <summary>
121 -/// Emulate iptables functionailty.
121 +/// Emulate iptables functionality.
122 /// </summary>
123 class LxssIpTables
124 {
@@ -298,7 +298,7 @@ public:
298 LxssNetworkingFirewallPort(const std::shared_ptr<LxssNetworkingFirewall>& Firewall, const Microsoft::WRL::ComPtr<INetFwRule>& Existing);
299
300 /// <summary>
301 - /// Desstructor.
301 + /// Destructor.
302 /// </summary>
303 ~LxssNetworkingFirewallPort();
304
src/windows/service/exe/LxssUserCallback.cpp
+1 -1
@@ -27,7 +27,7 @@ LxssUserCallback::LxssUserCallback(_In_ HANDLE Handle, _In_ LXBUS_USER_CALLBACK_
27 // Allocate a buffer of the requested size.
28 m_buffer.resize(OutputBufferSize);
29
30 - // Setup the threapool wait callback.
30 + // Set up the threadpool wait callback.
31 PTP_WAIT_CALLBACK ThreadpoolCallback;
32 ThreadpoolCallback = reinterpret_cast<PTP_WAIT_CALLBACK>(&ThreadpoolCallbackProxy);
33
src/windows/service/exe/LxssUserCallback.h
+1 -1
@@ -109,7 +109,7 @@ private:
109 // N.B. Keep this as the last member so that it is the first to be
110 // destructed. This will ensure that if the threadpool callback
111 // races with instance destruction, all of the fields will be valid.
112 - // At completion of this member's destruction, any oustanding
112 + // At completion of this member's destruction, any outstanding
113 // threadpool thread should have completed and the callback
114 // will have been unregistered.
115 wil::unique_threadpool_wait m_threadpoolWait;
src/windows/service/exe/LxssUserSession.cpp
+16 -16
@@ -719,7 +719,7 @@ try
719 E_INVALIDARG,
720 ((DefaultUid == LX_UID_INVALID) || (Flags != LXSS_DISTRO_FLAGS_UNCHANGED && WI_IsAnyFlagSet(Flags, ~LXSS_DISTRO_FLAGS_ALL))));
721
722 - // If the configuration is changed, terminate the distribuiton so the new settings will take effect.
722 + // If the configuration is changed, terminate the distribution so the new settings will take effect.
723 bool modified = false;
724 if (DefaultUid != distribution.Read(Property::DefaultUid))
725 {
@@ -946,7 +946,7 @@ HRESULT LxssUserSessionImpl::MoveDistribution(_In_ LPCGUID DistroGuid, _In_ LPCW
946 THROW_IF_WIN32_BOOL_FALSE(MoveFileEx(
947 newVhdPath.c_str(), distro.VhdFilePath.c_str(), MOVEFILE_COPY_ALLOWED | MOVEFILE_REPLACE_EXISTING | MOVEFILE_WRITE_THROUGH));
948
949 - // Write the location back to the original path in case the second registry write failed. Otherwise this is a no-op.
949 + // Write the location back to the original path in case the second registry write failed. Otherwise, this is a no-op.
950 registration.Write(Property::BasePath, distro.BasePath.c_str());
951 });
952
@@ -1186,7 +1186,7 @@ try
1186 *Version = configuration.Version;
1187 *DefaultUid = registration.Read(Property::DefaultUid);
1188 *Flags = configuration.Flags;
1189 - const auto defaultEnvironment = registration.Read(Property::DefaultEnvironmnent);
1189 + const auto defaultEnvironment = registration.Read(Property::DefaultEnvironment);
1190 *DefaultEnvironmentCount = gsl::narrow_cast<ULONG>(defaultEnvironment.size());
1191 auto environment(wil::make_unique_cotaskmem<LPSTR[]>(defaultEnvironment.size()));
1192 for (size_t index = 0; index < defaultEnvironment.size(); index += 1)
@@ -1379,12 +1379,12 @@ HRESULT LxssUserSessionImpl::RegisterDistribution(
1379
1380 // Determine the filesystem version. If WslFs is not enabled, downgrade
1381 // the version.
1382 - ULONG FilesytemVersion = LXSS_DISTRO_VERSION_CURRENT;
1382 + ULONG FilesystemVersion = LXSS_DISTRO_VERSION_CURRENT;
1383 if (wsl::windows::common::registry::ReadDword(lxssKey.get(), nullptr, WSL_NEW_DISTRO_LXFS, 0) != 0)
1384 {
1385 - if (LXSS_DISTRO_USES_WSL_FS(FilesytemVersion) != FALSE)
1385 + if (LXSS_DISTRO_USES_WSL_FS(FilesystemVersion) != FALSE)
1386 {
1387 - FilesytemVersion = LXSS_DISTRO_VERSION_1;
1387 + FilesystemVersion = LXSS_DISTRO_VERSION_1;
1388 }
1389 }
1390
@@ -1452,7 +1452,7 @@ HRESULT LxssUserSessionImpl::RegisterDistribution(
1452 lxssKey.get(),
1453 DistributionId,
1454 DistributionName,
1455 - FilesytemVersion,
1455 + FilesystemVersion,
1456 distributionPath.c_str(),
1457 flags,
1458 LX_UID_ROOT,
@@ -1571,7 +1571,7 @@ HRESULT LxssUserSessionImpl::RegisterDistribution(
1571 THROW_HR_IF(WSL_E_IMPORT_FAILED, exitStatus != 0);
1572 }
1573
1574 - // Invoke the init binary with the option to export the distribuiton information via stdout.
1574 + // Invoke the init binary with the option to export the distribution information via stdout.
1575 {
1576 std::pair<wil::unique_handle, wil::unique_handle> input;
1577 THROW_IF_WIN32_BOOL_FALSE(CreatePipe(&input.first, &input.second, nullptr, 0));
@@ -1929,7 +1929,7 @@ HRESULT LxssUserSessionImpl::SetVersion(_In_ LPCGUID DistroGuid, _In_ ULONG Vers
1929 commandLine += " -v";
1930 }
1931
1932 - // Run the bsdtar elf binary expand the the tar file using the socket as stdin.
1932 + // Run the bsdtar elf binary expand the tar file using the socket as stdin.
1933 commandLine += " -C " LXSS_ROOTFS_MOUNT LXSS_BSDTAR_EXTRACT_ARGS;
1934 auto elfContext = _RunElfBinary(
1935 commandLine.c_str(),
@@ -2097,7 +2097,7 @@ HRESULT LxssUserSessionImpl::Shutdown(_In_ bool PreventNewInstances, bool ForceT
2097 WI_ASSERT(!PreventNewInstances || !m_disableNewInstanceCreation);
2098
2099 // This is used when the session is being deleted.
2100 - // This is in place to prevent a CreateInstace() call from succeeding
2100 + // This is in place to prevent a CreateInstance() call from succeeding
2101 // after the session is shut down since this would mean that the destructor,
2102 // which could run on that thread (if the session already dropped its LxssUserSessionImpl reference)
2103 // would have to do all the cleanup work.
@@ -2566,7 +2566,7 @@ std::shared_ptr<LxssRunningInstance> LxssUserSessionImpl::_CreateInstance(_In_op
2566 if (instance->GetIdleTimeout() >= 0)
2567 {
2568 // Register a client termination callback with the lifetime manager. If the
2569 - // ignore client callback flag is specifed and there are no other clients,
2569 + // ignore client callback flag is specified and there are no other clients,
2570 // the timer is immediately queued.
2571 wil::unique_handle currentProcess{};
2572 if (WI_IsFlagClear(Flags, LXSS_CREATE_INSTANCE_FLAGS_IGNORE_CLIENT))
@@ -2766,7 +2766,7 @@ void LxssUserSessionImpl::_CreateVm()
2766
2767 m_vmId.store(vmId);
2768
2769 - // Create the utiliy VM and register for callbacks.
2769 + // Create the utility VM and register for callbacks.
2770 m_utilityVm = WslCoreVm::Create(m_userToken, std::move(config), vmId);
2771
2772 m_utilityVm->GetRuntimeId();
@@ -3661,8 +3661,8 @@ bool LxssUserSessionImpl::_ValidateDistro(_In_ HKEY LxssKey, _In_ LPCGUID Distro
3661 void LxssUserSessionImpl::_ValidateDistributionNameAndPathNotInUse(
3662 _In_ HKEY LxssKey, _In_opt_ LPCWSTR Path, _In_opt_ LPCWSTR Name, const std::optional<GUID>& Exclude)
3663 {
3664 - // Use the cannonical path to compare distribution registration paths.
3665 - // The cannonical path allows us to compare paths regardless of symlinks.
3664 + // Use the canonical path to compare distribution registration paths.
3665 + // The canonical path allows us to compare paths regardless of symlinks.
3666 //
3667 // Even with this, it's theoretically possible to use different drive mounts to have two paths
3668 // that will point to the same underlying folder. To catch this, we'd need to use BY_HANDLE_FILE_INFORMATION and compare file & volume indexes.
@@ -3939,12 +3939,12 @@ CreateLxProcessContext LxssUserSessionImpl::s_GetCreateProcessContext(_In_ const
3939 const auto registration = DistributionRegistration::Open(lxssKey.get(), DistroGuid);
3940
3941 context.Flags = registration.Read(Property::Flags);
3942 - context.DefaultEnvironment = registration.Read(Property::DefaultEnvironmnent);
3942 + context.DefaultEnvironment = registration.Read(Property::DefaultEnvironment);
3943 }
3944 else
3945 {
3946 context.Flags = DistributionRegistration::ApplyGlobalFlagsOverride(LXSS_DISTRO_FLAGS_DEFAULT | LXSS_DISTRO_FLAGS_VM_MODE);
3947 - context.DefaultEnvironment = Property::DefaultEnvironmnent.DefaultValue;
3947 + context.DefaultEnvironment = Property::DefaultEnvironment.DefaultValue;
3948 }
3949
3950 context.UserToken = wsl::windows::common::security::GetUserToken(TokenImpersonation);
src/windows/service/exe/LxssUserSession.h
+5 -5
@@ -199,12 +199,12 @@ public:
199 IFACEMETHOD(SetVersion)(_In_ LPCGUID DistroGuid, _In_ ULONG Version, _In_ HANDLE StdErrHandle, _Out_ LXSS_ERROR_INFO* Error) override;
200
201 /// <summary>
202 - /// Passtrough a disk to the utility VM.
202 + /// Pass through a disk to the utility VM.
203 /// </summary>
204 IFACEMETHOD(AttachDisk)(_In_ LPCWSTR Disk, _In_ ULONG Flags, _Out_ LXSS_ERROR_INFO* Error) override;
205
206 /// <summary>
207 - /// Detach a passtrough disk from the utility VM.
207 + /// Detach a passthrough disk from the utility VM.
208 /// </summary>
209 IFACEMETHOD(DetachDisk)(_In_ LPCWSTR Disk, _Out_ int* Result, _Out_ int* Step, _Out_ LXSS_ERROR_INFO* Error) override;
210
@@ -479,12 +479,12 @@ public:
479 SetVersion(_In_ LPCGUID DistroGuid, _In_ ULONG Version, _In_ HANDLE StdErrHandle);
480
481 /// <summary>
482 - /// Passtrough a disk to the utility VM.
482 + /// Pass through a disk to the utility VM.
483 /// </summary>
484 HRESULT AttachDisk(_In_ LPCWSTR Disk, _In_ ULONG Flags);
485
486 /// <summary>
487 - /// Detach a passtrough a disk from the utility VM.
487 + /// Detach a passthrough a disk from the utility VM.
488 /// </summary>
489 HRESULT DetachDisk(_In_ LPCWSTR Disk, _Out_ int* Result, _Out_ int* Step);
490
@@ -755,7 +755,7 @@ private:
755 static wil::unique_hkey s_OpenLxssUserKey();
756
757 /// <summary>
758 - /// Ensures the distribuiton name is valid.
758 + /// Ensures the distribution name is valid.
759 /// </summary>
760 static void s_ValidateDistroName(_In_ LPCWSTR Name);
761
src/windows/service/exe/LxssUserSessionFactory.cpp
+1 -1
@@ -67,7 +67,7 @@ void ClearSessionsAndBlockNewInstances()
67 auto sessionsLock = g_sessionLock.lock_exclusive();
68 sessions = std::move(g_sessions);
69
70 - // This is required because the moved-from std::optional<T> isn't made empty, so this needs to be done explicitely.
70 + // This is required because the moved-from std::optional<T> isn't made empty, so this needs to be done explicitly.
71 g_sessions.reset();
72 }
73
src/windows/service/exe/NatNetworking.cpp
+2 -2
@@ -21,8 +21,8 @@ using wsl::windows::common::hcs::unique_hcn_endpoint;
21
22 // This static list is used to keep of which endpoints are in use by other users.
23 // It's needed because when we see an endpoint with the same ip address we want,
24 -// we have no way to differenciate between an endpoint that we previously used
25 -// that didn't get deleted, and an endpoint acitvely in use by another user.
24 +// we have no way to differentiate between an endpoint that we previously used
25 +// that didn't get deleted, and an endpoint actively in use by another user.
26 static wil::srwlock g_endpointsInUseLock;
27 static std::vector<GUID> g_endpointsInUse;
28
src/windows/service/exe/RingBuffer.cpp
+1 -1
@@ -101,7 +101,7 @@ std::vector<std::string> RingBuffer::GetLastDelimitedStrings(char Delimiter, siz
101 {
102 if (!partial.empty())
103 {
104 - // The debug CRT will fasttail if begin[size] is accessed
104 + // The debug CRT will fastfail if begin[size] is accessed
105 // But in this case it's not a problem because begin.size() - i would be == 0
106 std::string partial_begin{&begin.data()[i], begin.size() - i};
107 results.emplace(results.begin(), partial_begin + partial);
src/windows/service/exe/ServiceMain.cpp
+3 -3
@@ -253,7 +253,7 @@ void WslService::ServiceStopped()
253 // Tear down telemetry.
254 WslTraceLoggingUninitialize();
255
256 - // unitialize COM. This must be done here because this call can cause cleanups that will be fail
256 + // uninitialize COM. This must be done here because this call can cause cleanups that will be fail
257 // if the CRT is shutting down.
258 m_coInit.reset();
259 }
@@ -285,7 +285,7 @@ CATCH_LOG()
285 void WslService::CheckForUpdates(_Inout_ PTP_CALLBACK_INSTANCE, _Inout_ PVOID Context, _Inout_ PTP_TIMER)
286 try
287 {
288 - auto [version, _] = GetLatestGithubRelease(false);
288 + auto [version, _] = GetLatestGitHubRelease(false);
289 if (ParseWslPackageVersion(version) > ParseWslPackageVersion(TEXT(WSL_PACKAGE_VERSION)))
290 {
291 WSL_LOG("WSL Package update is available", TraceLoggingLevel(WINEVENT_LEVEL_INFO));
@@ -294,7 +294,7 @@ try
294 SetThreadpoolTimer(static_cast<WslService*>(Context)->m_updateCheckTimer.get(), nullptr, 0, 0);
295
296 // Get current release date
297 - std::wstring currentReleaseCreatedAtDate = GetGithubReleaseByTag(TEXT(WSL_PACKAGE_VERSION)).created_at;
297 + std::wstring currentReleaseCreatedAtDate = GetGitHubReleaseByTag(TEXT(WSL_PACKAGE_VERSION)).created_at;
298
299 std::tm tm = {};
300 std::wstring dateTimeFormat = L"%Y-%m-%dT%H:%M:%SZ";
src/windows/service/exe/WslCoreGuestNetworkService.cpp
+1 -1
@@ -109,7 +109,7 @@ std::pair<uint16_t, uint16_t> wsl::core::networking::GuestNetworkService::Alloca
109 }
110 });
111
112 - // N.B. Use an odd number of ports to avoid Linux kernel warning about prefering different parity for start / end values.
112 + // N.B. Use an odd number of ports to avoid Linux kernel warning about preferring different parity for start / end values.
113 static constexpr auto c_ephemeralPortRangeSize = 4095;
114 THROW_IF_FAILED(m_allocatePortRange.value()(m_service.get(), c_ephemeralPortRangeSize, &m_reservedPortRange, &port));
115
src/windows/service/exe/WslCoreHostDnsInfo.cpp
+1 -1
@@ -306,7 +306,7 @@ wsl::core::networking::DnsInfo wsl::core::networking::HostDnsInfo::GetDnsSetting
306 }
307 }
308
309 - // Give precedence to interfaces that have IPv4 DNS servers, otherwise give precedence to the lower interface index.
309 + // Give precedence to interfaces that have IPv4 DNS servers; otherwise, give precedence to the lower interface index.
310 return (FirstHasIpv4 ^ SecondHasIpv4) ? FirstHasIpv4 : (First->IfIndex < Second->IfIndex);
311 });
312
src/windows/service/exe/WslCoreTcpIpStateTracking.cpp
+1 -1
@@ -86,7 +86,7 @@ try
86 else
87 {
88 WSL_LOG(
89 - "IpStateTracking::SyncFirewallState - FirewallTrackedIpAddresses is syncd with the preferredNetwork",
89 + "IpStateTracking::SyncFirewallState - FirewallTrackedIpAddresses is synced with the preferredNetwork",
90 TraceLoggingValue(FirewallTrackedIpAddresses.size(), "FirewallTrackedIpAddresses.size"));
91 }
92 }
src/windows/service/exe/WslCoreVm.cpp
+5 -5
@@ -203,7 +203,7 @@ void WslCoreVm::Initialize(const GUID& VmId, const wil::shared_handle& UserToken
203 }
204 CATCH_LOG();
205
206 - // If a private kernel was not speicifed, use the default.
206 + // If a private kernel was not specified, use the default.
207 m_defaultKernel = m_vmConfig.KernelPath.empty();
208 if (m_defaultKernel)
209 {
@@ -1144,7 +1144,7 @@ ULONG WslCoreVm::AttachDiskLockHeld(
1144 {
1145 if (found != m_attachedDisks.end())
1146 {
1147 - // Prevent user from launching a distro vhd after manually mounting it, otherwise return the LUN of the mounted disk.
1147 + // Prevent user from launching a distro vhd after manually mounting it; otherwise, return the LUN of the mounted disk.
1148 THROW_HR_IF(WSL_E_USER_VHD_ALREADY_ATTACHED, found->first.User);
1149
1150 return found->second.Lun;
@@ -2521,7 +2521,7 @@ void WslCoreVm::RegisterCallbacks(_In_ const std::function<void(ULONG)>& DistroE
2521 }
2522 else
2523 {
2524 - // The VM has already been terminated, invoke the callback on a seperate thread.
2524 + // The VM has already been terminated, invoke the callback on a separate thread.
2525 std::thread([terminationCallback = std::move(TerminationCallback), runtimeId = m_runtimeId]() {
2526 wsl::windows::common::wslutil::SetThreadDescription(L"TerminationCallback");
2527 terminationCallback(runtimeId);
@@ -2962,7 +2962,7 @@ void WslCoreVm::ValidateNetworkingMode()
2962 {
2963 if (!wsl::core::MirroredNetworking::IsHyperVFirewallSupported(m_vmConfig))
2964 {
2965 - // Since hyper-V firewall is enabled by default, only show the warning if the user explicitely asked for it.
2965 + // Since hyper-V firewall is enabled by default, only show the warning if the user explicitly asked for it.
2966 if (m_vmConfig.FirewallConfigPresence == ConfigKeyPresence::Present)
2967 {
2968 EMIT_USER_WARNING(Localization::MessageHyperVFirewallNotSupported());
@@ -3001,7 +3001,7 @@ void WslCoreVm::ValidateNetworkingMode()
3001 // If DNS tunneling was requested, ensure it is supported by Windows.
3002 if (m_vmConfig.EnableDnsTunneling && !IsDnsTunnelingSupported())
3003 {
3004 - // Since DNS tunneling is enabled by default, only show the warning if the user explicitely asked for it.
3004 + // Since DNS tunneling is enabled by default, only show the warning if the user explicitly asked for it.
3005 if (m_vmConfig.DnsTunnelingConfigPresence == ConfigKeyPresence::Present)
3006 {
3007 EMIT_USER_WARNING(Localization::MessageDnsTunnelingNotSupported());
src/windows/service/exe/WslMirroredNetworking.cpp
+5 -5
@@ -590,7 +590,7 @@ wsl::core::networking::WslMirroredNetworkManager::WslMirroredNetworkManager(
590 // Subscribe for network change notifications. This is done before
591 // obtaining the initial list of networks to connect to, in order to
592 // avoid a race condition between the initial enumeration and any network
593 - // changes that may be occuring at the same time. The subscription will
593 + // changes that may be occurring at the same time. The subscription will
594 // receive network change events, but will not be able to react to them
595 // the lock is released.
596 m_hcnCallback = windows::common::hcs::RegisterServiceCallback(HcnCallback, this);
@@ -1026,7 +1026,7 @@ _Check_return_ bool wsl::core::networking::WslMirroredNetworkManager::SyncIpStat
1026 const auto makingIpInterfaceUpdate = endpoint.Network->PendingIPInterfaceUpdate;
1027 // Linux may delete routes behind us when making interface, address, and route changes
1028 // will track when to refresh v4 and v6 routes to ensure routes are still present after changes
1029 - // a few custmomers have seen this when we update temporary v6 addresses, for example
1029 + // a few customers have seen this when we update temporary v6 addresses, for example
1030 auto refreshAllRoutes = false;
1031
1032 // First: update Linux with any interface updates
@@ -1237,7 +1237,7 @@ _Check_return_ bool wsl::core::networking::WslMirroredNetworkManager::SyncIpStat
1237 {
1238 auto trackedAddress = endpoint.StateTracking->IpAddresses.emplace(TrackedIpAddress(hostAddress)).first;
1239 // detect if previously sync'd addresses need to be updated
1240 - // this addresses issues we've seen where addresses were removed from Linux without our knowlege
1240 + // this addresses issues we've seen where addresses were removed from Linux without our knowledge
1241 shouldRefreshAllAddresses |= trackedAddress->SyncStatus == PendingAdd || trackedAddress->SyncStatus == PendingUpdate;
1242 }
1243
@@ -1383,7 +1383,7 @@ _Check_return_ bool wsl::core::networking::WslMirroredNetworkManager::SyncIpStat
1383 {
1384 const auto trackedRoute = endpoint.StateTracking->Routes.emplace(TrackedRoute(hostRoute)).first;
1385 // detect if previously sync'd routes need to be updated
1386 - // this addresses issues we've seen where routes were removed from Linux without our knowlege
1386 + // this addresses issues we've seen where routes were removed from Linux without our knowledge
1387 // and routes couldn't be updated later because required routes, like the prefix route, wasn't there
1388 refreshAllRoutes |= trackedRoute->SyncStatus == PendingAdd || trackedRoute->SyncStatus == PendingUpdate;
1389 }
@@ -1686,7 +1686,7 @@ try
1686 // mirroredConnectedInterfaces won't equal m_hostConnectedInterfaces when:
1687 // - there are hidden host interfaces
1688 // i.e., interfaces are in m_networkEndpoints but not in m_hostConnectedInterfaces
1689 - // - when HNS hasn't yet mirrored an connected host interface
1689 + // - when HNS hasn't yet mirrored a connected host interface
1690 // i.e. interfaces are in m_hostConnectedInterfaces but not in m_networkEndpoints
1691 //
1692 // if HNS has not yet mirrored a host interface, we should not indicate we are in sync
src/windows/service/inc/windowsdefs.idl
+1 -1
@@ -86,7 +86,7 @@ interface IVmFiovGuestMemoryFastNotification : IUnknown
86 ]
87 interface ICallingProcessInfo : IUnknown
88 {
89 - HRESULT OpenCallerProcessHandle(DWORD desiredAccess, [out, annotation("_Out_")] HANDLE *callerPocessHandle);
89 + HRESULT OpenCallerProcessHandle(DWORD desiredAccess, [out, annotation("_Out_")] HANDLE *callerProcessHandle);
90 };
91
92 [
src/windows/wslhost/main.cpp
+3 -3
@@ -220,8 +220,8 @@ try
220
221 // Launch the interop server.
222 //
223 - // See Github #7568. There needs to be a console for interop.
224 - // From Github #8161 we learned we can't be attached to the same
223 + // See GitHub #7568. There needs to be a console for interop.
224 + // From GitHub #8161 we learned we can't be attached to the same
225 // console as wsl.exe. If we are we will be terminated and unable
226 // to serve daemonized processes after the console is closed.
227 wsl::windows::common::helpers::CreateConsole(nullptr);
@@ -258,7 +258,7 @@ try
258 {
259 wsl::shared::SocketChannel channel{wil::unique_socket{reinterpret_cast<SOCKET>(handle.release())}, "Interop-wslhost"};
260
261 - // This is required because there could have been messages beetween the process and wsl.exe, and wslhost has no way to know what the sequence numbers were.
261 + // This is required because there could have been messages between the process and wsl.exe, and wslhost has no way to know what the sequence numbers were.
262 channel.IgnoreSequenceNumbers();
263
264 wsl::windows::common::interop::VmModeWorkerThread(channel, vmId, true);
src/windows/wslinstall/DllMain.cpp
+3 -3
@@ -479,7 +479,7 @@ extern "C" UINT __stdcall CleanMsixState(MSIHANDLE install)
479
480 /*
481 * Because of a probable bug in MSIX / Packaged COM, it's possible that an old registration is still present on the machine,
482 - * which will break instanciations of LxssUserSessions.
482 + * which will break instantiations of LxssUserSessions.
483 * Because this method executes after all MSIX packages have been removed, we know that this registration shouldn't be there,
484 * so delete it if it still happens to be there.
485 * See: https://github.com/microsoft/WSL/issues/10782
@@ -598,7 +598,7 @@ catch (...)
598 wsl::windows::common::filesystem::TempFile ExtractMsix(MSIHANDLE install)
599 {
600 // N.B. We need to open the database this way instead of calling MsiGetActiveDatabase() because
601 - // this is defered action so we don't have access to the MSI context here.
601 + // this is deferred action so we don't have access to the MSI context here.
602 // The MSIX needs to be extracted like this because in the case of an upgrade this action runs before 'MoveFiles' so the WSL directory isn't available yet.
603
604 const auto installTarget = GetInstallTarget(install);
@@ -699,7 +699,7 @@ try
699 catch (...)
700 {
701 // For convenience, automatically trust the MSIX's certificate if this is NOT an official build and
702 - // the package installation failed because of an unstrusted certificate.
702 + // the package installation failed because of an untrusted certificate.
703 #ifndef WSL_OFFICIAL_BUILD
704 auto error = wil::ResultFromCaughtException();
705 if (error == CERT_E_UNTRUSTEDROOT)
src/windows/wslrelay/localhost.cpp
+1 -1
@@ -217,7 +217,7 @@ void wsl::windows::wslrelay::localhost::Relay::StopPortListener(_In_ unsigned sh
217 {
218 try
219 {
220 - // Search through the woker threads and terminate any that match the address family and port.
220 + // Search through the worker threads and terminate any that match the address family and port.
221 auto lock = m_lock.lock_exclusive();
222 const auto iter = m_RelayThreads.find({Family, Port});
223 if (iter != m_RelayThreads.end())
src/windows/wslsettings/Helpers/RuntimeHelper.cs
+1 -1
@@ -37,7 +37,7 @@ public class RuntimeHelper
37 return openPicker.PickSingleFileAsync();
38 }
39
40 - public static void TryMoveFocusPrevousControl(Button? button)
40 + public static void TryMoveFocusPreviousControl(Button? button)
41 {
42 if (button == null)
43 {
src/windows/wslsettings/LibWsl.cs
+1 -1
@@ -31,7 +31,7 @@ namespace LibWsl
31 AutoProxyEnabled = 11,
32 InitialAutoProxyTimeout = 12,
33 DNSProxyEnabled = 13,
34 - DNSTunellingEnabled = 14,
34 + DNSTunnelingEnabled = 14,
35 BestEffortDNSParsingEnabled = 15,
36 AutoMemoryReclaim = 16,
37 GUIApplicationsEnabled = 17,
src/windows/wslsettings/ViewModels/Settings/NetworkingViewModel.cs
+1 -1
@@ -54,7 +54,7 @@ public partial class NetworkingViewModel : WslConfigSettingViewModel
54 _autoProxy = wslConfigService.GetWslConfigSetting(WslConfigEntry.AutoProxyEnabled);
55 _initialAutoProxyTimeout = wslConfigService.GetWslConfigSetting(WslConfigEntry.InitialAutoProxyTimeout);
56 _dNSProxy = wslConfigService.GetWslConfigSetting(WslConfigEntry.DNSProxyEnabled);
57 - _dNSTunneling = wslConfigService.GetWslConfigSetting(WslConfigEntry.DNSTunellingEnabled);
57 + _dNSTunneling = wslConfigService.GetWslConfigSetting(WslConfigEntry.DNSTunnelingEnabled);
58 _bestEffortDNS = wslConfigService.GetWslConfigSetting(WslConfigEntry.BestEffortDNSParsingEnabled);
59
60 string defaultIgnoredPorts = wslConfigService.GetWslConfigSetting(WslConfigEntry.IgnoredPorts, true).StringValue;
src/windows/wslsettings/ViewModels/Settings/WslConfigSettingViewModel.cs
+1 -1
@@ -32,7 +32,7 @@ namespace WslSettings.ViewModels.Settings
32 {
33 if (newValue == null || !regex.IsMatch(newValue))
34 {
35 - // Notify the property so it can revert back to its' previous value.
35 + // Notify the property so it can revert back to its previous value.
36 OnPropertyChanged(propertyName);
37 return false;
38 }
src/windows/wslsettings/Views/Settings/FileSystemPage.xaml.cs
+1 -1
@@ -40,7 +40,7 @@ public sealed partial class FileSystemPage : Page
40 return;
41 }
42
43 - RuntimeHelper.TryMoveFocusPrevousControl(sender as Button);
43 + RuntimeHelper.TryMoveFocusPreviousControl(sender as Button);
44 }
45
46 private void DefaultVHDSizeTextBox_TextChanged(object sender, TextChangedEventArgs e)
src/windows/wslsettings/Views/Settings/MemAndProcPage.xaml.cs
+1 -1
@@ -41,7 +41,7 @@ public sealed partial class MemAndProcPage : Page
41 return;
42 }
43
44 - RuntimeHelper.TryMoveFocusPrevousControl(sender as Button);
44 + RuntimeHelper.TryMoveFocusPreviousControl(sender as Button);
45 }
46
47 public async void SwapFilePath_Click(object sender, RoutedEventArgs e)
src/windows/wslsettings/Views/Settings/NetworkingPage.xaml.cs
+1 -1
@@ -40,7 +40,7 @@ public sealed partial class NetworkingPage : Page
40 return;
41 }
42
43 - RuntimeHelper.TryMoveFocusPrevousControl(sender as Button);
43 + RuntimeHelper.TryMoveFocusPreviousControl(sender as Button);
44 }
45
46 private void InitialAutoProxyTimeoutTextBox_TextChanged(object sender, TextChangedEventArgs e)
src/windows/wslsettings/Views/Settings/OptionalFeaturesPage.xaml.cs
+1 -1
@@ -40,7 +40,7 @@ public sealed partial class OptionalFeaturesPage : Page
40 return;
41 }
42
43 - RuntimeHelper.TryMoveFocusPrevousControl(sender as Button);
43 + RuntimeHelper.TryMoveFocusPreviousControl(sender as Button);
44 }
45
46 private void VMIdleTimeoutTextBox_TextChanged(object sender, TextChangedEventArgs e)
test/README.md
+3 -3
@@ -88,7 +88,7 @@ For example, consider the file below, named `ExampleTest.cpp`:
88
89 #include "Common.h" // referring to /test/Common.h, where general utility functions for interacting with WSL in regards to testing reside
90
91 - #define INLINE_TEST_METHOD_MARKUP // optional, but defined within the directory cmake build instructions. this is the practice that the pre-existing tests use
91 + #define INLINE_TEST_METHOD_MARKUP // optional, but defined within the directory cmake build instructions. this is the practice that the preexisting tests use
92
93 namespace ExampleTest
94 {
@@ -107,13 +107,13 @@ For example, consider the file below, named `ExampleTest.cpp`:
107 } //namespace ExampleTest
108 ```
109
110 -For more in-depth examples of writing TAEF tests, check out `/tests/MountTests.cpp` and [here](https://docs.microsoft.com/windows-hardware/drivers/taef/authoring-tests-in-c--#advanced-authoring-tests-in-c).
110 +For more in-depth examples of writing TAEF tests, check out `/tests/MountTests.cpp` and [Advanced Authoring Tests in C++](https://docs.microsoft.com/windows-hardware/drivers/taef/authoring-tests-in-c--#advanced-authoring-tests-in-c).
111
112 ## Building Tests
113
114 ### CMake
115
116 -For examples on how to get your test/s building within the repo, please view `/test/CMakeLists.txt` for the structure of creating add to the `wsltest.dll`. For additional information on how to use CMake, try [here](https://cmake.org/documentation/).
116 +For examples on how to get your test/s building within the repo, please view `/test/CMakeLists.txt` for the structure of creating add to the `wsltest.dll`. For additional information on how to use CMake, try [CMake Documentation and Community](https://cmake.org/documentation/).
117
118 ### Building
119
test/linux/unit_tests/cgroup.c
+8 -8
@@ -278,7 +278,7 @@ Return Value:
278
279 //
280 // Check that removing the first directory fails if a thread is still
281 - // associated, otherwise it succeeds.
281 + // associated; otherwise, it succeeds.
282 //
283
284 LxtCheckErrno(mkdir(CGROUP_TEST_MOUNT_POINT_DIR1, 0777));
@@ -390,7 +390,7 @@ ErrorExit:
390 typedef struct _CGROUP_TEST_PROCFS_ENTRY
391 {
392 char Name[CGROUP_TEST_MAX_NAME_LENGTH];
393 - int Hierarcy;
393 + int Hierarchy;
394 int NumCgroups;
395 int Enabled;
396 } CGROUP_TEST_PROCFS_ENTRY, *PCGROUP_TEST_PROCFS_ENTRY;
@@ -444,7 +444,7 @@ Return Value:
444 Line,
445 "%s\t%d\t%d\t%d",
446 Data->Entries[NumCgroups].Name,
447 - &Data->Entries[NumCgroups].Hierarcy,
447 + &Data->Entries[NumCgroups].Hierarchy,
448 &Data->Entries[NumCgroups].NumCgroups,
449 &Data->Entries[NumCgroups].Enabled);
450
@@ -464,7 +464,7 @@ ErrorExit:
464
465 typedef struct _CGROUP_TEST_PROCFS_PID_ENTRY
466 {
467 - int Hierarcy;
467 + int Hierarchy;
468 char Subsystems[CGROUP_TEST_DEFAULT_BUFFER_SIZE];
469 char CgroupPath[CGROUP_TEST_DEFAULT_BUFFER_SIZE];
470 } CGROUP_TEST_PROCFS_PID_ENTRY, *PCGROUP_TEST_PROCFS_PID_ENTRY;
@@ -510,7 +510,7 @@ Return Value:
510 sscanf(
511 Line,
512 "%d:%[^:]:%[^:\n]",
513 - &Data->Entries[NumCgroups].Hierarcy,
513 + &Data->Entries[NumCgroups].Hierarchy,
514 Data->Entries[NumCgroups].Subsystems,
515 Data->Entries[NumCgroups].CgroupPath);
516
@@ -580,7 +580,7 @@ Return Value:
580 if (strcmp(ProcfsNew.Entries[Index].Name, "devices") == 0)
581 {
582 LxtCheckNotEqual(Found, 1, "%d");
583 - LxtCheckNotEqual(ProcfsNew.Entries[Index].Hierarcy, 0, "%d");
583 + LxtCheckNotEqual(ProcfsNew.Entries[Index].Hierarchy, 0, "%d");
584 Found = 1;
585 }
586 }
@@ -598,7 +598,7 @@ Return Value:
598 if (strstr(ProcfsPidNew.Entries[Index].Subsystems, "devices") != NULL)
599 {
600 LxtCheckNotEqual(Found, 1, "%d");
601 - LxtCheckNotEqual(ProcfsPidNew.Entries[Index].Hierarcy, 0, "%d");
601 + LxtCheckNotEqual(ProcfsPidNew.Entries[Index].Hierarchy, 0, "%d");
602 LxtCheckStringEqual(ProcfsPidNew.Entries[Index].CgroupPath, "/");
603 Found = 1;
604 }
@@ -933,7 +933,7 @@ Return Value:
933 if (strcmp(ProcfsNew.Entries[Index].Name, "devices") == 0)
934 {
935 LxtCheckNotEqual(Found, 1, "%d");
936 - LxtCheckNotEqual(ProcfsNew.Entries[Index].Hierarcy, 0, "%d");
936 + LxtCheckNotEqual(ProcfsNew.Entries[Index].Hierarchy, 0, "%d");
937 Found = 1;
938 }
939 }
test/linux/unit_tests/common.c
+2 -2
@@ -117,7 +117,7 @@ Return Value:
117 LxtCheckErrno(BytesRead = recv(Fd, Buffer, sizeof(Buffer), 0));
118 if (BytesRead != 0)
119 {
120 - LxtLogError("recv should return 0 bytes read, but it retured %d bytes", BytesRead);
120 + LxtLogError("recv should return 0 bytes read, but it returned %d bytes", BytesRead);
121
122 goto ErrorExit;
123 }
@@ -158,7 +158,7 @@ Return Value:
158 LxtCheckErrno(BytesRead = recv(Fd, Buffer, 0, 0));
159 if (BytesRead != 0)
160 {
161 - LxtLogError("recv should return 0 bytes read, but it retured %d bytes", BytesRead);
161 + LxtLogError("recv should return 0 bytes read, but it returned %d bytes", BytesRead);
162
163 goto ErrorExit;
164 }
test/linux/unit_tests/dev_pt.c
+19 -19
@@ -542,7 +542,7 @@ Routine Description:
542 This routine performs a very basic check for pseudo terminal. The steps are:
543 - Open the master.
544 - Open the subordinate.
545 - - Turns off ONLR to verify termios applies only to subordinate.
545 + - Turns off ICRNL to verify termios applies only to subordinate.
546 - Perform simple read/write check on the master-subordinate.
547
548
@@ -1222,7 +1222,7 @@ Return Value:
1222 char MessageBuffer[10];
1223 size_t MessageLength;
1224 int PtmFd;
1225 - char PtsBuffer[PTS_DEV_NAME_BUFER_SIZE];
1225 + char PtsBuffer[PTS_DEV_NAME_BUFFER_SIZE];
1226 int Result;
1227 pid_t SelfPid;
1228 pid_t SessionId;
@@ -1352,7 +1352,7 @@ Return Value:
1352 {
1353
1354 int PtmFd;
1355 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
1355 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
1356 int PtsFd;
1357 int Result;
1358 int SerialNumber;
@@ -1387,7 +1387,7 @@ Return Value:
1387 // It should fail.
1388 //
1389
1390 - LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFER_SIZE));
1390 + LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFFER_SIZE));
1391 LxtLogInfo("Subordinate Device is:%s", PtsDevName);
1392 PtsFd = open(PtsDevName, O_RDWR);
1393 LxtCheckErrnoFailure(open(PtsDevName, O_RDWR), EIO);
@@ -1492,7 +1492,7 @@ Return Value:
1492 {
1493
1494 int PtmFd;
1495 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
1495 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
1496 int PtsFd;
1497 int Result;
1498 int SerialNumber1;
@@ -1532,7 +1532,7 @@ Return Value:
1532
1533 LxtCheckErrno((PtmFd = open("/dev/ptmx", O_RDWR)));
1534 LxtLogInfo("Master opened at FD:%d", PtmFd);
1535 - LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFER_SIZE));
1535 + LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFFER_SIZE));
1536 LxtLogInfo("Subordinate Device is:%s", PtsDevName);
1537 LxtCheckErrno((SerialNumber2 = GetPtSerialNumFromDeviceString(PtsDevName)));
1538
@@ -1607,7 +1607,7 @@ int PtCheck3(PLXT_ARGS Args)
1607 Routine Description:
1608
1609 This routine validates that the pseudo terminal driver is able to
1610 - handle muliple opens on the same subordinate device.
1610 + handle multiple opens on the same subordinate device.
1611
1612 Arguments:
1613
@@ -1622,7 +1622,7 @@ Return Value:
1622 {
1623
1624 int PtmFd;
1625 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
1625 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
1626 int PtsFd;
1627 int PtsFd1;
1628 int PtsFd2;
@@ -1727,7 +1727,7 @@ Return Value:
1727 char Message1[] = "ls -al\n";
1728 char Message2[] = "date\n";
1729 int PtmFd;
1730 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
1730 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
1731 int PtsFd;
1732 char ReadBuffer[50];
1733 int Result;
@@ -3042,7 +3042,7 @@ Return Value:
3042
3043 int Result;
3044 int PtmFd;
3045 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
3045 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
3046 int PtsFd;
3047
3048 //
@@ -3060,7 +3060,7 @@ Return Value:
3060 LxtLogInfo("Master opened at FD:%d", PtmFd);
3061 LxtCheckErrno(grantpt(PtmFd));
3062 LxtCheckErrno(unlockpt(PtmFd));
3063 - LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFER_SIZE));
3063 + LxtCheckErrno(ptsname_r(PtmFd, PtsDevName, PTS_DEV_NAME_BUFFER_SIZE));
3064 LxtLogInfo("Subordinate Device is:%s", PtsDevName);
3065
3066 //
@@ -3111,7 +3111,7 @@ Return Value:
3111
3112 int Result;
3113 int PtmFd;
3114 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
3114 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
3115 int PtsFd;
3116 int SerialNumber;
3117
@@ -4445,7 +4445,7 @@ Return Value:
4445 LxtCheckErrnoFailure(BytesReadWrite = write(PtsFd, WriteBuffer, WriteBufferLen), EAGAIN);
4446
4447 //
4448 - // Try to write a byte, which will block. Wait for the the other thread
4448 + // Try to write a byte, which will block. Wait for the other thread
4449 // to unblock this request. Do this multiple times to test different
4450 // methods of unblocking.
4451 //
@@ -4601,7 +4601,7 @@ int PtMasterHangup1(PLXT_ARGS Args)
4601
4602 Routine Description:
4603
4604 - This routine will try to determine the the behavior when the subordinate
4604 + This routine will try to determine the behavior when the subordinate
4605 tries to write after the master has hangup.
4606 Expected Result: The write on subordinate should return with error 5:EIO.
4607
@@ -4837,7 +4837,7 @@ int PtMasterHangup3(PLXT_ARGS Args)
4837
4838 Routine Description:
4839
4840 - This routine will try to determine the the behavior when the master opens,
4840 + This routine will try to determine the behavior when the master opens,
4841 writes some complete messages and closes. Subordinate then tries to read.
4842 Expected Result: The read on subordinate should return 0 bytes read.
4843
@@ -5042,7 +5042,7 @@ Return Value:
5042 int Loop;
5043 int LoopCount;
5044 int NumPtToTest;
5045 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
5045 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
5046 int Result;
5047
5048 //
@@ -5681,7 +5681,7 @@ Return Value:
5681 {
5682
5683 //
5684 - // Setup the argument for the stress I/O thread.
5684 + // Set up the argument for the stress I/O thread.
5685 //
5686
5687 ThreadArg[Itr].PtmFd = PtFds[Itr][0];
@@ -5692,7 +5692,7 @@ Return Value:
5692 {
5693
5694 //
5695 - // Create I/O Strss thread#ThreadItr for PT#Itr
5695 + // Create I/O Stress thread#ThreadItr for PT#Itr
5696 //
5697
5698 LxtCheckErrno(pthread_create(&Thread[Itr][ThreadItr], NULL, PerformIoStressThread, (void*)&ThreadArg[Itr]));
@@ -6564,7 +6564,7 @@ int PtUTF8Basic7(PLXT_ARGS Args)
6564
6565 Routine Description:
6566
6567 - This routine sends a string ending with a UTF-8 character, follwed by the
6567 + This routine sends a string ending with a UTF-8 character, followed by the
6568 delete char. This is expected to remove only a single byte from the string.
6569
6570 Arguments:
test/linux/unit_tests/dev_pt_2.c
+4 -4
@@ -737,7 +737,7 @@ Return Value:
737 LxtCheckEqual(TerminalForegroundId, ForegroundId, "%d");
738
739 //
740 - // Do a aimple IO check.
740 + // Do a simple IO check.
741 //
742
743 LxtCheckErrno(RawInit(PtsFd));
@@ -1744,7 +1744,7 @@ int PtBufferTerminalFill(PLXT_ARGS Args)
1744
1745 Routine Description:
1746
1747 - This routine checks the internal implemenation of the buffer by attempting
1747 + This routine checks the internal implementation of the buffer by attempting
1748 to fill it.
1749
1750 Arguments:
@@ -2395,7 +2395,7 @@ Return Value:
2395 LxtCheckErrno(tcsetpgrp(PtsFd, GrandChildPid));
2396
2397 //
2398 - // Disassocate terminal.
2398 + // Disassociate terminal.
2399 //
2400
2401 LxtCheckErrno(ioctl(PtsFd, TIOCNOTTY, (char*)NULL));
@@ -8715,7 +8715,7 @@ Return Value:
8715 tcflag_t InputFlags;
8716 int PtmFd;
8717 int PtsFd;
8718 - char PtsDevName[PTS_DEV_NAME_BUFER_SIZE];
8718 + char PtsDevName[PTS_DEV_NAME_BUFFER_SIZE];
8719 char ReadBuffer[20];
8720 int Result;
8721 int SerialNumber;
test/linux/unit_tests/dev_pt_common.c
+2 -2
@@ -199,7 +199,7 @@ Return Value:
199
200 int Fdm;
201 int Fds;
202 - char LocalBuffer[PTS_DEV_NAME_BUFER_SIZE];
202 + char LocalBuffer[PTS_DEV_NAME_BUFFER_SIZE];
203 int Result;
204 int SubordinateSerialNumber;
205
@@ -214,7 +214,7 @@ Return Value:
214 LxtCheckErrno((Fdm = open("/dev/ptmx", O_RDWR)));
215 LxtCheckErrno(grantpt(Fdm));
216 LxtCheckErrno(unlockpt(Fdm));
217 - LxtCheckErrno(ptsname_r(Fdm, LocalBuffer, PTS_DEV_NAME_BUFER_SIZE));
217 + LxtCheckErrno(ptsname_r(Fdm, LocalBuffer, PTS_DEV_NAME_BUFFER_SIZE));
218 LxtCheckErrno(Fds = open(LocalBuffer, O_RDWR));
219 if (PtsDevName != NULL)
220 {
test/linux/unit_tests/dev_pt_common.h
+1 -1
@@ -49,7 +49,7 @@ Abstract:
49 #define FALSE 0
50 #define TRUE 1
51
52 -#define PTS_DEV_NAME_BUFER_SIZE 50
52 +#define PTS_DEV_NAME_BUFFER_SIZE 50
53
54 #define IS_CONTROL_CHAR_ECHO_STRING(s, c) (((s)[0] == '^') && (((s)[1] > 0x40)) && (((s)[1] - 0x40) == (c)))
55
test/linux/unit_tests/drvfs.c
+7 -7
@@ -270,7 +270,7 @@ static const LXT_VARIATION g_LxtFatVariations[] = {
270 {"DrvFs - inotify with epoll", DrvFsTestInotifyEpoll},
271 {"DrvFs - inotify unmounting of a bind mount", DrvFsTestInotifyUnmountBind},
272 {"DrvFs - block count", DrvFsTestBlockCount},
273 - {"DrvFs - FAT32 case insensitive", DrvFsTestFatCaseInsensitive},
273 + {"DrvFs - FAT32 case-insensitive", DrvFsTestFatCaseInsensitive},
274 {"DrvFs - FAT32 unsupported features", DrvFsTestFatUnsupported},
275 {"DrvFs - FAT32 utimensat", DrvFsTestFatUtimensat},
276 {"DrvFs - FAT32 mount point junction", DrvFsTestFatJunction},
@@ -295,7 +295,7 @@ static const LXT_VARIATION g_LxtSmbVariations[] = {
295 {"DrvFs - rename", DrvFsTestRename},
296 {"DrvFs - renameat", DrvFsTestRenameAt},
297 {"DrvFs - hard links", DrvFsTestHardLinks},
298 - {"DrvFs - SMB case insensitive", DrvFsTestFatCaseInsensitive},
298 + {"DrvFs - SMB case-insensitive", DrvFsTestFatCaseInsensitive},
299 {"DrvFs - SMB unsupported features", DrvFsTestSmbUnsupported},
300 {"DrvFs - SMB utimensat", DrvFsTestSmbUtimensat},
301 {"DrvFs - fstat", DrvFsTestFstat},
@@ -1650,7 +1650,7 @@ int DrvFsTestFatCaseInsensitive(PLXT_ARGS Args)
1650
1651 Description:
1652
1653 - This routine tests the case insensitive behavior of FAT.
1653 + This routine tests the case-insensitive behavior of FAT.
1654
1655 Arguments:
1656
@@ -1707,7 +1707,7 @@ Return Value:
1707 // renaming on FAT.
1708 //
1709 // N.B. With SMB over Plan 9, because Linux doesn't know the file system is
1710 - // case insensitive and NTFS does let you change the case on rename,
1710 + // case-insensitive and NTFS does let you change the case on rename,
1711 // this actually does change the case.
1712 //
1713
@@ -1720,7 +1720,7 @@ Return Value:
1720 // directory entries are cached.
1721 //
1722 // N.B. This is not the case with Plan 9 because Linux doesn't know the
1723 - // file system is case insensitive.
1723 + // file system is case-insensitive.
1724 //
1725
1726 if (g_LxtFsInfo.FsType != LxtFsTypePlan9)
@@ -3651,7 +3651,7 @@ int DrvFsTestSetup(PLXT_ARGS Args, int TestMode)
3651
3652 Description:
3653
3654 - This routine perofrms setup for the drvfs tests.
3654 + This routine performs setup for the drvfs tests.
3655
3656 Arguments:
3657
@@ -3779,7 +3779,7 @@ Return Value:
3779
3780 //
3781 // Check if drvfs actually used the requested fallback mode. This guards
3782 - // against a pre-existing instance (e.g. in another mount namespace)
3782 + // against a preexisting instance (e.g. in another mount namespace)
3783 // preventing the options from changing, or file system limitations causing
3784 // drvfs to use a different fallback mode than requested.
3785 //
test/linux/unit_tests/dup.c
+1 -1
@@ -109,7 +109,7 @@ Return Value:
109 LxtCheckResult((DupStdOut = dup(FD_STDOUT)));
110
111 //
112 - // Since we just closed STDIN, dup'ing STDOUT should take take the position
112 + // Since we just closed STDIN, duping STDOUT should take the position
113 // of STDIN
114 //
115
test/linux/unit_tests/epoll.c
+3 -3
@@ -515,7 +515,7 @@ const char* DataToWrite[] = {
515 "<This is the first message> ",
516 "<This is another message> ",
517 "<Dumbledore is dead> ",
518 - "<Harry Potter must not go back to Hogwards> ",
518 + "<Harry Potter must not go back to Hogwarts> ",
519 "<There must always be a stark in Winterfell>",
520 };
521
@@ -1423,7 +1423,7 @@ int EpollVariation0(PLXT_ARGS Args)
1423 LxtCheckErrnoFailure(epoll_ctl(EpollFileDescriptor, EPOLL_CTL_ADD, FileDescriptor1, &EpollControlEvent), EEXIST);
1424
1425 //
1426 - // Add the second file descriptor back in to the epoll.
1426 + // Add the second file descriptor back to the epoll.
1427 //
1428
1429 EpollControlEvent.events = EPOLLOUT | EPOLLPRI;
@@ -1481,7 +1481,7 @@ int EpollVariation0(PLXT_ARGS Args)
1481 LXT_SYNCHRONIZATION_POINT();
1482
1483 LXT_SYNCHRONIZATION_POINT();
1484 - LxtLogInfo("T2: Making data avilable for read...");
1484 + LxtLogInfo("T2: Making data available for read...");
1485 LxtCheckErrno((BytesReadWrite = write(Master, "\n", 1)));
1486
1487 Result = LXT_RESULT_SUCCESS;
test/linux/unit_tests/eventfd.c
+1 -1
@@ -80,7 +80,7 @@ int EventFdVariationReadWrite(PLXT_ARGS Args)
80 LXT_SYNCHRONIZATION_POINT_START();
81
82 //
83 - // FIXME: Add 0 varaition
83 + // FIXME: Add 0 variation
84 //
85
86 //
test/linux/unit_tests/flock.c
+1 -1
@@ -152,7 +152,7 @@ Return Value:
152 //
153 // Ensure that the lock was correctly set before. The lock descriptor is
154 // correctly set from before. The test expects to see the lock type be
155 - // changed to exlusive, WRLCK, though.
155 + // changed to exclusive, WRLCK, though.
156 //
157
158 LxtLogInfo("Fcntl child locking - Reading lock type");
test/linux/unit_tests/fork.c
+4 -4
@@ -451,7 +451,7 @@ int RobustFutex(PLXT_ARGS Args)
451 LxtCheckErrnoFailure(my_set_robust_list(&Head, (sizeof(struct robust_list_head) + 1)), EINVAL);
452
453 //
454 - // get_robust_list validates the buffesr.
454 + // get_robust_list validates the buffers.
455 //
456
457 LxtCheckErrnoFailure(my_get_robust_list(0, NULL, &SizeReturned), EFAULT);
@@ -711,7 +711,7 @@ int VForkTestBasic(PLXT_ARGS Args)
711 LxtCheckResult(LxtWaitPidPoll(ChildPid, LXT_RESULT_SUCCESS));
712
713 //
714 - // Repeat the above with the clone variaent of vfork.
714 + // Repeat the above with the clone variant of vfork.
715 //
716
717 LxtCheckErrno(ChildPid = LxtCloneSyscall(CLONE_VM | CLONE_VFORK | SIGCHLD, NULL, NULL, NULL, NULL));
@@ -778,7 +778,7 @@ int VForkTest(PLXT_ARGS Args)
778 LxtCheckResult(LxtWaitPidPoll(ChildPid, LXT_RESULT_SUCCESS));
779
780 //
781 - // Repease the above with execv.
781 + // Release the above with execv.
782 //
783
784 ChildPidFromChild = -1;
@@ -866,7 +866,7 @@ int VForkTest(PLXT_ARGS Args)
866 #if defined(__i386__) || defined(__amd64__)
867
868 //
869 - // Check that floating point context is preserved accross vfork.
869 + // Check that floating point context is preserved across vfork.
870 //
871
872 _FPU_GETCW(OriginalControlWord);
test/linux/unit_tests/fscommon.c
+7 -7
@@ -503,7 +503,7 @@ Return Value:
503 int Result;
504
505 //
506 - // Don't set close on exec on file desciptors in the main test process;
506 + // Don't set close on exec on file descriptors in the main test process;
507 // this would cause later tests to fail.
508 //
509
@@ -1154,7 +1154,7 @@ Return Value:
1154 }
1155
1156 //
1157 - // You cannot ressurrect a file with link count 0.
1157 + // You cannot resurrect a file with link count 0.
1158 //
1159 // N.B. On real Linux, the error code this produces is ENOENT, but since
1160 // NTFS returns STATUS_ACCESS_DENIED for this, WSL gives EACCES
@@ -1979,7 +1979,7 @@ Return Value:
1979 LxtCheckErrnoFailure(unlink(FS_RMDIR_TEST_DIR "/test/."), EISDIR);
1980
1981 //
1982 - // Non-existent paths.
1982 + // Nonexistent paths.
1983 //
1984
1985 LxtCheckErrnoFailure(rmdir(FS_RMDIR_TEST_DIR "/test2/.."), ENOENT);
@@ -2302,7 +2302,7 @@ Return Value:
2302 Fd = -1;
2303
2304 //
2305 - // Non-existent file tests.
2305 + // Nonexistent file tests.
2306 //
2307
2308 LxtCheckErrnoFailure(creat(FS_TRAILING_TEST_FILE "/", 0666), EISDIR);
@@ -2404,7 +2404,7 @@ Return Value:
2404 LxtCheckErrnoFailure(rmdir(FS_TRAILING_TEST_FILE "/"), ENOTDIR);
2405
2406 //
2407 - // Test a symlink to a non-existent target.
2407 + // Test a symlink to a nonexistent target.
2408 //
2409
2410 LxtCheckErrnoZeroSuccess(unlink(FS_TRAILING_TEST_LINK));
@@ -2420,7 +2420,7 @@ Return Value:
2420 LxtCheckErrnoFailure(lstat(FS_TRAILING_TEST_LINK "/", &Stat), ENOENT);
2421
2422 //
2423 - // Symlink to a non-existent target with trailing slash.
2423 + // Symlink to a nonexistent target with trailing slash.
2424 //
2425
2426 LxtCheckErrnoZeroSuccess(unlink(FS_TRAILING_TEST_LINK));
@@ -3663,7 +3663,7 @@ Return Value:
3663 LxtCheckErrnoZeroSuccess(unlink(FS_MKNOD_TEST_FILE));
3664
3665 //
3666 - // Non-existent block device.
3666 + // Nonexistent block device.
3667 //
3668 // N.B. Currently, no block devices exist in WSL.
3669 //
test/linux/unit_tests/fstab.c
+1 -1
@@ -100,7 +100,7 @@ Return Value:
100
101 //
102 // Check that there is only one mount for C: (or any variation therefore, like C:\ or c:),
103 - // and that that mount uses the exact options specified in fstab.
103 + // and that its mount uses the exact options specified in fstab.
104 //
105
106 if (strcmp(FsType, "9p") == 0)
test/linux/unit_tests/get_set_id.c
+1 -1
@@ -206,7 +206,7 @@ Return Value:
206 }
207
208 //
209 - // For a signle threaded process, Thread ID == Process ID
209 + // For a single threaded process, Thread ID == Process ID
210 //
211
212 if (Pid != Tid)
test/linux/unit_tests/keymgmt.c
+3 -3
@@ -161,7 +161,7 @@ int KeymgmtSessionKeyringAssociation(PLXT_ARGS Args)
161 KeyType = KEY_SPEC_SESSION_KEYRING;
162
163 //
164 - // This test checks to see where the session keyring is assocaited. The
164 + // This test checks to see where the session keyring is associated. The
165 // documentation is unclear if it is the threadgroup, thread, or user
166 // namespace. The test below validates that the session keyring is
167 // associated to the threadgroup and inherited across fork.
@@ -194,7 +194,7 @@ int KeymgmtSessionKeyringAssociation(PLXT_ARGS Args)
194
195 //
196 // Create a child process and thread, checking that the session keyring id
197 - // continues to be assocaited.
197 + // continues to be associated.
198 //
199
200 LxtCheckErrno(ChildPid = fork());
@@ -235,7 +235,7 @@ int KeymgmtSessionKeyringAssociation(PLXT_ARGS Args)
235
236 //
237 // Create a user namespace and check that the session keyring id continues
238 - // to be assocaited.
238 + // to be associated.
239 //
240
241 LxtCheckErrno(ChildPid = fork());
test/linux/unit_tests/lxtfs.c
+2 -2
@@ -1906,7 +1906,7 @@ Return Value:
1906 //
1907 // The following test cases deal with the old name containing a trailing slash.
1908 //
1909 - // Renaming a directory to a nonexistant directory should succeed.
1909 + // Renaming a directory to a nonexistent directory should succeed.
1910 //
1911
1912 LxtCheckErrnoZeroSuccess(mkdir(RenameTestDirSlash, 0777));
@@ -3751,7 +3751,7 @@ Return Value:
3751 {
3752 LxtLogError(
3753 "getdents should return 0 when end of directory is reached, "
3754 - "but it retuend: %d.",
3754 + "but it returned: %d.",
3755 Size);
3756
3757 Result = EINVAL;
test/linux/unit_tests/lxtlog.c
+1 -1
@@ -60,7 +60,7 @@ void LxtLog(LxtLogLevel LogLevel, const char* Message, ...)
60
61 //
62 // N.B. The signal handling code may use this function and not all of the
63 - // functions used here are re-entrant safe, resulting in possible
63 + // functions used here are reentrant safe, resulting in possible
64 // deadlocks or crashes. To avoid these keep an active count and skip
65 // functions known to be problematic in the signal case. The functions
66 // identified at this point are:
test/linux/unit_tests/lxtmount.c
+2 -2
@@ -546,7 +546,7 @@ int MountGetFileSystem(const char* Path, char* FsType, int FsTypeLength, char* O
546
547 Description:
548
549 - This routine gets the file sytem type of the mount containing the
549 + This routine gets the file system type of the mount containing the
550 specified path.
551
552 Arguments:
@@ -678,7 +678,7 @@ int MountIsFileSystem(const char* Path, const char* FsType)
678
679 Description:
680
681 - This routine checks the file sytem type of the mount containing the
681 + This routine checks the file system type of the mount containing the
682 specified path.
683
684 Arguments:
test/linux/unit_tests/lxtutil.c
+1 -1
@@ -1761,7 +1761,7 @@ Routine Description:
1761
1762 Arguments:
1763
1764 - SingalInfo - Supplies a pointer which receives the signal info.
1764 + SignalInfo - Supplies a pointer which receives the signal info.
1765
1766 Return Value:
1767
test/linux/unit_tests/mremap.c
+2 -2
@@ -740,7 +740,7 @@ int MremapTestEntry(int Argc, char* Argv[])
740 }
741
742 //
743 - // Case 19: Large region of copy-on-written pages with same protecion.
743 + // Case 19: Large region of copy-on-written pages with same protection.
744 //
745
746 FileSize = (512 * 1024);
@@ -1196,7 +1196,7 @@ int MremapTestEntry(int Argc, char* Argv[])
1196 }
1197
1198 //
1199 - // Case 29: Remap while spliting source VAD.
1199 + // Case 29: Remap while splitting source VAD.
1200 //
1201
1202 SharedPrivateMemory = mmap(NULL, 10 * PAGE_SIZE, PROT_READ | PROT_WRITE, MAP_ANONYMOUS | MAP_PRIVATE, 0, 0);
test/linux/unit_tests/namespace.c
+2 -2
@@ -505,7 +505,7 @@ int NamespacePidCheckProcPidStatStatusFiles(char* Dir)
505 ErrorExit:
506
507 //
508 - // Intentially do not close the files. These files are leaked to ensure
508 + // Intentionally do not close the files. These files are leaked to ensure
509 // the private procfs instance is cleaned up correctly when there are
510 // file descriptors that need to be closed during thread group end.
511 //
@@ -1088,7 +1088,7 @@ int NamespacePid(PLXT_ARGS Args)
1088 LxtWaitPidPoll(ChildPid, 0);
1089
1090 //
1091 - // Check the pid namesapce behavior for reboot.
1091 + // Check the pid namespace behavior for reboot.
1092 //
1093
1094 LxtCheckErrno(ChildPid = fork());
test/linux/unit_tests/netlink.c
+8 -8
@@ -654,7 +654,7 @@ Return Value:
654 // Test case: Bind with nl_pid = 0, kernel should assign a unique
655 // ID. The first netlink socket of the process is
656 // assigned the process ID as the nl_pid. It also confirms
657 - // the the pad value is ignored.
657 + // the pad value is ignored.
658 //
659
660 LxtCheckErrno(Socket = socket(AF_NETLINK, Type, Family));
@@ -671,7 +671,7 @@ Return Value:
671 LxtCheckEqual(AddressLength, sizeof(BindAddress), "%d");
672
673 //
674 - // Validate that a socket that is already bound, can not be bound again.
674 + // Validate that a socket that is already bound, cannot be bound again.
675 //
676
677 memset(&BindAddress, 0, sizeof(BindAddress));
@@ -684,7 +684,7 @@ Return Value:
684 // kernel assigns to the non-first sockets of the process).
685 // Test that the kernel will skip any negative nl_pid's that
686 // the user already specified. For example, Socket2 gets
687 - // an auto-assigned nl_pid of -5. Socket3 is binded with
687 + // an auto-assigned nl_pid of -5. Socket3 is bound with
688 // the user specifying nl_pid of -4. Socket4 gets an
689 // auto-assigned nl_pid of -3, since -4 was already taken
690 // by the user.
@@ -1745,7 +1745,7 @@ Return Value:
1745 // technically there is space in the receive buffer for the response.
1746 // The test sends a message with a unique sequence number. Later on, the
1747 // entire receive buffer will be drained and all responses checked to
1748 - // verify that this unqiue sequence number is not in any of the responses.
1748 + // verify that this unique sequence number is not in any of the responses.
1749 //
1750
1751 Request.nlmsg_seq = 0x98765432;
@@ -2188,7 +2188,7 @@ Return Value:
2188 Timeout.tv_nsec = 0;
2189
2190 //
2191 - // Setup the receive buffers.
2191 + // Set up the receive buffers.
2192 //
2193
2194 memset(ReceiveMessages, 0, sizeof(ReceiveMessages));
@@ -2369,7 +2369,7 @@ Return Value:
2369 struct timespec Timeout;
2370
2371 //
2372 - // The timeout value passed to recvmmsg() is ignored. Setup the receive
2372 + // The timeout value passed to recvmmsg() is ignored. Set up the receive
2373 // buffers.
2374 //
2375
@@ -2411,7 +2411,7 @@ Return Value:
2411 {
2412 LxtLogError(
2413 "recvmmsg should return 0 messages read, "
2414 - "but it retured %d messages for flags %x",
2414 + "but it returned %d messages for flags %x",
2415 MessagesRead,
2416 Flags);
2417
@@ -5379,7 +5379,7 @@ Return Value:
5379 // Check for general set/get of the SO_PASSCRED socket option.
5380 //
5381 // N.B After this routine, the state of the 'SO_PASSCRED' socket option in
5382 - // the socket is not gauranteed.
5382 + // the socket is not guaranteed.
5383 //
5384
5385 LxtCheckErrno(SocketGetSetBooleanSocketOption(Socket, SOL_SOCKET, SO_PASSCRED, false));
test/linux/unit_tests/overlayfs.c
+20 -20
@@ -56,7 +56,7 @@ Abstract:
56
57 #define OVFS_TEST_MOUNT_DEFAULT "lowerdir=" OVFS_TEST_LOWER_DIR ",upperdir=" OVFS_TEST_UPPER_DIR ",workdir=" OVFS_TEST_WORK_DIR
58
59 -#define OVFS_TEST_MOUNT_MULI_LOWER \
59 +#define OVFS_TEST_MOUNT_MULTI_LOWER \
60 "lowerdir=" OVFS_TEST_LOWER_DIR ":" OVFS_TEST_LOWER2_DIR ":" OVFS_TEST_LOWER3_DIR ",upperdir=" OVFS_TEST_UPPER_DIR \
61 ",workdir=" OVFS_TEST_WORK_DIR
62
@@ -238,7 +238,7 @@ Return Value:
238 int Result;
239
240 //
241 - // Setup the directories and ensure it's not a mount point yet.
241 + // Set up the directories and ensure it's not a mount point yet.
242 //
243
244 LxtCheckResult(OvFsTestDirsSetup());
@@ -473,7 +473,7 @@ Return Value:
473 Mapping = NULL;
474
475 //
476 - // Setup the directories and populate some state.
476 + // Set up the directories and populate some state.
477 //
478
479 LxtCheckResult(OvFsTestDirsSetup());
@@ -752,7 +752,7 @@ Return Value:
752 Mapping = NULL;
753
754 //
755 - // Setup the directories and populate some state.
755 + // Set up the directories and populate some state.
756 //
757
758 LxtCheckResult(OvFsTestDirsSetup());
@@ -925,7 +925,7 @@ Return Value:
925 Fd = -1;
926
927 //
928 - // Setup the directories and populate some state.
928 + // Set up the directories and populate some state.
929 //
930
931 LxtCheckResult(OvFsTestDirsSetup());
@@ -1203,7 +1203,7 @@ Return Value:
1203 Fd = -1;
1204
1205 //
1206 - // Setup the directories and populate some state.
1206 + // Set up the directories and populate some state.
1207 //
1208
1209 LxtCheckResult(OvFsTestDirsSetup());
@@ -1385,7 +1385,7 @@ Return Value:
1385 struct stat StatMergedBuffer;
1386
1387 //
1388 - // Setup the directories and populate some state.
1388 + // Set up the directories and populate some state.
1389 //
1390
1391 LxtCheckResult(OvFsTestDirsSetup());
@@ -1562,7 +1562,7 @@ Return Value:
1562 Fd = -1;
1563
1564 //
1565 - // Setup the directories and populate some state.
1565 + // Set up the directories and populate some state.
1566 //
1567
1568 LxtCheckResult(OvFsTestDirsSetup());
@@ -1732,7 +1732,7 @@ Return Value:
1732 Fd = -1;
1733
1734 //
1735 - // Setup the directories and populate some state.
1735 + // Set up the directories and populate some state.
1736 //
1737
1738 LxtCheckResult(OvFsTestDirsSetup());
@@ -2060,7 +2060,7 @@ Return Value:
2060 FdWrite = -1;
2061
2062 //
2063 - // Setup the directories and populate some state.
2063 + // Set up the directories and populate some state.
2064 //
2065
2066 LxtCheckResult(OvFsTestDirsSetup());
@@ -2076,7 +2076,7 @@ Return Value:
2076 //
2077 // Open the same file for read and write. The read file will be from the
2078 // lower layer, but opening the file for write will cause the file to be
2079 - // hydated in the upper layer and the inode updated.
2079 + // hydrated in the upper layer and the inode updated.
2080 //
2081
2082 LxtCheckErrno(Fd = open(OVFS_TEST_MOUNT_PATH "/OnlyInLowerFile", O_RDONLY, 0));
@@ -2359,7 +2359,7 @@ Return Value:
2359 LxtCheckErrno(LxtCapSet(&CapHeader, CapData));
2360
2361 //
2362 - // Open the file with different trunctate variations.
2362 + // Open the file with different truncate variations.
2363 //
2364
2365 LxtCheckErrno(Fd = open(OVFS_TEST_LOWER_DIR "/OnlyInLowerFile", O_RDONLY, 0));
@@ -2423,7 +2423,7 @@ Return Value:
2423 FdLower = -1;
2424
2425 //
2426 - // Setup the directories and populate some state.
2426 + // Set up the directories and populate some state.
2427 //
2428
2429 LxtCheckResult(OvFsTestDirsSetup());
@@ -2671,7 +2671,7 @@ Return Value:
2671 ssize_t ValueSize;
2672
2673 //
2674 - // Setup the directories and populate some state.
2674 + // Set up the directories and populate some state.
2675 //
2676
2677 LxtCheckResult(OvFsTestDirsSetup());
@@ -2847,7 +2847,7 @@ Return Value:
2847 Mapping = NULL;
2848
2849 //
2850 - // Setup the directories and populate some state.
2850 + // Set up the directories and populate some state.
2851 //
2852
2853 LxtCheckResult(OvFsTestDirsSetup());
@@ -2938,7 +2938,7 @@ Return Value:
2938 LxtCheckResult(MountCheckIsNotMount(OVFS_TEST_MOUNT_PATH));
2939
2940 LxtCheckResult(MountCheckIsNotMount(OVFS_TEST_MOUNT_PATH));
2941 - LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULI_LOWER));
2941 + LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULTI_LOWER));
2942
2943 //
2944 // Check that the whiteout cannot be opened but are reported through readdir
@@ -3073,7 +3073,7 @@ Return Value:
3073 Mapping = NULL;
3074
3075 //
3076 - // Setup the directories and populate some state.
3076 + // Set up the directories and populate some state.
3077 //
3078
3079 LxtCheckResult(OvFsTestDirsSetup());
@@ -3085,7 +3085,7 @@ Return Value:
3085 //
3086
3087 LxtCheckResult(MountCheckIsNotMount(OVFS_TEST_MOUNT_PATH));
3088 - LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULI_LOWER));
3088 + LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULTI_LOWER));
3089
3090 //
3091 // Check the behavior for VFS file object operations that support file
@@ -3326,7 +3326,7 @@ Return Value:
3326 //
3327
3328 LxtCheckResult(MountCheckIsNotMount(OVFS_TEST_MOUNT_PATH));
3329 - LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULI_LOWER));
3329 + LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULTI_LOWER));
3330
3331 LxtCheckErrno(stat(OVFS_TEST_MOUNT_PATH "/mixedType", &StatMergedBuffer));
3332 LxtCheckTrue(S_ISDIR(StatMergedBuffer.st_mode));
@@ -3393,7 +3393,7 @@ Return Value:
3393 //
3394
3395 LxtCheckResult(MountCheckIsNotMount(OVFS_TEST_MOUNT_PATH));
3396 - LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULI_LOWER));
3396 + LxtCheckErrnoZeroSuccess(mount("myovfsnew", OVFS_TEST_MOUNT_PATH, OVFS_TEST_MOUNT_NAME, 0, OVFS_TEST_MOUNT_MULTI_LOWER));
3397
3398 LxtCheckErrno(stat(OVFS_TEST_MOUNT_PATH "/mixedType", &StatMergedBuffer));
3399 LxtCheckTrue(S_ISDIR(StatMergedBuffer.st_mode));
test/linux/unit_tests/pipe.c
+3 -3
@@ -112,8 +112,8 @@ int PipeZeroByteRead(PLXT_ARGS Args);
112 static const LXT_VARIATION g_LxtVariations[] = {
113 {"Pipe0", PipeVariation0},
114 {"Pipe1", PipeVariation1},
115 - {"Pipe reader hanup", PipeReaderHangup},
116 - {"Pipe writer hanup", PipeWriterHangup},
115 + {"Pipe reader hangup", PipeReaderHangup},
116 + {"Pipe writer hangup", PipeWriterHangup},
117 {"Pipe ioctls", PipeVariationIoctl},
118 {"Pipe - epoll", PipeEpoll},
119 {"Pipe - Fifo", PipeFifo},
@@ -1983,7 +1983,7 @@ Return Value:
1983 LxtCheckErrnoFailure(fcntl(Pipes[1], F_SETPIPE_SZ, sizeof(Buffer) - 1), EBUSY);
1984
1985 //
1986 - // Try to increase the buffer from an unprivlided thread.
1986 + // Try to increase the buffer from an unprivileged thread.
1987 //
1988
1989 LxtCheckErrno(ChildPid = fork());
test/linux/unit_tests/random.c
+4 -4
@@ -102,7 +102,7 @@ int GetrandomSyscall(PLXT_ARGS Args)
102 if (Result > DEV_URANDOM_MAX_BYTES)
103 {
104 Result = LXT_RESULT_FAILURE;
105 - LxtLogError("BytesRead %Iu higher than expected %Iu", Result, DEV_URANDOM_MAX_BYTES);
105 + LxtLogError("BytesRead %Iu greater than expected %Iu", Result, DEV_URANDOM_MAX_BYTES);
106
107 goto ErrorExit;
108 }
@@ -111,7 +111,7 @@ int GetrandomSyscall(PLXT_ARGS Args)
111 if (Result > DEV_RANDOM_MAX_BYTES)
112 {
113 Result = LXT_RESULT_FAILURE;
114 - LxtLogError("BytesRead %Iu higher than expected %Iu", Result, DEV_RANDOM_MAX_BYTES);
114 + LxtLogError("BytesRead %Iu greater than expected %Iu", Result, DEV_RANDOM_MAX_BYTES);
115
116 goto ErrorExit;
117 }
@@ -150,7 +150,7 @@ int DevRandomDevice(PLXT_ARGS Args)
150 if (BytesRead > DEV_RANDOM_MAX_BYTES)
151 {
152 Result = LXT_RESULT_FAILURE;
153 - LxtLogError("BytesRead %d higher than expected %d", BytesRead, DEV_RANDOM_MAX_BYTES);
153 + LxtLogError("BytesRead %d greater than expected %d", BytesRead, DEV_RANDOM_MAX_BYTES);
154
155 goto ErrorExit;
156 }
@@ -190,7 +190,7 @@ int DevUrandomDevice(PLXT_ARGS Args)
190 if (BytesRead > DEV_URANDOM_MAX_BYTES)
191 {
192 Result = LXT_RESULT_FAILURE;
193 - LxtLogError("BytesRead %d higher than expected %d", BytesRead, DEV_URANDOM_MAX_BYTES);
193 + LxtLogError("BytesRead %d greater than expected %d", BytesRead, DEV_URANDOM_MAX_BYTES);
194
195 goto ErrorExit;
196 }
test/linux/unit_tests/resourcelimits.c
+1 -1
@@ -221,7 +221,7 @@ int ResourceLimitNoFile(PLXT_ARGS Args)
221
222 //
223 // Determine how many file descriptors are already open and allocate an
224 - // array large enough to open the maxiumum number of file descriptors.
224 + // array large enough to open the maximum number of file descriptors.
225 //
226
227 LxtLogInfo("%d currently open file descriptors", InitialFileDescriptorCount);
test/linux/unit_tests/sched.c
+1 -1
@@ -319,7 +319,7 @@ int SetGetAffinityNp(PLXT_ARGS Args)
319 LxtCheckErrno(LxtSched_GetAffinity(0, sizeof(Set), &Set));
320
321 //
322 - // N.B Affinity cannot be validated because its not gauranteed for it to
322 + // N.B Affinity cannot be validated because its not guaranteed for it to
323 // take affect.
324 //
325
test/linux/unit_tests/select.c
+1 -1
@@ -119,7 +119,7 @@ int SelectFdBufferSize(PLXT_ARGS Args)
119 //
120 // Test select with different sized buffers that have all of the bits set
121 // and a ReadSetCount of 1. The expectation is that the write will fail if
122 - // the buffer is less an an unsigned long. If larger, the values will be
122 + // the buffer is less than an unsigned long. If larger, the values will be
123 // zeroed out to an unsigned long but not more.
124 //
125
test/linux/unit_tests/sem.c
+5 -5
@@ -465,7 +465,7 @@ int SemGetSyscall(PLXT_ARGS Args)
465 // N.B. There appears to be no error checking for invalid flags, only the
466 // presence of valid flags.
467 //
468 - // -1 includes the IPC_EXCL flag so this shoudl return EEXIST.
468 + // -1 includes the IPC_EXCL flag so this should return EEXIST.
469 //
470
471 LxtCheckErrnoFailure(LxtSemGet(Key, SEM_COUNT, -1), EEXIST);
@@ -812,7 +812,7 @@ int SemOpFlags(PLXT_ARGS Args)
812 LXT_SYNCHRONIZATION_POINT();
813
814 //
815 - // Wait for child to perform second operation and set the smeaphore value
815 + // Wait for child to perform second operation and set the semaphore value
816 // to zero. This should remove the pending semaphore adjustment.
817 //
818
@@ -922,7 +922,7 @@ int SemOpFlags(PLXT_ARGS Args)
922 LxtCheckEqual(0, LxtSemCtl(Id, 1, GETVAL, NULL), "%d");
923
924 //
925 - // Create two threads, one sharing the sempahore adjustment structure
925 + // Create two threads, one sharing the semaphore adjustment structure
926 // and one not.
927 //
928
@@ -1237,7 +1237,7 @@ int SemOpSyscall(PLXT_ARGS Args)
1237 //
1238 // Fill the operations buffer with a combination of valid operations
1239 // and operations that the caller does not have permission to do. The
1240 - // parent will verify the the semaphore values are adjusted correctly.
1240 + // parent will verify the semaphore values are adjusted correctly.
1241 //
1242
1243 memset(Operations, 0, sizeof(Operations));
@@ -1312,7 +1312,7 @@ int SemOpSyscall(PLXT_ARGS Args)
1312 }
1313
1314 //
1315 - // Wait for the child to do the fisrt semop and query the values.
1315 + // Wait for the child to do the first semop and query the values.
1316 //
1317
1318 LXT_SYNCHRONIZATION_POINT(); // (1)
test/linux/unit_tests/shm.c
+19 -19
@@ -575,7 +575,7 @@ int ShmAtAccess(PLXT_ARGS Args)
575
576 //
577 // Change the caller GID and attempt to map, this should still fail
578 - // because the caller has a supplimentaty group membership.
578 + // because the caller has a supplementary group membership.
579 //
580
581 LxtCheckErrno(setgid(SHM_ACCESS_GID));
@@ -588,7 +588,7 @@ int ShmAtAccess(PLXT_ARGS Args)
588 }
589
590 //
591 - // Drop supplimentary group membership, finally this should succeed.
591 + // Drop supplementary group membership, finally this should succeed.
592 //
593
594 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -899,7 +899,7 @@ int ShmAtDtSyscall(PLXT_ARGS Args)
899 LxtCheckEqual(Stat.shm_nattch, 1, "%Iu");
900
901 //
902 - // Use detatch to clear the range.
902 + // Use detach to clear the range.
903 //
904
905 LxtCheckErrno(LxtShmDt(Address));
@@ -1076,7 +1076,7 @@ int ShmAtDtSyscall(PLXT_ARGS Args)
1076 LxtCheckEqual(Stat.shm_nattch, 2, "%Iu");
1077
1078 //
1079 - // Detatch both mapped regions.
1079 + // Detach both mapped regions.
1080 //
1081
1082 LxtCheckErrno(LxtShmDt(Address));
@@ -1136,7 +1136,7 @@ int ShmAtDtSyscall(PLXT_ARGS Args)
1136 LxtCheckEqual(Stat.shm_nattch, 2, "%Iu");
1137
1138 //
1139 - // Detatch the original address and validate the second region remains.
1139 + // Detach the original address and validate the second region remains.
1140 //
1141
1142 LxtCheckErrno(LxtShmDt(Address));
@@ -1278,7 +1278,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1278 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1279
1280 //
1281 - // Drop supplimentary group membership.
1281 + // Drop supplementary group membership.
1282 //
1283
1284 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -1371,7 +1371,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1371 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1372
1373 //
1374 - // Drop supplimentary group membership.
1374 + // Drop supplementary group membership.
1375 //
1376
1377 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -1451,7 +1451,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1451 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1452
1453 //
1454 - // Change the GID (callers still has supplimentary group membership so
1454 + // Change the GID (callers still has supplementary group membership so
1455 // this should succeed).
1456 //
1457
@@ -1465,7 +1465,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1465 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1466
1467 //
1468 - // Drop supplimentary group membership.
1468 + // Drop supplementary group membership.
1469 //
1470
1471 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -1545,7 +1545,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1545 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1546
1547 //
1548 - // Change the GID (callers still has supplimentary group membership so
1548 + // Change the GID (callers still has supplementary group membership so
1549 // this should succeed).
1550 //
1551
@@ -1559,7 +1559,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1559 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1560
1561 //
1562 - // Drop supplimentary group membership (this should succeed).
1562 + // Drop supplementary group membership (this should succeed).
1563 //
1564
1565 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -1647,7 +1647,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1647 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1648
1649 //
1650 - // Change the GID (callers still has supplimentary group membership so
1650 + // Change the GID (callers still has supplementary group membership so
1651 // this should succeed).
1652 //
1653
@@ -1665,7 +1665,7 @@ int ShmGetAccess(PLXT_ARGS Args)
1665 LxtCheckEqual(Id, LxtShmGet(Key, PAGE_SIZE, 0000), "%Iu");
1666
1667 //
1668 - // Drop supplimentary group membership (this should succeed).
1668 + // Drop supplementary group membership (this should succeed).
1669 //
1670
1671 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -1854,7 +1854,7 @@ int ShmGetSyscall(PLXT_ARGS Args)
1854 // N.B. There appears to be no error checking for invalid flags, only the
1855 // presence of valid flags.
1856 //
1857 - // -1 includes the IPC_EXCL flag so this shoudl return EEXIST.
1857 + // -1 includes the IPC_EXCL flag so this should return EEXIST.
1858 //
1859
1860 LxtCheckErrnoFailure(LxtShmGet(Key, PAGE_SIZE, -1), EEXIST);
@@ -2035,7 +2035,7 @@ int ShmCtlSyscall(PLXT_ARGS Args)
2035 LxtCheckErrno(LxtShmCtl(Id, IPC_SET, &Stat));
2036
2037 //
2038 - // Drop supplimentary group membership.
2038 + // Drop supplementary group membership.
2039 //
2040
2041 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -2114,7 +2114,7 @@ int ShmCtlSyscall(PLXT_ARGS Args)
2114 LxtCheckErrno(LxtShmCtl(Id, IPC_SET, &Stat));
2115
2116 //
2117 - // Drop supplimentary group membership.
2117 + // Drop supplementary group membership.
2118 //
2119
2120 LxtCheckErrno(Result = setgroups(0, NULL));
@@ -2366,7 +2366,7 @@ int ShmCtlSyscall(PLXT_ARGS Args)
2366
2367 //
2368 // Generate an ID that does not refer to a valid memory region and attempt
2369 - // operations on the non-existent region.
2369 + // operations on the nonexistent region.
2370 //
2371
2372 do
@@ -2408,7 +2408,7 @@ Routine Description:
2408 and the parent and
2409 child communicate across a unix socket connection. Each side queries the
2410 credentials of the other side via SO_PEERCRED and ancillary messages and
2411 - validates that the appriate credentials are returned.
2411 + validates that the appropriate credentials are returned.
2412
2413 Arguments:
2414
@@ -2467,7 +2467,7 @@ Return Value:
2467 LxtLogInfo("Child's view of ChildPid %d", getpid());
2468
2469 //
2470 - // Attatch the shared segment.
2470 + // Attach the shared segment.
2471 //
2472
2473 LxtCheckMapErrno(Address2 = LxtShmAt(Id, NULL, 0));
test/linux/unit_tests/socket.c
+1 -1
@@ -91,7 +91,7 @@ static const LXT_VARIATION g_LxtClientVariations[] = {
91
92 //
93 // N.B. Keep the number of variations up to date with
94 -// LXT_SOCKET_NUM_SERVER_VARAITIONS in socket/common.h
94 +// LXT_SOCKET_NUM_SERVER_VARIATIONS in socket/common.h
95 //
96
97 static const LXT_VARIATION g_LxtServerVariations[] = {
test/linux/unit_tests/socket_nonblock.c
+1 -1
@@ -424,7 +424,7 @@ const char* NonblockDataToWrite[] = {
424 "<This is the first message> ",
425 "<This is another message> ",
426 "<Dumbledore is dead> ",
427 - "<Harry Potter must not go back to Hogwards> ",
427 + "<Harry Potter must not go back to Hogwarts> ",
428 "<There must always be a stark in Winterfell>",
429 };
430
test/linux/unit_tests/timer.c
+9 -9
@@ -161,7 +161,7 @@ int ITimerPerThreadGroup(PLXT_ARGS Args)
161 pthread_t Thread = {0};
162
163 //
164 - // Check that the timer is per threadgroup and not preserved accross fork.
164 + // Check that the timer is per threadgroup and not preserved across fork.
165 //
166
167 memset(&NewTimer, 0, sizeof(NewTimer));
@@ -222,7 +222,7 @@ int ITimerSignal(PLXT_ARGS Args)
222 //
223
224 //
225 - // Default disposistion should terminate
225 + // Default disposition should terminate
226 //
227
228 LxtCheckResult(ChildPid = fork());
@@ -238,7 +238,7 @@ int ITimerSignal(PLXT_ARGS Args)
238 LxtCheckResult(LxtWaitPidPollOptions(ChildPid, SIGALRM, 0, LXT_SHORT_TIMER_WAIT_PID));
239
240 //
241 - // Default disposistion should not terminate if canceled.
241 + // Default disposition should not terminate if canceled.
242 //
243
244 LxtCheckResult(ChildPid = fork());
@@ -275,7 +275,7 @@ int ITimerSignal(PLXT_ARGS Args)
275 LxtCheckResult(LxtWaitPidPollOptions(ChildPid, LXT_RESULT_SUCCESS, 0, LXT_SHORT_TIMER_WAIT_PID));
276
277 //
278 - // Check that the signal handler is invoked within a resonable time
278 + // Check that the signal handler is invoked within a reasonable time
279 // interval.
280 //
281
@@ -328,7 +328,7 @@ int AlarmSyscall(PLXT_ARGS Args)
328 //
329
330 //
331 - // Default disposistion should terminate
331 + // Default disposition should terminate
332 //
333
334 LxtCheckResult(ChildPid = fork());
@@ -342,7 +342,7 @@ int AlarmSyscall(PLXT_ARGS Args)
342 LxtCheckResult(LxtWaitPidPollOptions(ChildPid, SIGALRM, 0, LXT_SHORT_TIMER_WAIT_PID));
343
344 //
345 - // Default disposistion should not terminate if canceled.
345 + // Default disposition should not terminate if canceled.
346 //
347
348 LxtCheckResult(ChildPid = fork());
@@ -380,7 +380,7 @@ int AlarmSyscall(PLXT_ARGS Args)
380 LxtCheckResult(LxtWaitPidPollOptions(ChildPid, LXT_RESULT_SUCCESS, 0, LXT_SHORT_TIMER_WAIT_PID));
381
382 //
383 - // Check that the signal handler is invoked within a resonable time
383 + // Check that the signal handler is invoked within a reasonable time
384 // interval.
385 //
386
@@ -440,7 +440,7 @@ int ITimerPeriodicSignal(PLXT_ARGS Args)
440 struct itimerval NewTimer;
441
442 //
443 - // Check that the signal handler is invoked within a resonable time
443 + // Check that the signal handler is invoked within a reasonable time
444 // interval.
445 //
446
@@ -654,7 +654,7 @@ int TimerCreateSyscall(PLXT_ARGS Args)
654 LxtCheckResult(sigprocmask(SIG_UNBLOCK, &SigMask, NULL));
655
656 //
657 - // Wait for the signal to be delievered.
657 + // Wait for the signal to be delivered.
658 //
659
660 LxtCheckErrno(Signal = sigtimedwait(&SigMask, &SignalInfo, NULL));
test/linux/unit_tests/timerfd.c
+2 -2
@@ -152,7 +152,7 @@ int TimerFdBasic(PLXT_ARGS Args)
152 }
153
154 //
155 - // Set timer fd to exipre at one second interval.
155 + // Set timer fd to expire at one second interval.
156 //
157
158 Flags = 0;
@@ -196,7 +196,7 @@ int TimerFdBasic(PLXT_ARGS Args)
196
197 //
198 // Loop three times. In each iteration increase the wait time by one seconds.
199 - // this should increase the expiration count by one in each interation.
199 + // this should increase the expiration count by one in each iteration.
200 //
201
202 for (LoopIndex = 1; LoopIndex <= LXT_BASIC_TEST_LOOP_COUNT; LoopIndex += 1)
test/linux/unit_tests/ttys.c
+1 -1
@@ -725,7 +725,7 @@ int TtysWriteReadTransfer(PLXT_ARGS Args, int FdRead, int FdWrite)
725 SendBuffer = NULL;
726
727 //
728 - // Allocate a buffer with known data to transfer and a buffer to recieve
728 + // Allocate a buffer with known data to transfer and a buffer to receive
729 // the data.
730 //
731
test/linux/unit_tests/vfsaccess.c
+14 -14
@@ -107,7 +107,7 @@ struct reuid_t
107
108 int VfsAccessCheckResult(int ResultActual, int ResultExpected, int ErrnoActual, int ErrnoExpected, char* Message, int VariationIndex);
109
110 -void VfsAcccessFileObjectCleanup(void);
110 +void VfsAccessFileObjectCleanup(void);
111
112 int VfsAccessFileObjectCreateFiles(void);
113
@@ -217,7 +217,7 @@ ErrorExit:
217 return !LXT_SUCCESS(Result);
218 }
219
220 -void VfsAcccessFileObjectCleanup(void)
220 +void VfsAccessFileObjectCleanup(void)
221
222 /*++
223
@@ -1027,7 +1027,7 @@ void VfsAccessChmodCapChild(void)
1027 CapData[1].effective = CapData[1].permitted;
1028
1029 //
1030 - // Drop privlidges so the current process does not have CAP_FOWNER.
1030 + // Drop privileges so the current process does not have CAP_FOWNER.
1031 //
1032
1033 LxtCheckErrno(prctl(PR_SET_KEEPCAPS, 1));
@@ -1108,7 +1108,7 @@ void VfsAccessOPathChild(void)
1108 Fd = -1;
1109
1110 //
1111 - // Drop privlidges so the current process does not have VFS related
1111 + // Drop privileges so the current process does not have VFS related
1112 // capabilities.
1113 //
1114
@@ -1249,7 +1249,7 @@ void VfsAccessRenameCapChild(void)
1249 CapData[1].effective = CapData[1].permitted;
1250
1251 //
1252 - // Drop privlidges so the current process does not have CAP_FOWNER.
1252 + // Drop privileges so the current process does not have CAP_FOWNER.
1253 //
1254
1255 LxtCheckErrno(prctl(PR_SET_KEEPCAPS, 1));
@@ -1305,7 +1305,7 @@ void VfsAccessRmdirCapChild(void)
1305 CapData[1].effective = CapData[1].permitted;
1306
1307 //
1308 - // Drop privlidges so the current process does not have CAP_FOWNER.
1308 + // Drop privileges so the current process does not have CAP_FOWNER.
1309 //
1310
1311 LxtCheckErrno(prctl(PR_SET_KEEPCAPS, 1));
@@ -1651,7 +1651,7 @@ int VfsAccessSetUserGroupId(PLXT_ARGS Args)
1651 if (g_LxtFsInfo.FsType != LxtFsTypeVirtioFs)
1652 {
1653 //
1654 - // Fork and drop privlidges so the current process does not have CAP_FOWNER
1654 + // Fork and drop privileges so the current process does not have CAP_FOWNER
1655 // which is required for changing the owner of a file with the set-user-id
1656 // or set-group-id bits set.
1657 //
@@ -1775,7 +1775,7 @@ void VfsAccessInodeChecksChild(void)
1775 CapHeader.version = _LINUX_CAPABILITY_VERSION_3;
1776
1777 //
1778 - // Drop privlidges so the current process does not have VFS capabilities
1778 + // Drop privileges so the current process does not have VFS capabilities
1779 // and is in the other user\group.
1780 //
1781
@@ -1785,8 +1785,8 @@ void VfsAccessInodeChecksChild(void)
1785 LxtCheckErrno(LxtCapSet(&CapHeader, CapData));
1786
1787 //
1788 - // For each file, check that read, write and execute is enforced. Similiarly
1789 - // for directotries check that list, create\delete, and search is enforced.
1788 + // For each file, check that read, write and execute is enforced. Similarly
1789 + // for directories check that list, create\delete, and search is enforced.
1790 //
1791
1792 for (Index = 0; Index < LXT_COUNT_OF(g_VfsInodeEntries); ++Index)
@@ -2106,7 +2106,7 @@ ErrorExit:
2106
2107 if (Cleanup != false)
2108 {
2109 - VfsAcccessFileObjectCleanup();
2109 + VfsAccessFileObjectCleanup();
2110 LxtFsTestCleanup(VFS_ACCESS_PARENT_DIR, "/vfsaccesstest", g_UseDrvFs);
2111 }
2112
@@ -2135,7 +2135,7 @@ void VfsAccessUTimeCapChild(void)
2135 CapData[1].effective = CapData[1].permitted;
2136
2137 //
2138 - // Drop privlidges so the current process does not have CAP_FOWNER.
2138 + // Drop privileges so the current process does not have CAP_FOWNER.
2139 //
2140
2141 LxtCheckErrno(prctl(PR_SET_KEEPCAPS, 1));
@@ -2267,7 +2267,7 @@ int VfsAccessSetFsUid(PLXT_ARGS Args)
2267 }
2268
2269 //
2270 - // Verify tha topening a the file fails since we no longer have the correct fsuid or capabilities.
2270 + // Verify that opening the file fails since we no longer have the correct fsuid or capabilities.
2271 //
2272
2273 LxtCheckErrnoFailure(open(VFS_ACCESS_FSUID_FILE, O_RDWR), EACCES);
@@ -2469,7 +2469,7 @@ int VfsAccessSetUid(PLXT_ARGS Args)
2469 //
2470 // This test checks that unprivileged processes can Set the euid
2471 // to the ruid or suid. Need to fork and wait as privileges are
2472 - // irreversably dropped by this syscall
2472 + // irreversibly dropped by this syscall
2473 //
2474
2475 if (fork_wait() == 0)
test/linux/unit_tests/vnet.c
+2 -2
@@ -139,7 +139,7 @@ static const LXT_VARIATION g_LxtVariations[] = {
139 //{"Virtual Ethernet Pair namespace data check", VirtualEthernetPairNamespaceData},
140
141 //
142 - // Moving physical adpaters between namespaces is not currently supported
142 + // Moving physical adapters between namespaces is not currently supported
143 //
144
145 //{"Physical device basic namespace check", PhysicalDeviceNamespace1},
@@ -675,7 +675,7 @@ int DeleteVirtualDeviceViaNetlink(const char* Name)
675
676 Routine Description:
677
678 - This routine removes a virtual device using the netlink RTM_DELLLINK
678 + This routine removes a virtual device using the netlink RTM_DELLINK
679 message.
680
681 Arguments:
test/windows/Common.cpp
+3 -3
@@ -1110,7 +1110,7 @@ Arguments:
1110
1111 String - Supplies the string to split.
1112
1113 - Delim - The deliminiter to split the string on.
1113 + Delim - The delimiter to split the string on.
1114
1115 Return Value:
1116
@@ -1142,7 +1142,7 @@ Return Value:
1142 return output;
1143 }
1144
1145 -// WslKeepAlive class defintions
1145 +// WslKeepAlive class definitions
1146
1147 WslKeepAlive::WslKeepAlive(HANDLE Token) : m_token(Token)
1148 {
@@ -2141,7 +2141,7 @@ Return Value:
2141 if (!g_originalDefaultDistro.empty())
2142 {
2143 // Edge case: If the previous default distro was the test distro, it might have been deleted during the testpass.
2144 - // Validate the the distro exists before restoring.
2144 + // Validate the distro exists before restoring.
2145
2146 const auto userKey = wsl::windows::common::registry::OpenLxssUserKey();
2147
test/windows/InstallerTests.cpp
+13 -13
@@ -332,7 +332,7 @@ class InstallerTests
332 wsl::windows::common::registry::DeleteKeyValue(msiKey.get(), L"ProductCode");
333 }
334
335 - void InstallGitubRelease(const std::wstring& version)
335 + void InstallGitHubRelease(const std::wstring& version)
336 {
337 auto arch = wsl::shared::Arm64 ? L".0.arm64" : L".0.x64";
338
@@ -354,8 +354,8 @@ class InstallerTests
354 LogInfo("Downloading: %ls", version.c_str());
355
356 VERIFY_IS_TRUE(g_pipelineBuildId.empty()); // Pipeline builds should have the installers already available
357 - auto release = wsl::windows::common::wslutil::GetGithubReleaseByTag(version);
358 - auto asset = wsl::windows::common::wslutil::GetGithubAssetFromRelease(release);
357 + auto release = wsl::windows::common::wslutil::GetGitHubReleaseByTag(version);
358 + auto asset = wsl::windows::common::wslutil::GetGitHubAssetFromRelease(release);
359 VERIFY_IS_TRUE(asset.has_value());
360
361 auto downloadPath = wsl::windows::common::wslutil::DownloadFile(asset->second.url, asset->second.name);
@@ -383,9 +383,9 @@ class InstallerTests
383 TEST_METHOD(UpgradeFromWsl130)
384 {
385 UninstallMsi();
386 - InstallGitubRelease(L"1.3.17");
386 + InstallGitHubRelease(L"1.3.17");
387
388 - // Note: we can't use wsl --update here because GithubUrlOverride was introduced in 2.0.0
388 + // Note: we can't use wsl --update here because GitHubUrlOverride was introduced in 2.0.0
389 InstallMsi();
390 ValidatePackageInstalledProperly();
391 }
@@ -395,7 +395,7 @@ class InstallerTests
395 UninstallMsi();
396
397 // Note: we can't use wsl --update here because wsl 2.0.0 passes REINSTALL=ALL to msiexec
398 - InstallGitubRelease(L"2.0.0");
398 + InstallGitHubRelease(L"2.0.0");
399 InstallMsi();
400 ValidatePackageInstalledProperly();
401 }
@@ -403,7 +403,7 @@ class InstallerTests
403 TEST_METHOD(UpgradeFromWsl202)
404 {
405 UninstallMsi();
406 - InstallGitubRelease(L"2.0.2");
406 + InstallGitHubRelease(L"2.0.2");
407 CallWslUpdateViaMsi();
408 }
409
@@ -651,7 +651,7 @@ class InstallerTests
651 RegistryKeyChange<std::wstring> change(
652 HKEY_LOCAL_MACHINE, L"Software\\Microsoft\\Windows\\CurrentVersion\\Lxss", wsl::windows::common::wslutil::c_githubUrlOverrideRegistryValue, endpoint);
653
654 - constexpr auto GithubApiResponse =
654 + constexpr auto GitHubApiResponse =
655 LR"({
656 \"name\": \"1.0.0\",
657 \"created_at\": \"2023-06-14T16:56:30Z\",
@@ -664,7 +664,7 @@ class InstallerTests
664 ]
665 })";
666
667 - UniqueWebServer server(endpoint, GithubApiResponse);
667 + UniqueWebServer server(endpoint, GitHubApiResponse);
668
669 auto [out, _] = LxsstuLaunchWslAndCaptureOutput(L"--update");
670 VERIFY_ARE_EQUAL(
@@ -899,7 +899,7 @@ class InstallerTests
899 RegistryKeyChange<std::wstring> change(
900 HKEY_LOCAL_MACHINE, L"Software\\Microsoft\\Windows\\CurrentVersion\\Lxss", wsl::windows::common::wslutil::c_githubUrlOverrideRegistryValue, endpoint);
901
902 - constexpr auto GithubApiResponse =
902 + constexpr auto GitHubApiResponse =
903 LR"({
904 \"name\": \"999.0.0\",
905 \"created_at\": \"2023-06-14T16:56:30Z\",
@@ -912,7 +912,7 @@ class InstallerTests
912 ]
913 })";
914
915 - UniqueWebServer apiServer(endpoint, GithubApiResponse);
915 + UniqueWebServer apiServer(endpoint, GitHubApiResponse);
916 UniqueWebServer fileServer(L"http://127.0.0.1:12346/", std::filesystem::path(m_msiPath));
917
918 // DeleteProductCode();
@@ -946,7 +946,7 @@ class InstallerTests
946 RegistryKeyChange<std::wstring> change(
947 HKEY_LOCAL_MACHINE, L"Software\\Microsoft\\Windows\\CurrentVersion\\Lxss", wsl::windows::common::wslutil::c_githubUrlOverrideRegistryValue, endpoint);
948
949 - constexpr auto GithubApiResponse =
949 + constexpr auto GitHubApiResponse =
950 LR"({
951 \"name\": \"999.0.0\",
952 \"created_at\": \"2023-06-14T16:56:30Z\",
@@ -959,7 +959,7 @@ class InstallerTests
959 ]
960 })";
961
962 - UniqueWebServer apiServer(endpoint, GithubApiResponse);
962 + UniqueWebServer apiServer(endpoint, GitHubApiResponse);
963 UniqueWebServer fileServer(L"http://127.0.0.1:12346/", std::filesystem::path(m_msixPackagePath));
964
965 UninstallMsix();
test/windows/MountTests.cpp
+1 -1
@@ -1172,7 +1172,7 @@ class MountTests
1172 VERIFY_ARE_EQUAL(mount.value()[1], Mountpoint.value());
1173 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"test -d " + Mountpoint.value()), (DWORD)0);
1174
1175 - // If specifed, validate that ExpectedOption is in the mount options
1175 + // If specified, validate that ExpectedOption is in the mount options
1176 // (We don't want to do a direct compare because the kernel might add some like rw, ...)
1177 if (ExpectedOption.has_value())
1178 {
test/windows/NetworkTests.cpp
+4 -4
@@ -2634,7 +2634,7 @@ class NetworkTests
2634
2635 // Because the test creates a new network namespace, the resolv.conf from the root network namespace
2636 // is copied in the resolv.conf of the new network namespace. The DNS tunneling listener running in the root namespace
2637 - // needs to be accesible from the new namespace, so it can't use a 127* IP.
2637 + // needs to be accessible from the new namespace, so it can't use a 127* IP.
2638 WslConfigChange config(LxssGenerateTestConfig({
2639 .guiApplications = true,
2640 .dnsTunneling = true,
@@ -2662,7 +2662,7 @@ class NetworkTests
2662
2663 // Because the test creates a new network namespace, the resolv.conf from the root network namespace
2664 // is copied in the resolv.conf of the new network namespace. The DNS tunneling listener running in the root namespace
2665 - // needs to be accesible from the new namespace, so it can't use a 127* IP
2665 + // needs to be accessible from the new namespace, so it can't use a 127* IP
2666 WslConfigChange config(LxssGenerateTestConfig(
2667 {.guiApplications = true, .networkingMode = wsl::core::NetworkingMode::Mirrored, .dnsTunneling = true, .dnsTunnelingIpAddress = L"10.255.255.254"}));
2668 WaitForMirroredStateInLinux();
@@ -2886,7 +2886,7 @@ class NetworkTests
2886 {
2887 // Verify that we have an initially working connection.
2888 // This also ensures that WSL is started to allow for
2889 - // valdiating the initial Hyper-V port state
2889 + // validating the initial Hyper-V port state
2890 GuestClient(L"tcp-connect:bing.com:80");
2891
2892 if (expectHyperVFirewallObjects == FirewallObjects::Required)
@@ -2952,7 +2952,7 @@ class NetworkTests
2952 static auto AddFirewallRuleAndValidateTraffic(const FirewallRule& rule, FirewallTestConnectivity expectedConnectivityAfterRule)
2953 {
2954 LogInfo(
2955 - "Validing ruleType=[%ls] name=[%ls] and expectedConnectivity=[%ls]",
2955 + "Validating ruleType=[%ls] name=[%ls] and expectedConnectivity=[%ls]",
2956 (rule.Type == FirewallType::Host) ? L"Host" : L"HyperV",
2957 rule.Name.c_str(),
2958 expectedConnectivityAfterRule == FirewallTestConnectivity::Allowed ? L"Allowed" : L"Blocked");
test/windows/PluginTests.cpp
+2 -2
@@ -168,7 +168,7 @@ class PluginTests
168 ValidateLogFile(ExpectedOutput);
169 }
170
171 - TEST_METHOD(CustomKernelOverridenByPolicy)
171 + TEST_METHOD(CustomKernelOverriddenByPolicy)
172 {
173 WSL2_TEST_ONLY();
174
@@ -594,7 +594,7 @@ class PluginTests
594 LR"(Plugin loaded. TestMode=15
595 VM created (settings->CustomConfigurationFlags=0)
596 Distribution registered, name=plugin-test-distro, package=, Flavor=debian, Version=12
597 - OnDistributionRegisted: E_UNEXPECTED
597 + OnDistributionRegistered: E_UNEXPECTED
598 Distribution unregistered, name=plugin-test-distro, package=, Flavor=debian, Version=12
599 OnDistributionUnregistered: E_UNEXPECTED
600 VM Stopping)";
test/windows/PolicyTests.cpp
+2 -2
@@ -281,7 +281,7 @@ class PolicyTest
281 auto revert = SetPolicy(c_allowDebugShellUserSetting, 0);
282 WslShutdown();
283
284 - // Only testing the negative case since the debug shell is difficult to programatically exit.
284 + // Only testing the negative case since the debug shell is difficult to programmatically exit.
285
286 WslKeepAlive keepAlive;
287 ValidateOutput(L"--debug-shell", L"The debug shell is disabled by the computer policy.\r\n", L"", 1);
@@ -378,7 +378,7 @@ class PolicyTest
378 // Ensure the top-level disable WSL policy works.
379 testPolicy(wsl::windows::policies::c_allowWSL, HRESULT_FROM_WIN32(ERROR_ACCESS_DISABLED_BY_POLICY), restartService);
380
381 - // Verfiy the disable inbox WSL policy does not block lifted.
381 + // Verify the disable inbox WSL policy does not block lifted.
382 testPolicy(wsl::windows::policies::c_allowInboxWSL, S_OK, restartService);
383 }
384
test/windows/SimpleTests.cpp
+2 -2
@@ -183,8 +183,8 @@ class SimpleTests
183 {nullptr, std::nullopt},
184 {"", std::nullopt},
185 {"2", std::nullopt},
186 - {"tru", std::nullopt},
187 - {"fals", std::nullopt},
186 + {"true_", std::nullopt},
187 + {"false_", std::nullopt},
188 };
189
190 for (const auto& [input, expected] : boolTests)
test/windows/UnitTests.cpp
+33 -33
@@ -373,7 +373,7 @@ class UnitTests
373 // Enable systemd (restarts distro).
374 auto cleanupSystemd = EnableSystemd("protectBinfmt=false");
375
376 - // Validate that WSL's binfmt interpreter is overriden
376 + // Validate that WSL's binfmt interpreter is overridden
377 auto [output, _] = LxsstuLaunchWslAndCaptureOutput(L"cmd.exe /c echo ok");
378 VERIFY_IS_TRUE(wsl::shared::string::IsEqual(output, L"/mnt/c/Windows/system32/cmd.exe cmd.exe /c echo ok\n", true));
379 }
@@ -788,7 +788,7 @@ class UnitTests
788 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"wslinfo --networking-mode | wc -l | grep 1"), 0u);
789 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"wslinfo --networking-mode -n | wc -l | grep 0"), 0u);
790
791 - // Ensure various wslinfo functionaly works as expected.
791 + // Ensure various wslinfo functionally works as expected.
792 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"wslinfo --networking-mode | grep -iF 'nat'"), 0u);
793
794 WslConfigChange config(LxssGenerateTestConfig({.networkingMode = wsl::core::NetworkingMode::None}));
@@ -1236,8 +1236,8 @@ class UnitTests
1236 L"Wsl/Service/DetachDisk/ERROR_FILE_NOT_FOUND");
1237
1238 ValidateErrorMessage(
1239 - WSL_MANAGE_ARG L" " LXSS_DISTRO_NAME_TEST L" " WSL_MANAGE_ARG_SET_SPARSE_OPTION_LONG L" fulse",
1240 - L"fulse is not a valid boolean, <true|false>",
1239 + WSL_MANAGE_ARG L" " LXSS_DISTRO_NAME_TEST L" " WSL_MANAGE_ARG_SET_SPARSE_OPTION_LONG L" false_",
1240 + L"false_ is not a valid boolean, <true|false>",
1241 L"Wsl/E_INVALIDARG");
1242
1243 const std::wstring wslConfigPath = wsl::windows::common::helpers::GetWslConfigPath();
@@ -1916,7 +1916,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND
1916
1917 // This loop is here because of a race condition when starting WSL to get the warnings.
1918 // If a p9rdr distribution startup notification arrives just before wsl.exe calls CreateInstance(),
1919 - // the warnings will be 'consummed' before wsl.exe can read them.
1919 + // the warnings will be 'consumed' before wsl.exe can read them.
1920 // To work around that, loop for up to 2 minutes while we don't get any warnings
1921
1922 const auto deadline = std::chrono::steady_clock::now() + std::chrono::minutes(2);
@@ -1973,7 +1973,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND
1973
1974 // This loop is here because of a race condition when starting WSL to get the warnings.
1975 // If a p9rdr distribution startup notification arrives just before wsl.exe calls CreateInstance(),
1976 - // the warnings will be 'consummed' before wsl.exe can read them.
1976 + // the warnings will be 'consumed' before wsl.exe can read them.
1977 // To work around that, loop for up to 2 minutes while we don't get any warnings
1978
1979 const auto deadline = std::chrono::steady_clock::now() + std::chrono::minutes(2);
@@ -2568,7 +2568,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND
2568 auto cleanup =
2569 wil::scope_exit_log(WI_DIAGNOSTICS_INFO, [&]() { LxsstuLaunchWsl(L"--set-version test_distro " + originalVersion); });
2570
2571 - // Convert the test distribuiton to the target version and back to the original.
2571 + // Convert the test distribution to the target version and back to the original.
2572 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"--set-version test_distro " + targetVersion), 0u);
2573 ValidateDistributionShortcut(LXSS_DISTRO_NAME_TEST_L, nullptr);
2574 ValidateDistributionTerminalProfile(LXSS_DISTRO_NAME_TEST_L, true);
@@ -2629,7 +2629,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND
2629
2630 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(command.c_str(), nullptr, nullptr, nullptr, nullptr), 0u);
2631
2632 - // Update .wslconfig and ensure an error is displayed if non-existent kernel or modules is specified.
2632 + // Update .wslconfig and ensure an error is displayed if nonexistent kernel or modules is specified.
2633 const std::wstring wslConfigPath = wsl::windows::common::helpers::GetWslConfigPath();
2634 const std::wstring nonExistentFile = L"DoesNotExist";
2635 WslConfigChange configChange(LxssGenerateTestConfig({.kernel = nonExistentFile.c_str()}));
@@ -3189,13 +3189,13 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND
3189 booleansToTest,
3190 },
3191 {
3192 - {.ConfigEntry = WslConfigEntry::DNSTunellingEnabled},
3192 + {.ConfigEntry = WslConfigEntry::DNSTunnelingEnabled},
3193 // This setting is only enabled when NetworkingMode != Nat && NetworkingMode != Mirrored
3194 booleansToTest,
3195 },
3196 {
3197 {.ConfigEntry = WslConfigEntry::BestEffortDNSParsingEnabled},
3198 - // This setting is only enabled when DNSTunellingEnabled = true
3198 + // This setting is only enabled when DNSTunnelingEnabled = true
3199 booleansToTest,
3200 },
3201 {
@@ -3351,7 +3351,7 @@ autoProxy=false
3351
3352 VERIFY_ARE_EQUAL(setWslConfigSetting(wslConfig, wslConfigSettingWriteOut), ERROR_SUCCESS);
3353
3354 - // Write out a new setting that doesn't exist in the original config but its' section
3354 + // Write out a new setting that doesn't exist in the original config but its section
3355 // does. The new setting should be appended to that section. There are two cases here::
3356 wslConfigSettingWriteOut.ConfigEntry = WslConfigEntry::HardwarePerformanceCountersEnabled;
3357 wslConfigSettingWriteOut.BoolValue = true;
@@ -4013,7 +4013,7 @@ VERSION_ID="Invalid|Format"
4013 };
4014
4015 auto InstallFromTar =
4016 - [](LPCWSTR TarName, LPCWSTR ExtraArgs = L"", int ExpectedExitCode = 0, LPCWSTR ExpectedOutput = nullptr, LPCWSTR ExpextedWarnings = nullptr) {
4016 + [](LPCWSTR TarName, LPCWSTR ExtraArgs = L"", int ExpectedExitCode = 0, LPCWSTR ExpectedOutput = nullptr, LPCWSTR ExpectedWarnings = nullptr) {
4017 auto [out, err] = LxsstuLaunchWslAndCaptureOutput(
4018 std::format(L"--install --no-launch --from-file {} {}", TarName, ExtraArgs), ExpectedExitCode);
4019
@@ -4022,9 +4022,9 @@ VERSION_ID="Invalid|Format"
4022 VERIFY_ARE_EQUAL(ExpectedOutput, out);
4023 }
4024
4025 - if (ExpextedWarnings != nullptr)
4025 + if (ExpectedWarnings != nullptr)
4026 {
4027 - VERIFY_ARE_EQUAL(ExpextedWarnings, err);
4027 + VERIFY_ARE_EQUAL(ExpectedWarnings, err);
4028 }
4029 };
4030
@@ -4158,7 +4158,7 @@ Error code: Wsl/Service/RegisterDistro/WSL_E_DISTRIBUTION_NAME_NEEDED\r\n";
4158
4159 InstallFromTar(L"distro-no-default-name.tar", L"", -1, expectedOutput);
4160
4161 - // And suceed with --name
4161 + // And succeed with --name
4162 InstallFromTar(L"distro-no-default-name.tar", L"--name test-distro-no-default-name");
4163 ValidateDistributionStarts(L"test-distro-no-default-name");
4164
@@ -4260,7 +4260,7 @@ Error code: Wsl/Service/RegisterDistro/WSL_E_DISTRIBUTION_NAME_NEEDED\r\n";
4260 };
4261
4262 auto InstallFromVhd =
4263 - [](LPCWSTR DistroName, LPCWSTR VhdName, int ExpectedExitCode = 0, LPCWSTR ExpectedOutput = nullptr, LPCWSTR ExpextedWarnings = nullptr) {
4263 + [](LPCWSTR DistroName, LPCWSTR VhdName, int ExpectedExitCode = 0, LPCWSTR ExpectedOutput = nullptr, LPCWSTR ExpectedWarnings = nullptr) {
4264 auto [out, err] =
4265 LxsstuLaunchWslAndCaptureOutput(std::format(L"--import-in-place {} {}", DistroName, VhdName), ExpectedExitCode);
4266
@@ -4269,9 +4269,9 @@ Error code: Wsl/Service/RegisterDistro/WSL_E_DISTRIBUTION_NAME_NEEDED\r\n";
4269 VERIFY_ARE_EQUAL(ExpectedOutput, out);
4270 }
4271
4272 - if (ExpextedWarnings != nullptr)
4272 + if (ExpectedWarnings != nullptr)
4273 {
4274 - VERIFY_ARE_EQUAL(ExpextedWarnings, err);
4274 + VERIFY_ARE_EQUAL(ExpectedWarnings, err);
4275 }
4276 };
4277
@@ -4309,18 +4309,18 @@ Error code: Wsl/Service/RegisterDistro/WSL_E_DISTRIBUTION_NAME_NEEDED\r\n";
4309 VERIFY_IS_FALSE(std::filesystem::exists(shortcutPath));
4310 }
4311
4312 - // Distribution with overriden default location
4312 + // Distribution with overridden default location
4313 {
4314 - auto cleanup =
4315 - wil::scope_exit_log(WI_DIAGNOSTICS_INFO, []() { LxsstuLaunchWsl(L"--unregister test-overriden-default-location"); });
4314 + auto cleanup = wil::scope_exit_log(
4315 + WI_DIAGNOSTICS_INFO, []() { LxsstuLaunchWsl(L"--unregister test-overridden-default-location"); });
4316
4317 auto currentPath = std::filesystem::current_path();
4318 WslConfigChange wslconfig(std::format(L"[general]\ndistributionInstallPath = {}", EscapePath(currentPath.wstring())));
4319
4320 - InstallFromTar(g_testDistroPath.c_str(), L"--name test-overriden-default-location");
4321 - ValidateDistributionStarts(L"test-overriden-default-location");
4320 + InstallFromTar(g_testDistroPath.c_str(), L"--name test-overridden-default-location");
4321 + ValidateDistributionStarts(L"test-overridden-default-location");
4322
4323 - auto distroKey = OpenDistributionKey(L"test-overriden-default-location");
4323 + auto distroKey = OpenDistributionKey(L"test-overridden-default-location");
4324 VERIFY_IS_TRUE(!!distroKey);
4325
4326 auto shortcutPath = wsl::windows::common::registry::ReadString(distroKey.get(), nullptr, L"ShortcutPath", L"");
@@ -4332,7 +4332,7 @@ Error code: Wsl/Service/RegisterDistro/WSL_E_DISTRIBUTION_NAME_NEEDED\r\n";
4332 // Validate that the distribution was created in the correct path
4333 VERIFY_ARE_EQUAL(std::filesystem::path(basePath).parent_path().string(), currentPath.string());
4334
4335 - ValidateDistributionShortcut(L"test-overriden-default-location", nullptr);
4335 + ValidateDistributionShortcut(L"test-overridden-default-location", nullptr);
4336
4337 cleanup.reset();
4338
@@ -4572,7 +4572,7 @@ Error code: Wsl/Service/RegisterDistro/E_INVALIDARG\r\n";
4572 ValidateDistributionStarts(distroName);
4573 }
4574
4575 - // Distribution with a a pre-existing hide profile.
4575 + // Distribution with a preexisting hide profile.
4576 {
4577 constexpr auto distroName = L"custom-terminal-profile-hide";
4578 constexpr auto tarName = L"custom-terminal-profile-hide.tar";
@@ -4808,13 +4808,13 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND\r\n");
4808
4809 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"--unregister debian-12"), 0L);
4810
4811 - // Verify that name matching is not case sensitive on the version.
4811 + // Verify that name matching is not case-sensitive on the version.
4812 ValidateInstall(L"Debian-12 --no-launch --name debian-12");
4813 ValidateDistributionStarts(L"debian-12");
4814
4815 VERIFY_ARE_EQUAL(LxsstuLaunchWsl(L"--unregister debian-12"), 0L);
4816
4817 - // Verify that name matching is not case sensitive on the flavor.
4817 + // Verify that name matching is not case-sensitive on the flavor.
4818 ValidateInstall(L"Debian --no-launch --name debian-12");
4819 ValidateDistributionStarts(L"debian-12");
4820
@@ -4961,7 +4961,7 @@ Error code: Wsl/InstallDistro/WININET_E_CANNOT_CONNECT\r\n",
4961 L"wsl: Using legacy distribution registration. Consider using a tar based distribution instead.\r\n");
4962 }
4963
4964 - // Validate that modern distros takes precedences, but can be overriden.
4964 + // Validate that modern distros takes precedences, but can be overridden.
4965 {
4966 auto manifest = std::format(
4967 R"({{
@@ -5005,7 +5005,7 @@ Error code: Wsl/InstallDistro/WININET_E_CANNOT_CONNECT\r\n",
5005 L"wsl: Using legacy distribution registration. Consider using a tar based distribution instead.\r\n");
5006 }
5007
5008 - // Validate that distribution can be overriden
5008 + // Validate that distribution can be overridden
5009 {
5010 auto manifest = std::format(
5011 R"({{
@@ -5042,7 +5042,7 @@ Error code: Wsl/InstallDistro/WININET_E_CANNOT_CONNECT\r\n",
5042 "debian": [
5043 {{
5044 "Name": "debian-12",
5045 - "FriendlyName": "DebianFriendlyNameOverriden",
5045 + "FriendlyName": "DebianFriendlyNameOverridden",
5046 "Amd64Url": {{
5047 "Url": "{}",
5048 "Sha256": "{}"
@@ -5925,7 +5925,7 @@ Error code: Wsl/InstallDistro/WSL_E_INVALID_JSON\r\n",
5925 "name": "wsl.2.4.12.0.x64.msi"
5926 }]})";
5927
5928 - auto [version, asset] = wsl::windows::common::wslutil::GetLatestGithubRelease(false, json);
5928 + auto [version, asset] = wsl::windows::common::wslutil::GetLatestGitHubRelease(false, json);
5929
5930 VERIFY_ARE_EQUAL(version, L"2.4.12");
5931 VERIFY_ARE_EQUAL(asset.id, 2);
@@ -5959,7 +5959,7 @@ Error code: Wsl/InstallDistro/WSL_E_INVALID_JSON\r\n",
5959 "name": "2.4.13"
5960 }])";
5961
5962 - auto [version, asset] = wsl::windows::common::wslutil::GetLatestGithubRelease(true, json);
5962 + auto [version, asset] = wsl::windows::common::wslutil::GetLatestGitHubRelease(true, json);
5963
5964 VERIFY_ARE_EQUAL(version, L"2.5.1");
5965 VERIFY_ARE_EQUAL(asset.id, 2);
test/windows/testplugin/Plugin.cpp
+5 -5
@@ -29,7 +29,7 @@ std::optional<uint32_t> g_previousInitPid;
29
30 std::vector<char> ReadFromSocket(SOCKET socket)
31 {
32 - // Simplfied error handling for the sake of the demo.
32 + // Simplified error handling for the sake of the demo.
33 int result = 0;
34 int offset = 0;
35
@@ -96,7 +96,7 @@ HRESULT OnVmStarted(const WSLSessionInformation* Session, const WSLVmCreationSet
96 auto output = ReadFromSocket(socket.get());
97 if (output != std::vector<char>{'O', 'K'})
98 {
99 - g_logfile << "Got unepected output from bash" << std::endl;
99 + g_logfile << "Got unexpected output from bash" << std::endl;
100 return E_ABORT;
101 }
102 }
@@ -306,7 +306,7 @@ HRESULT OnDistroStopping(const WSLSessionInformation* Session, const WSLDistribu
306 return S_OK;
307 }
308
309 -HRESULT OnDistributionRegisted(const WSLSessionInformation* Session, const WslOfflineDistributionInformation* Distribution)
309 +HRESULT OnDistributionRegistered(const WSLSessionInformation* Session, const WslOfflineDistributionInformation* Distribution)
310 {
311 g_logfile << "Distribution registered, name=" << wsl::shared::string::WideToMultiByte(Distribution->Name)
312 << ", package=" << wsl::shared::string::WideToMultiByte(Distribution->PackageFamilyName)
@@ -315,7 +315,7 @@ HRESULT OnDistributionRegisted(const WSLSessionInformation* Session, const WslOf
315
316 if (g_testType == PluginTestType::FailToRegisterUnregisterDistro)
317 {
318 - g_logfile << "OnDistributionRegisted: E_UNEXPECTED" << std::endl;
318 + g_logfile << "OnDistributionRegistered: E_UNEXPECTED" << std::endl;
319 return E_UNEXPECTED;
320 }
321
@@ -357,7 +357,7 @@ EXTERN_C __declspec(dllexport) HRESULT WSLPLUGINAPI_ENTRYPOINTV1(const WSLPlugin
357 Hooks->OnVMStopping = &OnVmStopping;
358 Hooks->OnDistributionStarted = &OnDistroStarted;
359 Hooks->OnDistributionStopping = &OnDistroStopping;
360 - Hooks->OnDistributionRegistered = &OnDistributionRegisted;
360 + Hooks->OnDistributionRegistered = &OnDistributionRegistered;
361 Hooks->OnDistributionUnregistered = &OnDistributionUnregistered;
362
363 if (g_testType == PluginTestType::FailToLoad)
tools/devops/create-change.py
+5 -5
@@ -3,17 +3,17 @@ import requests
3 import json
4 from git import Repo
5
6 -COMMITER_EMAIL = 'noreply@microsoft.com'
6 +COMMITTER_EMAIL = 'noreply@microsoft.com'
7 REPO = 'microsoft/wsl'
8
9 @click.command()
10 @click.argument('repo_path', required=True)
11 @click.argument('token', required=True)
12 -@click.argument('commiter', required=True)
12 +@click.argument('committer', required=True)
13 @click.argument('message', required=True)
14 @click.argument('branch', required=True)
15 @click.option('--debug', default=False, is_flag=True)
16 -def main(repo_path: str, token: str, commiter: str, message: str, branch: str, debug: bool):
16 +def main(repo_path: str, token: str, committer: str, message: str, branch: str, debug: bool):
17 try:
18 repo = Repo(repo_path)
19
@@ -29,8 +29,8 @@ def main(repo_path: str, token: str, commiter: str, message: str, branch: str, d
29 repo.create_head(branch).checkout()
30
31 with repo.config_writer() as config:
32 - config.set_value("user", "email", COMMITER_EMAIL)
33 - config.set_value("user", "name", commiter)
32 + config.set_value("user", "email", COMMITTER_EMAIL)
33 + config.set_value("user", "name", committer)
34
35 repo.git.commit('-a', m=message)
36 repo.git.push('origin', branch)
tools/devops/create-release.py
+3 -3
@@ -78,7 +78,7 @@ def main(version: str, previous: str, max_message_lines: int, publish: bool, ass
78 def get_github_pr_message(token: str, message: str) -> str:
79 match = re.search(r'\(#([0-9]+)\)', message)
80 if match is None:
81 - print(f'Warning: failed to extract Github PR number from message: {message}')
81 + print(f'Warning: failed to extract GitHub PR number from message: {message}')
82 return None, None
83
84 pr_number = match.group(1)
@@ -108,7 +108,7 @@ def get_previous_release(version: tuple) -> str:
108 previous_versions = [e for e in versions if e < version]
109
110 if not previous_versions:
111 - raise RuntimeError(f'No previous found on Github. Response: {response.json()}')
111 + raise RuntimeError(f'No previous found on GitHub. Response: {response.json()}')
112
113 return '.'.join(str(e) for e in max(previous_versions))
114
@@ -176,7 +176,7 @@ def get_change_list(version: str, previous: str, fetch: bool) -> list:
176
177 @backoff.on_exception(backoff.expo, (requests.exceptions.Timeout, requests.exceptions.ConnectionError, requests.exceptions.RequestException), max_time=600)
178 def publish_release(version: str, changes: str, assets: list, auto_release_notes: bool, token: str):
179 - print(f'Creating private Github release for: {version}', file=sys.stderr)
179 + print(f'Creating private GitHub release for: {version}', file=sys.stderr)
180
181 # First create the release
182 headers = {'Accept': 'application/vnd.github+json',
tools/test/gh-release-server.py
+2 -2
@@ -62,7 +62,7 @@ def main(port: int, version: str, msi: str, msix: str, pre_release: bool):
62 else:
63 print(f'Received unexpected request: {self.path}')
64
65 - SetValueEx(lxss_key, 'GithubUrlOverride', 0, REG_SZ, f'http://127.0.0.1:{port}{RELEASES_PATH}')
65 + SetValueEx(lxss_key, 'GitHubUrlOverride', 0, REG_SZ, f'http://127.0.0.1:{port}{RELEASES_PATH}')
66
67 try:
68
@@ -70,7 +70,7 @@ def main(port: int, version: str, msi: str, msix: str, pre_release: bool):
70 print(f'Serving on port {port}')
71 server.serve_forever()
72 finally:
73 - DeleteValue(lxss_key, 'GithubUrlOverride')
73 + DeleteValue(lxss_key, 'GitHubUrlOverride')
74
75 if __name__ == '__main__':
76 main()
\ No newline at end of file
tools/test/setup-vm-for-tests.ps1
+2 -2
@@ -22,9 +22,9 @@
22 .PARAMETER SkipEnableFeatures
23 Skip enabling optional Windows features necessary for some tests.
24 .PARAMETER RemoteFolder
25 - Absolute Path to a folder on the the VM to copy requisite files to. Defaults to "C:\Package".
25 + Absolute Path to a folder on the VM to copy requisite files to. Defaults to "C:\Package".
26 .PARAMETER TaefFolder
27 - Absolute Path to a folder on the the VM to copy taef binaries. Defaults to "C:\Taef".
27 + Absolute Path to a folder on the VM to copy taef binaries. Defaults to "C:\Taef".
28 .PARAMETER SkipDistro
29 Skip copying over the distro.
30 .PARAMETER TestDistroPath
triage/config.yml
+6 -5
@@ -5,7 +5,7 @@ logs_rules:
5 # Logs are required for review from WSL team
6
7 If this a feature request, please reply with '/feature'. If this is a question, reply with '/question'.
8 - **Otherwise please attach logs by following the instructions below**, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.
8 + **Otherwise, please attach logs by following the instructions below**, your issue will not be reviewed unless they are added. These logs will help us understand what is going on in your machine.
9
10 <details>
11
@@ -21,11 +21,12 @@ logs_rules:
21
22 The script will output the path of the log file once done.
23
24 - If this is a networking issue, please use [collect-networking-logs.ps1](https://github.com/Microsoft/WSL/blob/master/diagnostics/collect-networking-logs.ps1), following the instructions [here](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#collect-wsl-logs-for-networking-issues)
24 + If this is a networking issue, please use [collect-networking-logs.ps1](https://github.com/Microsoft/WSL/blob/master/diagnostics/collect-networking-logs.ps1), following the instructions in [Collect WSL logs for networking issues](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#collect-wsl-logs-for-networking-issues)
25
26 - Once completed please upload the output files to this Github issue.
26 + Once completed please upload the output files to this GitHub issue.
27
28 - [Click here for more info on logging](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method)
28 + See [Collect WSL logs (recommended method)](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method).
29 +
30 If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue and reply with '/emailed-logs'.
31 </details>
32
@@ -386,7 +387,7 @@ actions:
387 defaultVhdSize = <size> # (example: 1500GB)
388 ```
389
389 - Otherwise if you need to increase the size of an existing distribution, you can follow [these instructions](https://learn.microsoft.com/en-us/windows/wsl/disk-space#how-to-expand-the-size-of-your-wsl-2-virtual-hard-disk).
390 + Otherwise, if you need to increase the size of an existing distribution, you can follow [these instructions](https://learn.microsoft.com/en-us/windows/wsl/disk-space#how-to-expand-the-size-of-your-wsl-2-virtual-hard-disk).
391
392 - when:
393 condition: