@samitouri / QOSAMI-WSL / commits / 6d18bf50

Spelling (#13289)

* link: report them to the Microsoft Security Response Center (MSRC) Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * link: Microsoft Security Response Center Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: , or Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: adapters Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: at Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: attaching them to the bug, please send them to wsl-gh-logs@microsoft.com with the github issue number in the subject, and include a link to your github issue comment in the message body. Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: disk Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: effect Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for the file Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: for the mount to be available Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: grandchild Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: last pid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: nonexistent Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: on which the... Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: path Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: pseudo Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: script Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: service, the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: session Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: strip Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that a Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: that the Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: the first one we find in the test Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: to which Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: waitpid Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: whether Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: while the relay was being set up, Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: with an Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> * spelling: without specifying Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> --------- Signed-off-by: Josh Soref <2119212+jsoref@users.noreply.github.com> Co-authored-by: Ben Hillis <benhillis@gmail.com>

Josh Soref committed Jul 29, 2025 at 14:24 UTC 6d18bf50746207b5518314a6b0f496b2c0235cd4

24 files changed +46 -46

.github/policies/resourceManagement.yml

+3 -3

@@ -181,7 +181,7 @@ configuration:

181

182 ```

183

184 - The scipt will output the path of the log file once done.

184 + The script will output the path of the log file once done.

185

186

187 Once completed please upload the output files to this GitHub issue.

@@ -190,7 +190,7 @@ configuration:

190 See [Collect WSL logs (recommended method)](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method).

191

192

193 - If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue.

193 + If you choose to email these logs instead of attaching them to the bug, please send them to wsl-gh-logs@microsoft.com with the GitHub issue number in the subject, and include a link to your GitHub issue comment in the message body.

194

195

196 Thank you!

@@ -226,7 +226,7 @@ configuration:

226

227 ```

228

229 - The scipt will output the path of the log file once done.

229 + The script will output the path of the log file once done.

230

231

232 Once completed please upload the output files to this GitHub issue.

CONTRIBUTING.md

+1 -1

@@ -68,7 +68,7 @@ The script will output the path of the log file once done.

69 ### Collect WSL logs (recommended method)

71 -If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue.

71 +If you choose to email these logs instead of attaching them to the bug, please send them to wsl-gh-logs@microsoft.com with the GitHub issue number in the subject, and include a link to your GitHub issue comment in the message body.

73 To collect WSL logs, download and execute [collect-wsl-logs.ps1](https://github.com/Microsoft/WSL/blob/master/diagnostics/collect-wsl-logs.ps1) in an administrative powershell prompt:

SECURITY.md

+2 -2

@@ -10,11 +10,11 @@ If you believe you have found a security vulnerability in any Microsoft-owned re

11 **Please do not report security vulnerabilities through public GitHub issues.**

13 -Instead, please report them to the Microsoft Security Response Center (MSRC) at [https://msrc.microsoft.com/create-report](https://aka.ms/opensource/security/create-report).

13 +Instead, please [report them to the Microsoft Security Response Center (MSRC)](https://aka.ms/opensource/security/create-report).

15 If you prefer to submit without logging in, send email to [secure@microsoft.com](mailto:secure@microsoft.com). If possible, encrypt your message with our PGP key; please download it from the [Microsoft Security Response Center PGP Key page](https://aka.ms/opensource/security/pgpkey).

17 -You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [microsoft.com/msrc](https://aka.ms/opensource/security/msrc).

17 +You should receive a response within 24 hours. If for some reason you do not, please follow up via email to ensure we received your original message. Additional information can be found at [Microsoft Security Response Center](https://aka.ms/opensource/security/msrc).

19 Please include the requested information listed below (as much as you can provide) to help us better understand the nature and scope of the possible issue:

doc/docs/technical-documentation/boot-process.md

+1 -1

@@ -82,7 +82,7 @@ When started, the virtual machine will boot into the provided kernel, and then e

83 - An entropy buffer, to seed the virtual machine's entropy

84 - Information about the GPU drivers shares to mount, if any

85 -- Wether [wslg](https://github.com/microsoft/wslg) is enabled

85 +- Whether [wslg](https://github.com/microsoft/wslg) is enabled

87 After applying all the configuration requested by [wslservice.exe](wslservice.exe.md), the virtual machine is ready to start Linux distributions.

localization/strings/en-GB/Resources.resw

+1 -1

@@ -1100,7 +1100,7 @@ Error code: {}</value>

1100 <value>Failed to query networking mode</value>

1101 </data>

1102 <data name="MessageMismatchedKernelModulesError" xml:space="preserve">

1103 - <value>Customised kernel modules were supplied without a specifying a customised kernel. Please see https://aka.ms/wslcustomkernel for more information.</value>

1103 + <value>Customised kernel modules were supplied without specifying a customised kernel. Please see https://aka.ms/wslcustomkernel for more information.</value>

1104 </data>

1105 <data name="MessageDnsTunnelingDisabled" xml:space="preserve">

1106 <value>Due to a current compatibility issue with Global Secure Access Client, DNS Tunneling is disabled.</value>

localization/strings/en-US/Resources.resw

+1 -1

@@ -1100,7 +1100,7 @@ Error code: {}</value>

1100 <value>Failed to query networking mode</value>

1101 </data>

1102 <data name="MessageMismatchedKernelModulesError" xml:space="preserve">

1103 - <value>Customised kernel modules were supplied without a specifying a customised kernel. Please see https://aka.ms/wslcustomkernel for more information.</value>

1103 + <value>Customised kernel modules were supplied without specifying a customised kernel. Please see https://aka.ms/wslcustomkernel for more information.</value>

1104 </data>

1105 <data name="MessageDnsTunnelingDisabled" xml:space="preserve">

1106 <value>Due to a current compatibility issue with Global Secure Access Client, DNS Tunneling is disabled.</value>

src/linux/init/config.cpp

+2 -2

@@ -835,8 +835,8 @@ try

835

836 //

837 // Run the Plan 9 server. This requires a DrvFs mount for the socket file,

838 - // so either fstab or automount must be enabled to have a chance the mount

839 - // exists.

838 + // so either fstab or automount must be enabled to have a chance for the

839 + // mount to be available.

840 //

841 // N.B. Failure to start the server is non-fatal.

842 //

src/linux/init/localhost.cpp

+1 -1

@@ -64,7 +64,7 @@ void ListenThread(sockaddr_vm hvSocketAddress, int listenSocket)

65 // Connect to the actual socket address and set up a relay.

66 //

67 - // N.B. During the time setting up the relay the server may have

67 + // N.B. While the relay was being set up, the server may have

68 // stopped listening.

69 sockaddr* socketAddress;

70 int socketAddressSize;

src/linux/init/main.cpp

+3 -3

@@ -3168,8 +3168,8 @@ Routine Description:

3168

3169 Arguments:

3170

3171 - MessageFd - Supplies a file descriptor to the socket the message was received

3172 - on. This is used for operations that require responses, for example a

3171 + MessageFd - Supplies a file descriptor to the socket on which the message was

3172 + received. This is used for operations that require responses, for example a

3173 VHD eject request.

3174

3175 Buffer - Supplies the message.

@@ -3802,7 +3802,7 @@ Routine Description:

3802

3803 Arguments:

3804

3805 - Pth - Supplies the path to the block device.

3805 + Path - Supplies the path to the block device.

3806

3807 Return Value:

3808

src/shared/inc/message.h

+1 -1

@@ -143,7 +143,7 @@ public:

143 gsl::span<std::byte> Span()

144 {

145 // In case the structure is padded,

146 - // make sure that the message is a least the size of the structure.

146 + // make sure that the message is at least the size of the structure.

147

148 const int64_t diff = sizeof(TMessage) - m_buffer.size();

149 if (diff > 0)

src/windows/common/Localization.cpp

+1 -1

@@ -45,7 +45,7 @@ std::vector<std::wstring> GetUserLanguages(bool impersonate)

45 {

46 if (g_runningInService)

47 {

48 - // N.B. If we're in the service the locale needs to be queried every time since different users

48 + // N.B. If we're in the service, the locale needs to be queried every time since different users

49 // can have different language configurations.

50 std::optional<wil::unique_coreverttoself_call> revert;

51 if (impersonate)

src/windows/common/WslCoreNetworkingSupport.h

+1 -1

@@ -545,7 +545,7 @@ private:

545 &BufferSize);

546 } while (Result == ERROR_BUFFER_OVERFLOW);

547

548 - THROW_LAST_ERROR_IF_MSG((Result != ERROR_SUCCESS), "GetAdpatersAddresses");

548 + THROW_LAST_ERROR_IF_MSG((Result != ERROR_SUCCESS), "GetAdaptersAddresses");

549 m_buffer.resize(BufferSize);

550 auto AddressBuffer = (PIP_ADAPTER_ADDRESSES)m_buffer.data();

551 std::vector<IpAdapterAddress> addresses;

src/windows/service/exe/LxssUserSession.h

+1 -1

@@ -484,7 +484,7 @@ public:

484 HRESULT AttachDisk(_In_ LPCWSTR Disk, _In_ ULONG Flags);

485

486 /// <summary>

487 - /// Detach a passthrough a disk from the utility VM.

487 + /// Detach a passthrough disk from the utility VM.

488 /// </summary>

489 HRESULT DetachDisk(_In_ LPCWSTR Disk, _Out_ int* Result, _Out_ int* Step);

490

test/linux/unit_tests/auxv.c

+2 -2

@@ -411,7 +411,7 @@ int AuxvAtExecfn(PLXT_ARGS Args)

411 LxtCheckResult(LxtWaitPidPoll(ChildPid, LXT_RESULT_SUCCESS));

412

413 //

414 - // Run the binary an empty command line.

414 + // Run the binary with an empty command line.

415 //

416

417 LxtCheckErrno(ChildPid = fork());

@@ -516,7 +516,7 @@ int AuxvAtExecfn(PLXT_ARGS Args)

516 LxtCheckResult(LxtWaitPidPoll(ChildPid, LXT_RESULT_SUCCESS));

517

518 //

519 - // Run the script an empty command line.

519 + // Run the script with an empty command line.

520 //

521

522 LxtCheckErrno(ChildPid = fork());

test/linux/unit_tests/dev_pt_common.c

+1 -1

@@ -72,7 +72,7 @@ int GetPtSerialNumFromDeviceString(const char PtsNameString[])

73 Routine Description:

75 - This routine will parse the PTS (Psedu Terminal Slave) device name and

75 + This routine will parse the PTS (Pseudo Terminal Slave) device name and

76 retrieve the Serial Number from the string.

78 Arguments:

test/linux/unit_tests/get_set_id.c

+2 -2

@@ -1027,7 +1027,7 @@ Return Value:

1027 LxtCheckErrnoZeroSuccess(connect(ClientSocket, (struct sockaddr*)&Address, sizeof(Address)));

1028

1029 //

1030 - // Tell the parent the process is running inside the execve'd binary.

1030 + // Tell the parent that the process is running inside the execve'd binary.

1031 //

1032

1033 LxtCheckResult(LxtSendMessage(ClientSocket, "execve"));

@@ -1106,7 +1106,7 @@ Return Value:

1106 LxtCheckEqual(Sid, getpgid(0), "%d");

1107

1108 //

1109 - // Tell the parent the new session was created.

1109 + // Tell the parent that a new session was created.

1110 //

1111

1112 LxtCheckErrnoZeroSuccess(kill(getppid(), SIGUSR1));

test/linux/unit_tests/lxtfs.c

+1 -1

@@ -3403,7 +3403,7 @@ Return Value:

3403

3404 //

3405 // When using the current time, there is a slight chance of this test

3406 - // failing when the time the file was set to and the time when the check

3406 + // failing when the time set for the file and the time when the check

3407 // is done straddle midnight.

3408 //

3409

test/linux/unit_tests/sched.c

+1 -1

@@ -320,7 +320,7 @@ int SetGetAffinityNp(PLXT_ARGS Args)

320

321 //

322 // N.B Affinity cannot be validated because its not guaranteed for it to

323 - // take affect.

323 + // take effect.

324 //

325

326 LxtLogInfo("Current Affinity: %08x", *(uint32_t*)&Set);

test/linux/unit_tests/sem.c

+1 -1

@@ -181,7 +181,7 @@ int SemCtlSyscall(PLXT_ARGS Args)

181

182 //

183 // Ensure that each semaphore's value has been updated. Interestingly the

184 - // lastpid value is not updated by the SETALL command.

184 + // last pid value is not updated by the SETALL command.

185 //

186

187 LxtCheckErrno(LxtSemCtl(Id, 0, SETALL, &Values));

test/linux/unit_tests/vnet.c

+1 -1

@@ -1486,7 +1486,7 @@ Arguments:

1486

1487 Flag - Supplies the flag to toggle.

1488

1489 - IsFlagEnabled - Supplies the state the flag should be set to.

1489 + IsFlagEnabled - Supplies the state to which the flag should be set.

1490

1491 Response - Supplies a pointer to receive the response errno.

1492

test/linux/unit_tests/waitpid.c

+6 -6

@@ -29,8 +29,8 @@ Abstract:

30 #define WAITPID_DEFAULT_WAIT_TIMEOUT_US 100000

31 #define WAITPID_DEFAULT_WAIT_COUNT 20

32 -#define WAIDPID_THREADGROUP_LEADER_UID 1044

33 -#define WAIDPID_PTHREAD_UID 1055

32 +#define WAITPID_THREADGROUP_LEADER_UID 1044

33 +#define WAITPID_PTHREAD_UID 1055

35 bool g_VmMode = false;

@@ -719,7 +719,7 @@ Return Value:

719

720 int Result;

721 LxtLogInfo("WaitPid child tid %d", gettid());

722 - LxtCheckErrno(LxtSetUid(WAIDPID_PTHREAD_UID));

722 + LxtCheckErrno(LxtSetUid(WAITPID_PTHREAD_UID));

723

724 //

725 // Enter a very long sleep, this will be interrupted when the threadgroup

@@ -785,7 +785,7 @@ Return Value:

785 //

786

787 sleep(1);

788 - LxtCheckErrno(LxtSetUid(WAIDPID_THREADGROUP_LEADER_UID));

788 + LxtCheckErrno(LxtSetUid(WAITPID_THREADGROUP_LEADER_UID));

789 _exit(ExpectedStatus);

790 }

791

@@ -794,7 +794,7 @@ Return Value:

794 LxtCheckEqual(SigInfo.si_code, CLD_EXITED, "%d");

795 LxtCheckEqual(SigInfo.si_status, ExpectedStatus, "%d");

796 LxtCheckEqual(SigInfo.si_pid, ChildPid, "%d");

797 - LxtCheckEqual(SigInfo.si_uid, WAIDPID_THREADGROUP_LEADER_UID, "%d");

797 + LxtCheckEqual(SigInfo.si_uid, WAITPID_THREADGROUP_LEADER_UID, "%d");

798

799 //

800 // Wait for a specific child.

@@ -1006,7 +1006,7 @@ Return Value:

1006 ChildPid = -1;

1007

1008 //

1009 - // Create a child process, that in turn creates a granchild process

1009 + // Create a child process, that in turn creates a grandchild process

1010 // with CLONE_PARENT.

1011 //

1012

test/windows/NetworkTests.cpp

+3 -3

@@ -2680,7 +2680,7 @@ class NetworkTests

2680 {.guiApplications = true, .networkingMode = wsl::core::NetworkingMode::Mirrored, .hostAddressLoopback = true}));

2681 WaitForMirroredStateInLinux();

2682

2683 - // We list the IPv4 addresses mirrored in Linux and use in the test the first one we find

2683 + // We list the IPv4 addresses mirrored in Linux and use the first one we find in the test

2684 std::vector<InterfaceState> interfaceStates = GetAllInterfaceStates();

2685 std::wstring ipAddress;

2686

@@ -2760,7 +2760,7 @@ class NetworkTests

2760 {.guiApplications = true, .networkingMode = wsl::core::NetworkingMode::Mirrored, .hostAddressLoopback = true}));

2761 WaitForMirroredStateInLinux();

2762

2763 - // We list the IPv4 addresses mirrored in Linux and use in the test the first one we find

2763 + // We list the IPv4 addresses mirrored in Linux and use the first one we find in the test

2764 std::vector<InterfaceState> interfaceStates = GetAllInterfaceStates();

2765 std::wstring ipAddress;

2766

@@ -3650,7 +3650,7 @@ class NetworkTests

3650 return std::find(v6State.Routes.begin(), v6State.Routes.end(), route) != v6State.Routes.end();

3651 }

3652

3653 - // Reads from the file until the substring is found, a timeout is reached or ReadFile returns an error

3653 + // Reads from the file until the substring is found, a timeout is reached, or ReadFile returns an error

3654 // Returns true on success, false otherwise

3655 static bool FindSubstring(wil::unique_handle& file, const std::string& substr, std::string& output)

3656 {

test/windows/UnitTests.cpp

+8 -8

@@ -227,7 +227,7 @@ class UnitTests

227 CreateUser(LXSST_TEST_USERNAME, &TestUid, &TestGid);

228 auto userCleanup = wil::scope_exit([]() { LxsstuLaunchWsl(L"userdel " LXSST_TEST_USERNAME); });

229

230 - auto validateUserSesssion = [&]() {

230 + auto validateUserSession = [&]() {

231 // verify that the user service is running

232 const std::wstring isServiceActiveCmd =

233 std::format(L"-u {} systemctl is-active user@{}.service ; exit 0", LXSST_TEST_USERNAME, TestUid);

@@ -260,7 +260,7 @@ class UnitTests

260

261 // Validate user sessions state with gui apps disabled.

262 {

263 - validateUserSesssion();

263 + validateUserSession();

264

265 auto [out, err] = LxsstuLaunchWslAndCaptureOutput(std::format(L"echo $DISPLAY", LXSST_TEST_USERNAME));

266 VERIFY_ARE_EQUAL(out, L"\n");

@@ -270,7 +270,7 @@ class UnitTests

270 {

271 WslConfigChange config(LxssGenerateTestConfig({.guiApplications = true}));

272

273 - validateUserSesssion();

273 + validateUserSession();

274 auto [out, err] = LxsstuLaunchWslAndCaptureOutput(std::format(L"echo $DISPLAY", LXSST_TEST_USERNAME));

275 VERIFY_ARE_EQUAL(out, L":0\n");

276 }

@@ -2608,7 +2608,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND

2608 {

2609 WSL2_TEST_ONLY();

2610

2611 - // Get the kernel version and stip off everything after the first dash.

2611 + // Get the kernel version and strip off everything after the first dash.

2612 std::wstring kernelVersion{TEXT(KERNEL_VERSION)};

2613 auto position = kernelVersion.find_first_of(L"-");

2614 if (position != kernelVersion.npos)

@@ -3585,10 +3585,10 @@ localhostForwarding=true

3585 validateUidChange(L"testuser", Uid, L"The operation completed successfully. \r\n", L"", 0);

3586 validateUidChange(L"root", 0, L"The operation completed successfully. \r\n", L"", 0);

3587

3588 - const std::wstring invalidUser = L"DoesntExist";

3588 + const std::wstring invalidUser = L"Nonexistent";

3589 validateUidChange(invalidUser, 0, L"", L"/usr/bin/id: \u2018" + invalidUser + L"\u2019: no such user\n", 1);

3590

3591 - auto [out, _] = LxsstuLaunchWslAndCaptureOutput(L"--manage doesntexist --set-default-user root", -1);

3591 + auto [out, _] = LxsstuLaunchWslAndCaptureOutput(L"--manage nonexistent --set-default-user root", -1);

3592

3593 VERIFY_ARE_EQUAL(

3594 out, L"There is no distribution with the supplied name.\r\nError code: Wsl/Service/WSL_E_DISTRO_NOT_FOUND\r\n");

@@ -5203,7 +5203,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND\r\n",

5203 "Name": "{}",

5204 "FriendlyName": "DebianFriendlyName",

5205 "Amd64Url": {{

5206 - "Url": "file://doesnotexist",

5206 + "Url": "file://nonexistent",

5207 "Sha256": ""

5208 }}

5209 }},

@@ -5211,7 +5211,7 @@ Error code: Wsl/InstallDistro/WSL_E_DISTRO_NOT_FOUND\r\n",

5211 "Name": "dummy",

5212 "FriendlyName": "dummy",

5213 "Amd64Url": {{

5214 - "Url": "file://doesnotexist",

5214 + "Url": "file://nonexistent",

5215 "Sha256": ""

5216 }}

5217 }}

triage/config.yml

+1 -1

@@ -27,7 +27,7 @@ logs_rules:

28 See [Collect WSL logs (recommended method)](https://github.com/microsoft/WSL/blob/master/CONTRIBUTING.md#8-collect-wsl-logs-recommended-method).

30 - If you choose to email these logs instead of attaching to the bug, please send them to wsl-gh-logs@microsoft.com with the number of the github issue in the subject, and in the message a link to your comment in the github issue and reply with '/emailed-logs'.

30 + If you choose to email these logs instead of attaching them to the bug, please send them to wsl-gh-logs@microsoft.com with the GitHub issue number in the subject, and include a link to your GitHub issue comment in the message body, and reply with '/emailed-logs'.

31 </details>