@samitouri / QOSAMI-WSL / commits / e04be451

wslc: update `volume create --driver` help text to enumerate supported drivers (#40546)

* Update volume driver help text and E2E expectation Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/4ebb1292-9273-4d17-9aea-e1ab78c3b75a Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com> * Adjust driver arg localization comments after placeholder removal Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/4ebb1292-9273-4d17-9aea-e1ab78c3b75a Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com> * Remove WSLCCLI_DriverArgDescription from all non-en-US locale files Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/1b61b8da-a0f1-4f4c-b508-e153b979a616 Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com> * Apply clang-format to WSLCE2EVolumeCreateTests.cpp Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/77b8fda5-44ab-462a-90ef-8000cb7ac79b Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com> * Rename WSLCCLI_DriverArgDescription to WSLCCLI_DriverOptionDescription Agent-Logs-Url: https://github.com/microsoft/WSL/sessions/7fbee671-7250-492b-a575-2927a9a4f2bd Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: AmelBawa-msft <104940545+AmelBawa-msft@users.noreply.github.com>

Copilot committed May 15, 2026 at 03:26 UTC e04be45185c93679dbce65fa099c33feed63c1d9
24 files changed +10 -94
localization/strings/cs-CZ/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Při prvním spuštění vytvoří soubor se všemi nastaveními okomentovanými
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Název svazku</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Zadejte název ovladače svazku (výchozí {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Nastavení možností specifických pro ovladač</value>
2959 </data>
localization/strings/da-DK/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Ved første kørsel oprettes filen med alle indstillinger kommenteret som standa
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Navn på diskenhed</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Angiv navn på diskenhedsdriveren (standard {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Angiv driverspecifikke indstillinger</value>
2959 </data>
localization/strings/de-DE/Resources.resw
-4
@@ -2960,10 +2960,6 @@ Erstellt bei der ersten Ausführung die Datei mit allen Einstellungen, die stand
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>Volumename</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>Geben Sie den Namen des Volumetreiber an (Standard: {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>Treiberspezifische Optionen festlegen</value>
2965 </data>
localization/strings/en-GB/Resources.resw
-4
@@ -2954,10 +2954,6 @@ On first run, creates the file with all settings commented out at their defaults
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Volume name</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Specify volume driver name (default {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Set driver specific options</value>
2959 </data>
localization/strings/en-US/Resources.resw
+3 -3
@@ -2954,9 +2954,9 @@ On first run, creates the file with all settings commented out at their defaults
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Volume name</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Specify volume driver name (default {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2957 + <data name="WSLCCLI_DriverOptionDescription" xml:space="preserve">
2958 + <value>Specify volume driver name, e.g. 'guest' or 'vhd' (default: guest)</value>
2959 + <comment>{Locked="guest"}{Locked="vhd"}Command line arguments, file names and string inserts should not be translated</comment>
2960 </data>
2961 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2962 <value>Set driver specific options</value>
localization/strings/es-ES/Resources.resw
-4
@@ -2960,10 +2960,6 @@ En la primera ejecución, crea el archivo con todas las configuraciones comentad
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>Nombre del volumen</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>Especifica el nombre del controlador de volumen (predeterminado {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>Establecer opciones específicas del controlador</value>
2965 </data>
localization/strings/fi-FI/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Ensimmäisellä käynnistyskerralla luo tiedoston, jossa kaikki asetukset on kom
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Aseman nimi</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Määritä äänenvoimakkuusohjaimen nimi (oletus {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Määritä ohjaimen erityisasetukset</value>
2959 </data>
localization/strings/fr-FR/Resources.resw
-4
@@ -2961,10 +2961,6 @@ Lors de la première exécution, crée le fichier avec tous les paramètres comm
2961 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2962 <value>Nom de volume</value>
2963 </data>
2964 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2965 - <value>Spécifier le nom du pilote de volume (par défaut {})</value>
2966 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2967 - </data>
2964 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2965 <value>Définissez des options spécifiques au pilote</value>
2966 </data>
localization/strings/hu-HU/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Első futtatáskor a program létrehozza a fájlt, amelyben az összes beállít
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Kötet neve</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Kötetillesztő nevének megadása (alapértelmezett {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Illesztőprogram-specifikus beállítások beállítása</value>
2959 </data>
localization/strings/it-IT/Resources.resw
-4
@@ -2960,10 +2960,6 @@ Alla prima esecuzione crea il file con tutte le impostazioni commentate come pre
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>Nome volume</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>Specifica il nome del driver del volume (predefinito {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>Imposta opzioni specifiche del driver</value>
2965 </data>
localization/strings/ja-JP/Resources.resw
-4
@@ -2960,10 +2960,6 @@ VS Code 自体のコマンド パレットから、より多くの VS Code リ
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>ボリューム名</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>ボリューム ドライバー名を指定してください (既定値は {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>ドライバー固有のオプションを設定します</value>
2965 </data>
localization/strings/ko-KR/Resources.resw
-4
@@ -2960,10 +2960,6 @@ VS Code 자체 내의 명령 팔레트를 통해 더 많은 VS Code 원격 옵
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>볼륨 이름</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>볼륨 드라이버 이름 지정(기본값 {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>드라이버별 옵션 설정</value>
2965 </data>
localization/strings/nb-NO/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Ved første kjøring opprettes filen med alle innstillinger kommentert ut som st
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Volumnavn</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Angi navn på volumedriver (standard {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Angi driver-spesifikke alternativer</value>
2959 </data>
localization/strings/nl-NL/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Bij de eerste uitvoering wordt het bestand aangemaakt met alle instellingen geco
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Volumenaam</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Geef de naam van het volumestuurprogramma op (standaard {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Stuurprogrammaspecifieke opties instellen</value>
2959 </data>
localization/strings/pl-PL/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Przy pierwszym uruchomieniu tworzy plik ze wszystkimi ustawieniami ujętymi w ko
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Nazwa woluminu</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Określ nazwę sterownika woluminu (domyślnie {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Ustaw opcje specyficzne dla sterownika</value>
2959 </data>
localization/strings/pt-BR/Resources.resw
-4
@@ -2961,10 +2961,6 @@ Na primeira execução, cria o arquivo com todas as configurações comentadas n
2961 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2962 <value>Nome do volume</value>
2963 </data>
2964 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2965 - <value>Especifique o nome do driver de volume (padrão {})</value>
2966 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2967 - </data>
2964 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2965 <value>Definir opções específicas do driver</value>
2966 </data>
localization/strings/pt-PT/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Na primeira execução, cria o ficheiro com todas as definições comentadas nas
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Nome do volume</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Especificar nome do controlador de volume (predefinição {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Definir opções específicas do controlador</value>
2959 </data>
localization/strings/ru-RU/Resources.resw
-4
@@ -2961,10 +2961,6 @@ wsl.exe --manage &lt;DistributionName&gt; --set-sparse true --allow-unsafe</valu
2961 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2962 <value>Имя тома</value>
2963 </data>
2964 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2965 - <value>Укажите имя драйвера тома (по умолчанию {})</value>
2966 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2967 - </data>
2964 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2965 <value>Настройка параметров драйвера</value>
2966 </data>
localization/strings/sv-SE/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Vid den första körningen skapas filen med alla inställningar kommenterade som
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Volymnamn</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Ange volymdrivrutinens namn (standard {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Ange drivrutinsspecifika alternativ</value>
2959 </data>
localization/strings/tr-TR/Resources.resw
-4
@@ -2954,10 +2954,6 @@ Bu ürünle ilgili gizlilik bilgileri için lütfen https://aka.ms/privacy sayfa
2954 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2955 <value>Birim adı</value>
2956 </data>
2957 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2958 - <value>Birim sürücü adını belirtin (varsayılan {})</value>
2959 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2960 - </data>
2957 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2958 <value>Sürücüye özgü seçenekleri ayarlayın</value>
2959 </data>
localization/strings/zh-CN/Resources.resw
-4
@@ -2960,10 +2960,6 @@ wsl.exe --manage &lt;DistributionName&gt; --set-sparse true --allow-unsafe</valu
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>卷名称</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>指定卷驱动程序名称(默认值 {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>设置特定于驱动程序的选项</value>
2965 </data>
localization/strings/zh-TW/Resources.resw
-4
@@ -2960,10 +2960,6 @@ wsl.exe --manage &lt;DistributionName&gt; --set-sparse true --allow-unsafe</valu
2960 <data name="WSLCCLI_VolumeNameArgDescription" xml:space="preserve">
2961 <value>磁碟區名稱</value>
2962 </data>
2963 - <data name="WSLCCLI_DriverArgDescription" xml:space="preserve">
2964 - <value>指定磁碟區驅動程式名稱 (預設為 {})</value>
2965 - <comment>{FixedPlaceholder="{}"}Command line arguments, file names and string inserts should not be translated</comment>
2966 - </data>
2963 <data name="WSLCCLI_OptionsArgDescription" xml:space="preserve">
2964 <value>設定驅動程式的特定選項</value>
2965 </data>
src/windows/wslc/arguments/ArgumentDefinitions.h
+1 -1
@@ -48,7 +48,7 @@ _(DNS, "dns", NO_ALIAS, Kind::Value, L
48 _(DNSOption, "dns-option", NO_ALIAS, Kind::Value, Localization::WSLCCLI_DNSOptionArgDescription()) \
49 _(DNSSearch, "dns-search", NO_ALIAS, Kind::Value, Localization::WSLCCLI_DNSSearchArgDescription()) \
50 _(Domainname, "domainname", NO_ALIAS, Kind::Value, Localization::WSLCCLI_DomainnameArgDescription()) \
51 -_(Driver, "driver", L"d", Kind::Value, Localization::WSLCCLI_DriverArgDescription("guest")) \
51 +_(Driver, "driver", L"d", Kind::Value, Localization::WSLCCLI_DriverOptionDescription()) \
52 _(Entrypoint, "entrypoint", NO_ALIAS, Kind::Value, Localization::WSLCCLI_EntrypointArgDescription()) \
53 _(Env, "env", L"e", Kind::Value, Localization::WSLCCLI_EnvArgDescription()) \
54 _(EnvFile, "env-file", NO_ALIAS, Kind::Value, Localization::WSLCCLI_EnvFileArgDescription()) \
test/windows/wslc/e2e/WSLCE2EVolumeCreateTests.cpp
+6 -6
@@ -145,12 +145,12 @@ private:
145 std::wstring GetAvailableOptions() const
146 {
147 std::wstringstream options;
148 - options << L"The following options are available:\r\n" //
149 - << L" -d,--driver Specify volume driver name (default guest)\r\n" //
150 - << L" -o,--opt Set driver specific options\r\n" //
151 - << L" -l,--label Set metadata on an object\r\n" //
152 - << L" --session Specify the session to use\r\n" //
153 - << L" -?,--help Shows help about the selected command\r\n" //
148 + options << L"The following options are available:\r\n" //
149 + << L" -d,--driver Specify volume driver name, e.g. 'guest' or 'vhd' (default: guest)\r\n" //
150 + << L" -o,--opt Set driver specific options\r\n" //
151 + << L" -l,--label Set metadata on an object\r\n" //
152 + << L" --session Specify the session to use\r\n" //
153 + << L" -?,--help Shows help about the selected command\r\n" //
154 << L"\r\n";
155 return options.str();
156 }