remove unnecessary annoying tests
Kim committed
Apr 3, 2026 at 15:52 UTC
4ce68fcd6140295218cbb375effa63c746731cea
1 file changed
+3
-53
portal/server_test.go
+3
-53
@@ -267,42 +267,6 @@ func TestServerStartDomainReportsCompatibilityInfo(t *testing.T) {
267
}
268
}
269
270
-func TestRegisterLeaseIncludesSNIPort(t *testing.T) {
271
- t.Parallel()
272
-
273
- server, err := NewServer(ServerConfig{
274
- PortalURL: "https://portal.example.com:4017",
275
- IdentityPath: tempIdentityPath(t),
276
- SNIPort: 4443,
277
- MinPort: 40000,
278
- MaxPort: 40009,
279
- UDPEnabled: true,
280
- })
281
- if err != nil {
282
- t.Fatalf("NewServer() error = %v", err)
283
- }
284
-
285
- resp, err := server.registerLease(types.RegisterChallengeRequest{
286
- Identity: types.Identity{
287
- Name: "demo-sni",
288
- Address: server.identity.Address,
289
- },
290
- UDPEnabled: true,
291
- }, "203.0.113.10", "")
292
- if err != nil {
293
- t.Fatalf("registerLease() error = %v", err)
294
- }
295
- t.Cleanup(func() {
296
- if record, err := server.registry.Find(resp.Identity); err == nil {
297
- record.Close()
298
- }
299
- })
300
-
301
- if resp.SNIPort != 4443 {
302
- t.Fatalf("RegisterResponse.SNIPort = %d, want %d", resp.SNIPort, 4443)
303
- }
304
-}
305
-
270
func TestRegisterLeaseOmitsSNIPortWithoutUDP(t *testing.T) {
271
t.Parallel()
272
@@ -532,23 +496,6 @@ func TestNewServerIgnoresDiscoveryPortWithoutWireGuardKey(t *testing.T) {
496
}
497
}
498
535
-func TestNewServerRejectsInvalidSharedPortRange(t *testing.T) {
536
- t.Parallel()
537
-
538
- _, err := NewServer(ServerConfig{
539
- PortalURL: "https://portal.example.com",
540
- IdentityPath: tempIdentityPath(t),
541
- MinPort: 40010,
542
- MaxPort: 40000,
543
- })
544
- if err == nil {
545
- t.Fatal("NewServer() error = nil, want invalid range error")
546
- }
547
- if !strings.Contains(err.Error(), "min port must be less than or equal to max port") {
548
- t.Fatalf("NewServer() error = %v, want invalid range error", err)
549
- }
550
-}
551
-
499
func TestRegisterLeaseDerivesFixedHostnameFromName(t *testing.T) {
500
t.Parallel()
501
@@ -635,6 +582,9 @@ func TestRegisterLeaseBuildsUDPEnabledRuntime(t *testing.T) {
582
if got := record.datagram.UDPPort(); got < 40000 || got > 40009 {
583
t.Fatalf("UDPPort() = %d, want port within %d-%d", got, 40000, 40009)
584
}
585
+ if resp.SNIPort != server.cfg.SNIPort {
586
+ t.Fatalf("RegisterResponse.SNIPort = %d, want %d", resp.SNIPort, server.cfg.SNIPort)
587
+ }
588
if resp.UDPAddr == "" {
589
t.Fatal("RegisterResponse.UDPAddr = empty, want public udp address")
590
}